From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, linux-i2c@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Thor Thayer <thor.thayer@linux.intel.com>,
Tang Bin <tangbin@cmss.chinamobile.com>,
Stephen Boyd <swboyd@chromium.org>,
Patrick Williams <alpawi@amazon.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Barry Song <baohua@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
George Cherian <gcherian@marvell.com>,
Hans de Goede <hdegoede@redhat.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v2] i2c: busses: remove duplicate dev_err()
Date: Thu, 16 Apr 2020 20:22:33 +0200 [thread overview]
Message-ID: <6ca3cd57-de73-5327-5773-e08bf12c4a85@web.de> (raw)
In-Reply-To: <20200416152345.23077-1-zhengdejin5@gmail.com>
> it will print an error message by itself when platform_get_irq()
> goes wrong. so don't need dev_err() in here again.
I suggest to improve the commit message considerably.
Would you like to integrate any information from a response
on the topic “drm/meson: Delete an error message in meson_dw_hdmi_bind()” by
a contributor like Neil Armstrong?
https://lore.kernel.org/dri-devel/54e0b6e4-4a39-c567-7355-2b2330a95294@baylibre.com/
https://lore.kernel.org/patchwork/comment/1418937/
https://lkml.org/lkml/2020/4/15/186
> v1 -> v2:
Will a version identification be sufficient without the arrow?
> - add 19 similar changes by Markus's suggestion.
* With which search tool did you find the presented update candidates?
* Will a link to the commit “driver core: platform: Add an error message
to platform_get_irq*()” (by Stephen Boyd from 2019-07-29) become helpful
as background information for such collateral evolution?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/platform.c?id=7723f4c5ecdb8d832f049f8483beb0d1081cedf6
Regards,
Markus
next prev parent reply other threads:[~2020-04-16 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 15:23 Dejin Zheng
2020-04-16 15:50 ` Andy Shevchenko
2020-04-16 18:22 ` Markus Elfring [this message]
2020-04-16 19:34 ` Joe Perches
2020-04-16 20:30 ` [v2] " Markus Elfring
2020-04-16 21:29 ` [PATCH v2] " Andy Shevchenko
2020-04-18 21:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ca3cd57-de73-5327-5773-e08bf12c4a85@web.de \
--to=markus.elfring@web.de \
--cc=aisheng.dong@nxp.com \
--cc=alpawi@amazon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=gcherian@marvell.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=narmstrong@baylibre.com \
--cc=swboyd@chromium.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=thor.thayer@linux.intel.com \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome