From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D643399345 for ; Tue, 31 Mar 2026 10:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951764; cv=none; b=FH305hEiZxHdnYi8VTUZp0kCiBDEjIsbUd/kEF5OzS5qXwemRJKfH51xSioXTKjKcXUusii4jaTQSCCGQ3Voul1LTLGS0JG7UIxUnvjKJtul+tG06PnPsRgCYUgP+MLVwyYUmOTUyvLT2Cc/K9G53CmMR0fpoFk6oj+g0BIHWzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951764; c=relaxed/simple; bh=i1PAKnGCcnJLsfppZH7sl9b19tpPCpbvSm/YXHmcDto=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=pV0M6nSrO3My4rwuLwFjcyxrhPVosXl2sNbLhhKwGnveqe0ZVZdrVVfAvu/xKFJv4qDtxwPwitvpmTNflDolDJEJmUFcbi4Hi/VDa2UJdIq1wytbW+G2M7lKGCbYj/HeMcbXkQw5sqHoroJUFUVXoVOtsMcv3HEs5MYL/LE6vEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DLT4vlyh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=USAUCnh1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DLT4vlyh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="USAUCnh1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V5QZkg2410022 for ; Tue, 31 Mar 2026 10:09:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l5PxjqeUHEa6eLwkA5Rfm1TAmpNQwAWliF0o+hYRZHk=; b=DLT4vlyhYAUOZ7Oe ugaXYJ9zmCj03KcfX7/2wB3sUs4Gy/Bq+v/4mxY5oEfrW8UFIlpk6wiSifoOQdPg ErcX6GzG95TLk+GAIP3SblP5OVlFBHOsl/RIaOYSZJusDVXmnO3Tch4cRLUu/r2f vn5zGEQcpS+Z3tk9Ky+ZAXmXCDKne1DPXHPMSOF+sdoBXv0KsIanHrGQAcCemGnl OugGjqxCjENqZ6Myhx2Yi7wT+4OPSviFrYHIBcBEGPJcdBVVz2opaAdUahbIoBVq bPxsaWHTxa3+AD5qzm9AbqkWQVwXjR2hekXfdznuoyx9TSjPRrikwkiNb/4jPuwe Le3tLQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d80hetk20-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:09:22 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50939597b85so140701721cf.2 for ; Tue, 31 Mar 2026 03:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774951762; x=1775556562; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l5PxjqeUHEa6eLwkA5Rfm1TAmpNQwAWliF0o+hYRZHk=; b=USAUCnh1vyGbdZjHDZGD19pgYrw5sFKLtrwyVv9sJAda4eSpOji1JTIFsxFjA/Nh5O MKwLXuV+oQTpfiLsnW7RNglU7oT3Xa5/oUZOVwdOItziS87J5CWR4eTU6Osj6255adJK RGPWcjKjEv4CpXJr3oN2Nx4ufpPyGnMyaGfKc+XkZd+fgKapp1DBfNexA7mIohbfQcC4 xw2sy/jDMJpgt5f/p/iGofzyIFXCeF4PSugdR4AzjMSoxBHpSlJLPkrvsatW2vZp4rcY MhNQd66LKdi6Lj4Jb+14CvhyDj9IDE58m7Dq9QK+NvAFkKK+d6MQ3SfGjaC08/Em5o6o jpuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774951762; x=1775556562; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l5PxjqeUHEa6eLwkA5Rfm1TAmpNQwAWliF0o+hYRZHk=; b=nhx1EVsZg7o9Huau58tM2KfKPm+L1XB3uHgwUzzGn9zLfMOfkwZy1euJMPbOF45Na0 HlwWk0HUGRXbrM/UcI7czs4WAn2uGuj1I2ZmoJToK7ho+3NsSLrUAIKEYQItchz7luPr vItyGpqemztwMdgzaxphkLD+UzV0j0x1fWbElwdLraleMZVGmHNrbXZsCtwHOO42UCvm Kx5/pf+UajobRQuWYkYoBE0FiFmUJEUM+iqZq7gYpN3Kch2GRA0Oe3zV5MMofkQo8xEs O2rpXZX7GnsgBYcHcNzQOJPwc/SHa1IojKO7BU1fcqmsSvHo/IZE37rFegH9oRfVztwQ pRsg== X-Forwarded-Encrypted: i=1; AJvYcCU2juVTsr+e7ICrtXL/qCpJ9I8hJ3yw11lgOTTlEzi27AS40EJ7MKYmPUkyrSHWMP/DdZANFVOIjnpDeGw=@vger.kernel.org X-Gm-Message-State: AOJu0YxqUxdqnstU9jbRqdOwNnM7vIyGMQjmyiQkmazWbWbWWf+YkDyy xBvQ1SX1IxpmZqS6hfO8TMQ/ueo6pmlhGWXKQaNkWdBxDAPHaR1A1p9oAI/hOCi9dL+HlLShaiO yxl7OHryWJk2yBxXMVMuMYDpA0qYQpqH7FQlKPx6wKHzTOb4e8ndSG5HZvplKqmmKIoE= X-Gm-Gg: ATEYQzwR8wXnCVrozqjtta3OHJKc5HbMOwUrLndT9m56/ZSo0MV5GzNgz7rYqiWb0Q5 hJHt3xj1Kr8yinqfdiZYokpKYOOI5NxrIvwd83uRJBsJgqvr6Om1WtdcIR7cACIR8Of2QwoxEo6 43zbbnRPurtPflPlRP0F25ejfnmzhMh7kPjZMlbIa9ifoEGxpahPARxu8JccOz5WWur4HPcN1bo oRs1LpHSBmNfXu+d08zyUPR9fxlay2nLksiaZ+r5hZCNhob09GdVIe7oAPS0/t5atr8ZQnRBqYu 8QLTn3gw4M+UaXx/je5n3lmmb6KNmvzDlAXPPJcqwe3hfEfOgNlJ3NowPtnjFbT/0aDa8rOxaJ1 HwDryHMYe6bpLcxfvgL6iI2+8P6+RoES+PIoMqTd9nLFjoAf4 X-Received: by 2002:a05:622a:154:b0:506:2041:13d6 with SMTP id d75a77b69052e-50ba39655d1mr207868531cf.50.1774951761814; Tue, 31 Mar 2026 03:09:21 -0700 (PDT) X-Received: by 2002:a05:622a:154:b0:506:2041:13d6 with SMTP id d75a77b69052e-50ba39655d1mr207868281cf.50.1774951761447; Tue, 31 Mar 2026 03:09:21 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e72da6csm49983705e9.0.2026.03.31.03.09.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:09:20 -0700 (PDT) Message-ID: <6ca492d7-c041-42b0-8f41-cd29ab7b4bab@oss.qualcomm.com> Date: Tue, 31 Mar 2026 12:09:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] clk: qcom: Constify qcom_cc_driver_data To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Maxime Coquelin , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260331091721.61613-3-krzysztof.kozlowski@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Gb0aXAXL c=1 sm=1 tr=0 ts=69cb9d52 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=oW2FW_nDJJYFMtiP85gA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: OKa7Xbz1VMblo1Tup66xi017d1UiTiej X-Proofpoint-ORIG-GUID: OKa7Xbz1VMblo1Tup66xi017d1UiTiej X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5NyBTYWx0ZWRfX00WlQLnlctBt csXJNXf5luLJkE2w9F+NZk13+p3ajmPpdoQgSiE7QcM6c8HntQaMakT28J25KfTJDsZdxrKcIDo QcWx1DaUAYX9wdvX+4hzXcvVc4nLOUZmF4STfnv8eN3DJpknGDN9mShf1lKJIT2JxR9r52JfDr7 mjv/SpCT6jcY8iY+6yNh1dHxPPrgSsptgGi24zazrLNjf1nsyLURlzpec7dycPWZraZ1+0FllI0 IgS21UTSivQM8bpxNADHVycwqH5Y67BU6WC7FAlqVVXdE7KGbQrwjG8TTKUfzw/JclE6aUsNp6O 2XzHuTP2VXLJ53dPdVh6YC7i9sSoAqCFHNkDBsyGx6Dm8c6WO40FLMDpB99YOuWRvQmqdnWXa7E F4wn28SevmVvS/Lj6HiMU6NcM4sZUmpiqIaA7twmwiG2qDty6u9fXayS4TPyxlwP2jPuNvT/AMg /qhtILo1WxqLq63qiEg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310097 On 31/03/2026 11:33, Konrad Dybcio wrote: > On 3/31/26 11:17 AM, Krzysztof Kozlowski wrote: >> The static 'struct qcom_cc_driver_data' contains probe match-like data >> and is not modified: neither by the driver defining it nor by common.c >> code using it. >> >> Make it const for code safety and code readability. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [...] > >> --- a/drivers/clk/qcom/common.h >> +++ b/drivers/clk/qcom/common.h >> @@ -49,7 +49,7 @@ struct qcom_cc_desc { >> size_t num_icc_hws; >> unsigned int icc_first_node_id; >> bool use_rpm; >> - struct qcom_cc_driver_data *driver_data; >> + const struct qcom_cc_driver_data *driver_data; > > This can be a const ptr to const data, even None of other elements in 'qcom_cc_desc' is const pointer, even though they also could. If doing this change, let's make it consistent - so shall all of them be const? Best regards, Krzysztof