From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE2E83CF207 for ; Thu, 16 Jul 2026 09:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194968; cv=none; b=QC8Gnb8m0AwhC1AXbrlh3QVvjPMAOAgaptDg+wooS5qv+PNPUgqWKpstV6a5GbJYBZE6MYrqvE4cbTfNd0SOza2iAADzw8g5ofno2M9LDo3EAJNzS80JMs/wxESvPk6a0H6bYCuh97eVClQiFPeVaCDHWLWUsY40RgLAOkk6ejA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194968; c=relaxed/simple; bh=5HkbT5VTjQEbCphRnfj+qtVR3I6tfp3ysrSh9PXdd8g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FIWIKM4Z39pW02PHd3D66Af8GgOu4AONvM0qlOii93pTqmBtGp66XQXFSoz5aaPH+jJdSaQJkEr5bmncrathufHWrzuThYBfffFynzj83rzzi29yZmvhhTs35OJHsQJmjyG7cFatMaM4tH8RGmo5gNKW+7G9ER4n5xZBmSv71mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HaDXCFgl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bi5rqSQX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HaDXCFgl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bi5rqSQX" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G7DvCt2115250 for ; Thu, 16 Jul 2026 09:42:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HzsM35EiZJ/yzPPIs0XjKw5tRsijyewrzXg6CrcCnPo=; b=HaDXCFglMZs0ti8S pzu3gBUeeawMCDZsYTLiTxpDkYKE9KNf+CRRt9U1jbC8Fb/hQYixA8KGO7puSrsS 7ljMkbD2umyqmI97nEHvFoMZZ4wdLNRNQ0DtSqg/lZWVq8TYBp0FweIWkAmeCSNC tjLLDpCvEKHKaCfNFRSlStd/xTDo0kfdu9B+TGGSCq1/tNXthCMFKlIziL22xBHs quYjWGBaIyx9hqWsE6lJq+2lAv8P86Y81cojjd1XLeG2U0XqOUBDtgZ6PuXOeRpD b766iclZDEZkSd6cjegBOWvS/Pv+AIbD7X41mO+NV+elMXqkA6iyNGXDTWXDqvar C9OlzA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4feeg1k4da-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 09:42:45 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e5110c89eso151673585a.3 for ; Thu, 16 Jul 2026 02:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784194965; x=1784799765; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HzsM35EiZJ/yzPPIs0XjKw5tRsijyewrzXg6CrcCnPo=; b=bi5rqSQXKy1zt/i0HCqX8BhJC88RyM+jubVRVk3y9bfGbSCpW7sX1Lx0p13UDcmA14 68NFGhVpon45+z00KrVFrkF+HQl1bZEoTTGAW0B9/ery0oGpodLlvs8H2pjIGwQhF/WV A3s/G4BL6+hWRIrn4eaLWoT4L/YToWo+AvRp6rXjOPzULRsah8C6r05kKfnTBBTUGoPN QLWfONJfgUk4C0zUI5Xu/+LmRuKQoDhGJd3tEuubD6+vATHOJl5krNTYdES9Ba/XegLJ IrtgX8ziCSLgHQ0X2NFCUHIQ2lcvF8yYIbr9LqdO5LVbiZc0cHxhIL80Y6hAnr5BUaRE DaIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784194965; x=1784799765; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HzsM35EiZJ/yzPPIs0XjKw5tRsijyewrzXg6CrcCnPo=; b=O3L3zrvbpg5+2awy8H507h7lGQ1T6su0pJ17fcraL0JNeyEuVfBfy3t21D0W9hb+5B 3jGsVAPqINe6VCFOJuP6ov1oas1/DgJ2SZWD6z6Hf4+NcrSZa3Gz9KPC58FOhzfuv05P fhWbqQIAsN9+Jk9furhoaedScodVsvbcxiZImJjNYhH4gVtU/rnp2LgQ4cPim9zyRYHe GZXuwlNtGQeOpEF55koE+3iT4P+5QXjTwibGQFeuem0JGEMmL3NtFAF2hhBSxHf6Obym dZNf7BuNLxOzOt0ELcgPMf7QRm8yNkvTPqlvkZIh19U2oiShShtBvmpMO/eDh3Jb7qaV AKsA== X-Forwarded-Encrypted: i=1; AHgh+RpZO9JpRQNXqMV4J0d4RT4PfAd8MRjXeqZdb9/tpWcIUUJBjxRsEx4yu70U+2vRmwjkFl+N/cAzuFbXAMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8F3cy+kEGkiQjhRg70vwFTMNmjv5SMP6WMl9mKhDvbitMjPNM WgBaATmVQ15DVBYPcTBOjnlvVI3KV446k5npg8KUiJSVK5zAEDpNfGFaTZg7++ftZ4K6AqtMB8c dQBwDwUfAtWoCL31UELxo8lxwpXfUhn++s3UZtPwg6rG+ym03ePADt9Caaq0Ooue4JdI= X-Gm-Gg: AfdE7cmptAxNgAIabIdhjrwmEkoPH4fAyx74sDv2ziT2J5m9QdAbNAayRt/MSDD5KoQ 7453r/ZpoxRCBsRP8b5QwtwMXzhFkbmhMb8xVliG4lAjh69MExsYU4bH8FV7Koo0A5Xqt66wxl7 VlEsYpiPyZz/rv2xK/K1oBS02BK/Ts0aMknfbJ14/GiaxCtqVZBWMOmEBwE0jeJ9H3D4I7kjnss ohnXuGDKJfl/UyuOs0yxpMRHEn/8QbpSBXV4cTwTZY++STz2hR10VC8cbRq5rc4mZHRAnYKa1jp DKrjdqZsWhKjXmT0iBNAQnTWEWkjdjqo8zm07Ssf5QXuxdOJJkpT2Wg3OnxJVTA9c4V26xsn3jM gEvuCTjobHEJ13q65++nSqTGc X-Received: by 2002:a05:620a:318f:b0:92e:705f:1626 with SMTP id af79cd13be357-92ef2c65077mr1810282685a.6.1784194965174; Thu, 16 Jul 2026 02:42:45 -0700 (PDT) X-Received: by 2002:a05:620a:318f:b0:92e:705f:1626 with SMTP id af79cd13be357-92ef2c65077mr1810281085a.6.1784194964806; Thu, 16 Jul 2026 02:42:44 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c16871264basm176210666b.7.2026.07.16.02.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 02:42:44 -0700 (PDT) Message-ID: <6caf8ca0-8be5-4935-9766-10d21c71ac37@oss.qualcomm.com> Date: Thu, 16 Jul 2026 11:42:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] iommu/msm: Fix dangling list entry on probe failure To: Weimin Xiong Cc: Mukesh Ojha , robin.clark@oss.qualcomm.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260716013229.91014-1-xiongwm2026@163.com> <20260716085313.207069-1-xiongwm2026@163.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260716085313.207069-1-xiongwm2026@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDEwMCBTYWx0ZWRfX16u3ykscrRVe IxX2Xie+SUKQ3U/vajcr/m4+KvvlayYRqs7wXnrrQV/ACpoOHmkceBGyGmVosSyigTLr8FrEvx/ JNrAJRnLSzgIb/ycKpV+vjYg7WHkKaR5j71Fj1tf9IGzsMhwcbjUAkOo7NJgStysOJyeSGGWjaM EadMPY+0WJcZmFGix8GKZ0CtqX6ThvVgt6Soc0ct1avJvV3zyr/tQ0mPY2x2Xn8Elc0t/TGlXjs CPsGA00dCKNCm+brenBIOz8oCasX7UjsJcPTjpbT8IQkN6ivMcupvsMJ8464GVdPIe+G0f/6UoB /Uc9QRz3ri+jgc+6VRDsxecmow9IFUhqQVvdfFYtJlDRCxeMATV5fIh52eoljVV2wUUxYiLGQZD ZlSAyXwC9WrGKpIByj1sHOevlvhV3wzqkMQz3Bo6RWFpLFeNZZbkKxzjjJJLIcMDgeB/eu7giiG 812z1L1/6V9TMR/wl4g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDEwMCBTYWx0ZWRfXxNly4YrgoipP yW9Pptc5/liRcFFpFxG3moR8am3X4mtfaQjxhzlNqqN4OKZK+P5tMhQNtRMqdjAVjpM8lb965XY j2yoVYejRZgdnSPnMJLpKwaVxFkeU8s= X-Proofpoint-GUID: rK-M0_COhD7jK7eHzeihRX-588LfVSFT X-Proofpoint-ORIG-GUID: rK-M0_COhD7jK7eHzeihRX-588LfVSFT X-Authority-Analysis: v=2.4 cv=SsOgLvO0 c=1 sm=1 tr=0 ts=6a58a795 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=n3OY92c7DukLRWByAxYA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_03,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160100 On 7/16/26 10:53 AM, Weimin Xiong wrote: > Move the list_add() call to the end of msm_iommu_probe() instead of > adding cleanup paths, which avoids the dangling list entry problem > entirely (suggested by Mukesh Ojha). > > This approach simplifies the code by ensuring the iommu device is > never added to the global list until after all potential failure > points have passed. > > Changes in v3: > - Move list_add() to the end instead of adding cleanup labels > (suggested by Mukesh Ojha) I think this approach introduces a race condition, because e.g. iommu_ops->of_xlate() depends on the item being present in this list Konrad