mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Willy Tarreau <w@1wt.eu>, Shuah Khan <shuah@kernel.org>,
	 Matt Turner <mattst88@gmail.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 linux-alpha@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	 John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH] tools/nolibc: add support for Alpha
Date: Mon, 14 Jul 2025 07:21:38 +0200	[thread overview]
Message-ID: <6cb31334-8b39-4920-810e-de123898a2e0@t-8ch.de> (raw)
In-Reply-To: <ceef9e43-5591-4c03-ba51-af1ccc68a05b@linaro.org>

Hi Richard,

On 2025-07-13 16:21:58-0600, Richard Henderson wrote:
> On 7/13/25 14:08, Thomas Weißschuh wrote:
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -709,6 +709,10 @@ int run_startup(int min, int max)
> >   	/* checking NULL for argv/argv0, environ and _auxv is not enough, let's compare with sbrk(0) or &end */
> >   	extern char end;
> >   	char *brk = sbrk(0) != (void *)-1 ? sbrk(0) : &end;
> > +#if defined(__alpha__)
> > +	/* the ordering above does not work on an alpha kernel */
> > +	brk = NULL;
> > +#endif
> 
> The syscall api is different for brk on alpha.
> A change to sys_brk or brk in include/nolibc/sys.h is required.

You are referring to osf_brk, right?
I think that should work as-is with the current wrappers.
On alpha, mm->brk and mm->arg_start are ordered differently from other
architectures. Personally I think the nolibc tests are a bit bogus here.


Thomas

  reply	other threads:[~2025-07-14  5:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-13 20:08 Thomas Weißschuh
2025-07-13 20:11 ` John Paul Adrian Glaubitz
2025-07-13 22:21 ` Richard Henderson
2025-07-14  5:21   ` Thomas Weißschuh [this message]
2025-07-15  6:28     ` Willy Tarreau
2025-07-15 14:42       ` Thomas Weißschuh
2025-07-16  6:50         ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb31334-8b39-4920-810e-de123898a2e0@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=arnd@arndb.de \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=shuah@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®