From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751260AbdKTJIh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 04:08:37 -0500
Received: from esa4.microchip.iphmx.com ([68.232.154.123]:15910 "EHLO
        esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750777AbdKTJIf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 04:08:35 -0500
X-IronPort-AV: E=Sophos;i="5.43,434,1503385200"; 
   d="scan'208";a="8740257"
Subject: Re: [PATCH 2/2 v3] misc: atmel-ssc: Fix platform_get_irq's error
 checking
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>, <joel@jms.id.au>,
        <alexandre.belloni@free-electrons.com>, <linux@armlinux.org.uk>
CC: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
References: <3ce95a4e4eb4476b19868f36cd1f11e4b62b6203.1511065797.git.arvind.yadav.cs@gmail.com>
 <fbe464e8bd8039463c4984835286b19060509f82.1511065797.git.arvind.yadav.cs@gmail.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <6cb39a71-ebba-fa26-41e1-0a0cb0bb4748@microchip.com>
Date: Mon, 20 Nov 2017 10:08:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <fbe464e8bd8039463c4984835286b19060509f82.1511065797.git.arvind.yadav.cs@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/11/2017 at 05:34, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
> changes in v3:
>               Return -ENODEV instead of ssc->irq.

Okay, I didn't see this v3 before commenting on v2...

> 
>  drivers/misc/atmel-ssc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index b2a0340..2ec0f9e 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev)
>  	clk_disable_unprepare(ssc->clk);
>  
>  	ssc->irq = platform_get_irq(pdev, 0);
> -	if (!ssc->irq) {
> +	if (ssc->irq <= 0) {
>  		dev_dbg(&pdev->dev, "could not get irq\n");
>  		return -ENXIO;
>  	}
> 


-- 
Nicolas Ferre