From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.86 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794027752; b=0dHEbEerioGx3R5+qJwf4YUi0EE+aEBcx2nE2MB7KW9jOP7syFalmVfDzmLCB9ESCeVB KneWy1nBZms5scPYeuMKtV6PHY+Zzx5ZB54NcyFUxLRWwsu+QDbLXnRvHH3hgG+dO+Af3 BHXagvPHNGBN4q1k9e5tM3GMlnyrgLjBKE57QfBRTz7eg8qZuURGCkprhvFQEfkodEsHh G2bhSjENuUqh8Vl5zt5Pd684C+jqs4ufhCe4gTJsL6753uGm2bVcmTh3h0T7Al7e6wIe4 vIMkRHr0zz379xkBYd+K4e+4dpFn4J9ou7b9ppB+pbvbPtutFyrVW4eFeSholY+XWTw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794027752; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=n3tYryr7zzQ8LqyZ0K7pIJBeJLogxInZJgVPz9lzEuI=; b=lMBHWJc3rCBk6zfu9gtiQQmBGyrz4siiO6wsU83E0raBn4tpYdne468AkE8t+7DqruRc tRPTUXl2PYe2kWZ5pcHqg8dTCKN+VdrjxO/rAli4bdJMrhhUqCS1hGK1GWO8ys3RyKeRF 5kt+hSTtL3ng6lnTP46SCzva/zgfuqJnQwe/ZA/mWSGfDUPoU92ZwLvrJHLXJn4RjH0we qFOVSOCMWeE1twpDXiZ7nQ+pz+0y+C/u9ARIuJHxyE/cFBdEVvAjm2LkH6T6G6mON7dOm FJw0jDeIGFWziGePfE27p1ma7ylzNA8M8LqLzqM6jo9/nLQfCM9cvZOBFa8824UWMuw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=WZ96zvVG; arc=none smtp.remote-ip=95.215.58.86 Received: from mta1.migadu.com (out-86.mta1.migadu.com [95.215.58.86]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E45E9606A326 for ; Sat, 7 Nov 2026 05:02:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E45E9606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=WZ96zvVG X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=n3tYryr7zzQ8LqyZ0K7pIJBeJLogxInZJgVPz9lzEuI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794027748; v=1; x=1794632548; b=WZ96zvVG3x71foE11pN/mEGy/Xu/62o9S+McTlC7mQAAKxiv1RwVW5rDjzH7CIfcKnQwS2vE hAjU3LBwvhropjwXwgCxhWsAjB1Y8JK+95hNsrxoSWTIer5iV1SWXBUFyQsUkNQKgb1HZq8xF/m ks2clnkfSx6ihUOw5AVpIeFk= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 10673def8ae0b7b1; Sat, 07 Nov 2026 05:02:28 +0000 X-Mizu-Trace-ID: 10673def8ae0b7b1 X-Migadu-Flow: FLOW_OUT Message-ID: <6cb5fe89-c6f0-4e84-b753-4425b1aebe1e@linux.dev> Date: Sat, 7 Nov 2026 13:02:23 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: reuseport: avoid duplicate closed socket insertion To: Lin Jiapeng , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Martin KaFai Lau , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: TencentOS Corvus AI , stable@vger.kernel.org, Lin Jiapeng References: <20261106135841.418-1-ljp1205831794@gmail.com> From: Jiayuan Chen In-Reply-To: <20261106135841.418-1-ljp1205831794@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/6/26 9:58 PM, Lin Jiapeng wrote: > Clearing SO_REUSEPORT on a TCP listener clears sk_reuseport but leaves > sk_reuseport_cb attached to its reuseport group. A subsequent listen() > does not put the socket back into the listening section because > inet_hash() checks sk_reuseport. However, inet_unhash() checks > sk_reuseport_cb and calls reuseport_stop_listen_sock(). > > With request migration enabled, reuseport_stop_listen_sock() ignores > whether __reuseport_detach_sock() actually removed the socket from the > listening section and unconditionally appends it to the closed section. > Repeated connect(AF_UNSPEC)/listen() cycles therefore insert the same > socket until num_closed_socks exceeds max_socks. The next insertion > writes before socks[], overlapping prog on x86-64 and leading to type > confusion when a reuseport program is attached or detached. Is the issue same as Eric's patch ? https://lore.kernel.org/netdev/20261106084300.2029567-1-edumazet@kernel.org/