mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alistair <alistair@alistair23.me>
To: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
	linux-input@vger.kernel.org
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: input: cyttsp5: document vddio-supply
Date: Sat, 19 Nov 2022 09:27:39 +1000	[thread overview]
Message-ID: <6cb6c30b-2670-446a-8425-92d340ab5b90@app.fastmail.com> (raw)
In-Reply-To: <20221117190507.87535-2-linmengbo0689@protonmail.com>

On Fri, 18 Nov 2022, at 5:05 AM, Lin, Meng-Bo wrote:
> The Samsung touchscreen controllers are often used with external pull-up
> for the interrupt line and the I2C lines, so we might need to enable
> a regulator to bring the lines into usable state. Otherwise, this might
> cause spurious interrupts and reading from I2C will fail.
> 
> Document support for a "vddio-supply" that is enabled by the cyttsp5
> driver so that the regulator gets enabled when needed.
> 
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

> ---
> .../devicetree/bindings/input/touchscreen/cypress,tt21000.yaml | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> index 1959ec394768..869a9bdd962f 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml
> @@ -34,6 +34,9 @@ properties:
>    vdd-supply:
>      description: Regulator for voltage.
>  
> +  vddio-supply:
> +    description: Optional Regulator for I/O voltage.
> +
>    reset-gpios:
>      maxItems: 1
>  
> -- 
> 2.30.2
> 
> 
> 

  parent reply	other threads:[~2022-11-18 23:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 19:05 [PATCH 0/2] Input: cyttsp5 - add vddio regulator Lin, Meng-Bo
2022-11-17 19:05 ` [PATCH 1/2] dt-bindings: input: cyttsp5: document vddio-supply Lin, Meng-Bo
2022-11-18  8:11   ` Krzysztof Kozlowski
2022-11-18 23:27   ` Alistair [this message]
2022-11-17 19:05 ` [PATCH 2/2] Input: cyttsp5 - add vddio regulator Lin, Meng-Bo
2022-11-17 21:16   ` Christophe JAILLET
2022-11-17 22:15     ` Dmitry Torokhov
2022-11-17 22:17   ` Dmitry Torokhov
2022-11-17 22:39     ` Lin, Meng-Bo
2022-11-18 23:29   ` Alistair

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb6c30b-2670-446a-8425-92d340ab5b90@app.fastmail.com \
    --to=alistair@alistair23.me \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linmengbo0689@protonmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®