From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C568C1DFED for ; Mon, 18 Nov 2024 08:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731918318; cv=none; b=AFcdIEuWQFj0DTT8Gx0QEzZ/zdVAv4/tiDAB07aVNJMVwFayRLeWUGL69CBRJcb3SrS98axa3hd4362JdgDMhZ2WQb5Ecjtqj2n00HPT/ONZhl2OaEC0agGyjvFH2b16qsiV/F8bQ6H/9kSeqdMsC4xzGNNbDD1qEPi4QYvuB0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731918318; c=relaxed/simple; bh=UpgEHAAMjPRDhBcRyEpbCmBLETFsZ5uZYzMGEdIXXdc=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=SB89W8DLoordLzGHzB1lOXlaj1HNlnl/pZVBW9jkela92AwYvfmy7nuvZddeQjI1+hARfWsZ8QmHaqqPnhFUbUeRzEEt94R+mn4Dvd9ir9KHwoIK3RuqmZ1zRkAhBfEIsQxYCmXNPGzC8KRwOtNqoJHWvaskqiuzl7rpLRk4ZCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fyt7DeDw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fyt7DeDw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731918315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ur0rNqPMEaWqtffTSUQdmBAbFxPrMdDvukYK5hzARoE=; b=Fyt7DeDwqhG9vG9fgqw/m01b3aJfNc8etSryrux5Z6KVlV8C2jLBeELx0kER2uBEuXSmk0 IoiKvFIdfuFgCZ5vpeiypewHRn6CJsb2V8hroJZL4oV6uHW8FHQfTVBvNdRo4lN1+jy7Zd MRz7ASE1fqubzE5OiN/0kKzWOrC/rR8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-P304FRBAMvecqAzeHwvvMQ-1; Mon, 18 Nov 2024 03:25:13 -0500 X-MC-Unique: P304FRBAMvecqAzeHwvvMQ-1 X-Mimecast-MFC-AGG-ID: P304FRBAMvecqAzeHwvvMQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4316300bb15so28157675e9.2 for ; Mon, 18 Nov 2024 00:25:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731918312; x=1732523112; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ur0rNqPMEaWqtffTSUQdmBAbFxPrMdDvukYK5hzARoE=; b=Nj0geFq4tFT29Vdr/dKDPU1IfO33cir3F4ZQCtxyXK+NQBN+NKGjgZep3k8tN1FO7T +UlYstHnpWiV+rLfzivJOqbdki9t4UlvK9TnwubA/oGHiFDZm5UQeOipAbVS++7MZyl2 9/RabdXTFsrdU9nRSUBU31l7Z83Vu4kAnMG5czipxMF15Kv9T81sG/YGT5UBV6y6SKCA 77KIU5Jibxz+wYABhzjX4RucWiWYaI3c2Olk+DU2XUJ6GXoslgLig0yLP8qK1xEPeKOq wnazdlCZCCF+cTuwLiUtxNqi2Q8jdUIQFzInL1x0ZTGEEo7UYieqjV4Wo44mvH8tBoFt XOAA== X-Forwarded-Encrypted: i=1; AJvYcCWRRS5FPLVlEDFGTrOycDMExjdq7jGqh4fbChFCZLrKzX6YQ8Ls2EHG+qBmM+/GDeyMyN9g9hItlecIHpI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2YRVjHltv9EBNSEZ/xZ/jzx4GqArx/5cwhcGde4q1qU6j5UVR JbGnVz61N0mjP5T061WQ8I4YqzG8AdwMxasUn3iz8dQzFzPsa+vB7uK+IrmNPl23FZwAQSDhGg6 +xhoBUwLZBu/DzV/SWahdgdMMv6kPd8pOP/CzIZnMtjePJpFCbOlODbgYEMfCoQ== X-Received: by 2002:a05:600c:3acf:b0:425:7bbf:fd07 with SMTP id 5b1f17b1804b1-432ebcd4267mr39842665e9.5.1731918312374; Mon, 18 Nov 2024 00:25:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEza8e7WfmfiQGOB8LfU45xyP/TDGBkfeYiEtOzDIS9FRI96odglx0FAos24VgLPYfVqDQoDA== X-Received: by 2002:a05:600c:3acf:b0:425:7bbf:fd07 with SMTP id 5b1f17b1804b1-432ebcd4267mr39842375e9.5.1731918312052; Mon, 18 Nov 2024 00:25:12 -0800 (PST) Received: from [192.168.88.24] (146-241-44-112.dyn.eolo.it. [146.241.44.112]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da27ffafsm150140445e9.22.2024.11.18.00.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Nov 2024 00:25:11 -0800 (PST) Message-ID: <6cbc88fa-1479-4e44-950a-6d3881197520@redhat.com> Date: Mon, 18 Nov 2024 09:25:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [net?] WARNING in sk_skb_reason_drop To: dongml2@chinatelecom.cn, menglong8.dong@gmail.com References: <6738e539.050a0220.e1c64.0002.GAE@google.com> Content-Language: en-US Cc: syzbot , davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, horms@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com From: Paolo Abeni In-Reply-To: <6738e539.050a0220.e1c64.0002.GAE@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/16/24 19:32, syzbot wrote: > HEAD commit: a58f00ed24b8 net: sched: cls_api: improve the error messag.. > git tree: net-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=140a735f980000 > kernel config: https://syzkaller.appspot.com/x/.config?x=47cb6c16bf912470 > dashboard link: https://syzkaller.appspot.com/bug?extid=52fbd90f020788ec7709 > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=132804c0580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14f481a7980000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/d28dcea68102/disk-a58f00ed.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/8ec032ea06c6/vmlinux-a58f00ed.xz > kernel image: https://storage.googleapis.com/syzbot-assets/da9b8f80c783/bzImage-a58f00ed.xz > > The issue was bisected to: > > commit 82d9983ebeb871cb5abd27c12a950c14c68772e1 > Author: Menglong Dong > Date: Thu Nov 7 12:55:58 2024 +0000 > > net: ip: make ip_route_input_noref() return drop reasons > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10ae41a7980000 > final oops: https://syzkaller.appspot.com/x/report.txt?x=12ae41a7980000 > console output: https://syzkaller.appspot.com/x/log.txt?x=14ae41a7980000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+52fbd90f020788ec7709@syzkaller.appspotmail.com > Fixes: 82d9983ebeb8 ("net: ip: make ip_route_input_noref() return drop reasons") > > netlink: 'syz-executor371': attribute type 4 has an invalid length. > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 5842 at net/core/skbuff.c:1219 __sk_skb_reason_drop net/core/skbuff.c:1216 [inline] > WARNING: CPU: 0 PID: 5842 at net/core/skbuff.c:1219 sk_skb_reason_drop+0x87/0x380 net/core/skbuff.c:1241 > Modules linked in: > CPU: 0 UID: 0 PID: 5842 Comm: syz-executor371 Not tainted 6.12.0-rc6-syzkaller-01362-ga58f00ed24b8 #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 > RIP: 0010:__sk_skb_reason_drop net/core/skbuff.c:1216 [inline] > RIP: 0010:sk_skb_reason_drop+0x87/0x380 net/core/skbuff.c:1241 > Code: 00 00 00 fc ff df 41 8d 9e 00 00 fc ff bf 01 00 fc ff 89 de e8 ea 9f 08 f8 81 fb 00 00 fc ff 77 3a 4c 89 e5 e8 9a 9b 08 f8 90 <0f> 0b 90 eb 5e bf 01 00 00 00 89 ee e8 c8 9f 08 f8 85 ed 0f 8e 49 > RSP: 0018:ffffc90003d57078 EFLAGS: 00010293 > RAX: ffffffff898c3ec6 RBX: 00000000fffbffea RCX: ffff8880347a5a00 > RDX: 0000000000000000 RSI: 00000000fffbffea RDI: 00000000fffc0001 > RBP: dffffc0000000000 R08: ffffffff898c3eb6 R09: 1ffff110023eb7d4 > R10: dffffc0000000000 R11: ffffed10023eb7d5 R12: dffffc0000000000 > R13: ffff888011f5bdc0 R14: 00000000ffffffea R15: 0000000000000000 > FS: 000055557d41e380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000056519d31d608 CR3: 000000007854e000 CR4: 00000000003526f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > kfree_skb_reason include/linux/skbuff.h:1263 [inline] > ip_rcv_finish_core+0xfde/0x1b50 net/ipv4/ip_input.c:424 > ip_list_rcv_finish net/ipv4/ip_input.c:610 [inline] > ip_sublist_rcv+0x3b1/0xab0 net/ipv4/ip_input.c:636 > ip_list_rcv+0x42b/0x480 net/ipv4/ip_input.c:670 > __netif_receive_skb_list_ptype net/core/dev.c:5715 [inline] > __netif_receive_skb_list_core+0x94e/0x980 net/core/dev.c:5762 > __netif_receive_skb_list net/core/dev.c:5814 [inline] > netif_receive_skb_list_internal+0xa51/0xe30 net/core/dev.c:5905 > netif_receive_skb_list+0x55/0x4b0 net/core/dev.c:5957 > xdp_recv_frames net/bpf/test_run.c:280 [inline] > xdp_test_run_batch net/bpf/test_run.c:361 [inline] > bpf_test_run_xdp_live+0x1b5e/0x21b0 net/bpf/test_run.c:390 > bpf_prog_test_run_xdp+0x805/0x11e0 net/bpf/test_run.c:1318 > bpf_prog_test_run+0x2e4/0x360 kernel/bpf/syscall.c:4266 > __sys_bpf+0x48d/0x810 kernel/bpf/syscall.c:5671 > __do_sys_bpf kernel/bpf/syscall.c:5760 [inline] > __se_sys_bpf kernel/bpf/syscall.c:5758 [inline] > __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5758 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f18af25a8e9 > Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007ffee4090af8 EFLAGS: 00000246 ORIG_RAX: 0000000000000141 > RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f18af25a8e9 > RDX: 0000000000000048 RSI: 0000000020000600 RDI: 000000000000000a > RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > If the report is already addressed, let syzbot know by replying with: > #syz fix: exact-commit-title > > If you want syzbot to run the reproducer, reply with: > #syz test: git://repo/address.git branch-or-commit-hash > If you attach or paste a git patch, syzbot will apply it before testing. > > If you want to overwrite report's subsystems, reply with: > #syz set subsystems: new-subsystem > (See the list of subsystem names on the web dashboard) > > If the report is a duplicate of another one, reply with: > #syz dup: exact-subject-of-another-report @Menglong Dong: could you please have a look? The repro looks deterministic, so it should be doable to pin-point the actual, bad drop_reason and why/which function is triggering it. My wild guess is that an ERRNO is type-casted to drop reason instead of being converted. Cheers, Paolo