From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E065FC4363D for ; Thu, 1 Oct 2020 01:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FEF021974 for ; Thu, 1 Oct 2020 01:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730660AbgJABoM (ORCPT ); Wed, 30 Sep 2020 21:44:12 -0400 Received: from smtprelay0167.hostedemail.com ([216.40.44.167]:53716 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725800AbgJABoL (ORCPT ); Wed, 30 Sep 2020 21:44:11 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 7EE063648; Thu, 1 Oct 2020 01:44:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: hate49_5204d4a27197 X-Filterd-Recvd-Size: 2746 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Thu, 1 Oct 2020 01:44:09 +0000 (UTC) Message-ID: <6cbd011cef2e52f39812bc8f6505fdd95f98d14d.camel@perches.com> Subject: Re: [PATCH v5 09/15] misc: bcm-vk: add VK messaging support From: Joe Perches To: Scott Branden , Arnd Bergmann , Greg Kroah-Hartman Cc: Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Desmond Yan Date: Wed, 30 Sep 2020 18:43:44 -0700 In-Reply-To: <20201001012810.4172-10-scott.branden@broadcom.com> References: <20201001012810.4172-1-scott.branden@broadcom.com> <20201001012810.4172-10-scott.branden@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-09-30 at 18:28 -0700, Scott Branden wrote: > Add message support in order to be able to communicate > to VK card via message queues. trivia: > +/* structure that is used to faciliate displaying of register content */ > +struct bcm_vk_entry { > + const u32 mask; > + const u32 exp_val; > + const char *str; > +}; [] > +/* > + * alerts that could be generated from peer > + */ > +struct bcm_vk_entry const bcm_vk_peer_err[BCM_VK_PEER_ERR_NUM] = { const struct bcm_vk_entry > + {ERR_LOG_UECC, ERR_LOG_UECC, "uecc"}, > + {ERR_LOG_SSIM_BUSY, ERR_LOG_SSIM_BUSY, "ssim_busy"}, > + {ERR_LOG_AFBC_BUSY, ERR_LOG_AFBC_BUSY, "afbc_busy"}, > + {ERR_LOG_HIGH_TEMP_ERR, ERR_LOG_HIGH_TEMP_ERR, "high_temp"}, > + {ERR_LOG_WDOG_TIMEOUT, ERR_LOG_WDOG_TIMEOUT, "wdog_timeout"}, > + {ERR_LOG_SYS_FAULT, ERR_LOG_SYS_FAULT, "sys_fault"}, > + {ERR_LOG_RAMDUMP, ERR_LOG_RAMDUMP, "ramdump"}, > + {ERR_LOG_MEM_ALLOC_FAIL, ERR_LOG_MEM_ALLOC_FAIL, "malloc_fail warn"}, > + {ERR_LOG_LOW_TEMP_WARN, ERR_LOG_LOW_TEMP_WARN, "low_temp warn"}, > + {ERR_LOG_ECC, ERR_LOG_ECC, "ecc"}, > +}; > + > +/* alerts detected by the host */ > +struct bcm_vk_entry const bcm_vk_host_err[BCM_VK_HOST_ERR_NUM] = { here too > + {ERR_LOG_HOST_PCIE_DWN, ERR_LOG_HOST_PCIE_DWN, "PCIe_down"}, > + {ERR_LOG_HOST_HB_FAIL, ERR_LOG_HOST_HB_FAIL, "hb_fail"}, > + {ERR_LOG_HOST_INTF_V_FAIL, ERR_LOG_HOST_INTF_V_FAIL, "intf_ver_fail"}, > +}; [] > @@ -970,6 +1251,9 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > } > } > > + /* enable hb */ > + bcm_vk_hb_init(vk); > + > dev_dbg(dev, "BCM-VK:%u created, 0x%p\n", id, vk); Not much purpose in displaying the pointer.