From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varada Pavani <v.pavani@samsung.com>,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
s.nawrocki@samsung.com, cw00.choi@samsung.com,
alim.akhtar@samsung.com, mturquette@baylibre.com,
sboyd@kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: gost.dev@samsung.com
Subject: Re: [PATCH v2 1/2] clk: samsung: Use samsung CCF common function
Date: Wed, 5 Mar 2025 20:15:28 +0100 [thread overview]
Message-ID: <6cbd3df3-344f-4c4f-886d-f0bb99b824da@kernel.org> (raw)
In-Reply-To: <20250225131918.50925-2-v.pavani@samsung.com>
On 25/02/2025 14:19, Varada Pavani wrote:
> Use samsung CCF function which registers multiple clock providers using
> single function call samsung_cmu_register_clocks().
>
> Signed-off-by: Varada Pavani <v.pavani@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos4.c | 78 +++++++++++++++++--------------
> 1 file changed, 44 insertions(+), 34 deletions(-)
Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-05 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250225132431epcas5p148b0c62e36ea09c35473c8da7f312ece@epcas5p1.samsung.com>
2025-02-25 13:19 ` [PATCH v2 0/2] clk: samsung: Update PLL locktime and samsung function Varada Pavani
[not found] ` <CGME20250225132447epcas5p4576a3dac624edbd5edc0a047e008de05@epcas5p4.samsung.com>
2025-02-25 13:19 ` [PATCH v2 1/2] clk: samsung: Use samsung CCF common function Varada Pavani
2025-03-05 19:15 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20250225132507epcas5p455347acbd580b26ee807e467d3a6a05e@epcas5p4.samsung.com>
2025-02-25 13:19 ` [PATCH v2 2/2] clk: samsung: update PLL locktime for PLL142XX used on FSD platform Varada Pavani
2025-03-01 14:14 ` Krzysztof Kozlowski
2025-03-05 19:12 ` Krzysztof Kozlowski
2025-03-05 19:14 ` Krzysztof Kozlowski
2025-03-05 19:15 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cbd3df3-344f-4c4f-886d-f0bb99b824da@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=gost.dev@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pankaj.dubey@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=v.pavani@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®