From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Szilard Fabian <szfabian@bluemarch.art>,
Jonathan Woithe <jwoithe@just42.net>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency
Date: Thu, 29 Feb 2024 13:37:28 +0200 (EET) [thread overview]
Message-ID: <6cc402a3-0e6d-f784-b14b-09f4db60eaf2@linux.intel.com> (raw)
In-Reply-To: <20240228094010.2254245-1-arnd@kernel.org>
On Wed, 28 Feb 2024, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The dependency is required to avoid a link failure after support for
> battery hooks was added:
>
> ld.lld: error: undefined symbol: battery_hook_unregister
> >>> referenced by fujitsu-laptop.c
> >>> drivers/platform/x86/fujitsu-laptop.o:(acpi_fujitsu_laptop_remove) in archive vmlinux.a
>
> Fixes: 611d56d76dee ("platform/x86/fujitsu-laptop: Add battery charge control support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 6dbd40e2aeda..d9851b79bfe5 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -371,6 +371,7 @@ config FUJITSU_LAPTOP
> depends on INPUT
> depends on BACKLIGHT_CLASS_DEVICE
> depends on ACPI_VIDEO || ACPI_VIDEO = n
> + depends on ACPI_BATTERY
> select INPUT_SPARSEKMAP
> select NEW_LEDS
> select LEDS_CLASS
Thanks. We already fixed this in the originating commit (and now the
fixed version of the commit has also propaged to the for-next branch).
--
i.
prev parent reply other threads:[~2024-02-29 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 9:39 Arnd Bergmann
2024-02-29 11:37 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc402a3-0e6d-f784-b14b-09f4db60eaf2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jwoithe@just42.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=szfabian@bluemarch.art \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®