From: Chancel Liu <chancel.liu@oss.nxp.com>
To: Mark Brown <broonie@kernel.org>
Cc: shengjiu.wang@oss.nxp.com, shengjiu.wang@gmail.com,
Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_asrc_dma: fix error handling for DMA channel retrieval
Date: Mon, 9 Nov 2026 18:41:13 +0800 [thread overview]
Message-ID: <6cc41a88-b349-43a9-b90e-cf95183355c1@oss.nxp.com> (raw)
In-Reply-To: <7a9ae82c-838a-4543-91f6-e4f6397c4e91@sirena.org.uk>
On 11/8/2026 12:00 AM, Mark Brown wrote:
> On Fri, Nov 06, 2026 at 01:50:46PM +0800, Chancel Liu wrote:
>> On 10/28/2026 10:59 AM, shengjiu.wang@oss.nxp.com wrote:
>>> From: Shengjiu Wang <shengjiu.wang@nxp.com>
>>>
>>> The original check used `if (!tmp_chan)`, which only catches NULL pointers.
>>> However `asrc->get_dma_channel()` returns an error pointer. The NULL check
>>> will always succeed, so replace it with `IS_ERR(tmp_chan)` to correctly
>>> detect errors.
>>>
>>> Fixes: b4136c0d69ea ("ASoC: fsl_asrc: check the second front-end DMA channel")
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>>
>> Reviewed-by: Chancel Liu <chancel.liu@gmail.com>
>
> Note that if you send from an address other than the one you're using
> for your R-b it'll be ignored by the tooling.
Oh, I never knew that. Thanks for the reminder!
Regards,
Chancel Liu
next prev parent reply other threads:[~2026-11-09 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 2:59 shengjiu.wang
2026-11-06 5:50 ` Chancel Liu
2026-11-07 16:00 ` Mark Brown
2026-11-09 10:41 ` Chancel Liu [this message]
2026-11-07 16:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc41a88-b349-43a9-b90e-cf95183355c1@oss.nxp.com \
--to=chancel.liu@oss.nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@oss.nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®