From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Marco Elver <elver@google.com>,
peterz@infradead.org, dvyukov@google.com, glider@google.com,
andreyknvl@google.com, mark.rutland@arm.com, hpa@zytor.com
Cc: corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, kasan-dev@googlegroups.com
Subject: Re: [PATCH v4 1/3] lib/test_kasan: Add bitops tests
Date: Thu, 13 Jun 2019 15:50:06 +0300 [thread overview]
Message-ID: <6cc5e12d-1492-d9b7-3ea7-6381407439d7@virtuozzo.com> (raw)
In-Reply-To: <20190613123028.179447-2-elver@google.com>
On 6/13/19 3:30 PM, Marco Elver wrote:
> This adds bitops tests to the test_kasan module. In a follow-up patch,
> support for bitops instrumentation will be added.
>
> Signed-off-by: Marco Elver <elver@google.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> ---
Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> +static noinline void __init kasan_bitops(void)
> +{
> + /*
> + * Allocate 1 more byte, which causes kzalloc to round up to 16-bytes;
> + * this way we do not actually corrupt other memory, in case
> + * instrumentation is not working as intended.
This sound like working instrumentation somehow save us from corrupting memory. In fact it doesn't,
it only reports corruption.
> + */
> + long *bits = kzalloc(sizeof(*bits) + 1, GFP_KERNEL);
> + if (!bits)
> + return;
> +
next prev parent reply other threads:[~2019-06-13 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:30 [PATCH v4 0/3] Bitops instrumentation for KASAN Marco Elver
2019-06-13 12:30 ` [PATCH v4 1/3] lib/test_kasan: Add bitops tests Marco Elver
2019-06-13 12:50 ` Andrey Ryabinin [this message]
2019-06-13 13:00 ` Marco Elver
2019-06-13 12:30 ` [PATCH v4 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation Marco Elver
2019-06-13 12:30 ` [PATCH v4 3/3] asm-generic, x86: Add bitops instrumentation for KASAN Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc5e12d-1492-d9b7-3ea7-6381407439d7@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®