From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Clark <robdclark@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Sudeep Holla <sudeep.holla@arm.com>,
Vinod Koul <vkoul@kernel.org>, Xilin Wu <wuxilin123@gmail.com>,
Molly Sophia <mollysophia379@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2 2/6] arm64: dts: qcom: sdm845-db845c: correct SPI2 pins drive strength
Date: Mon, 10 Oct 2022 14:03:59 +0200 [thread overview]
Message-ID: <6cc7ef4b-8c11-96ad-76dd-77a4e2de3d2b@linaro.org> (raw)
In-Reply-To: <20221010114417.29859-2-krzysztof.kozlowski@linaro.org>
On 10/10/2022 13:44, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_spi2_default pin configuration uses alreaady the second method
> with a "pinmux" child, so configure drive-strength similarly in
> "pinconf". Otherwise the PIN drive strength would not be applied.
>
> Fixes: 8d23a0040475 ("arm64: dts: qcom: db845c: add Low speed expansion i2c and spi nodes")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Not tested on hardware.
>
> Changes since v1:
> 1. Put it under pinconf instead of pinmux, as suggested by Doug.
> ---
<snip>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2022-10-10 12:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 11:44 [PATCH v2 1/6] arm64: dts: qcom: sdm630: fix UART1 pin bias Krzysztof Kozlowski
2022-10-10 11:44 ` [PATCH v2 2/6] arm64: dts: qcom: sdm845-db845c: correct SPI2 pins drive strength Krzysztof Kozlowski
2022-10-10 12:03 ` Neil Armstrong [this message]
2022-10-12 21:42 ` Doug Anderson
2022-10-10 11:44 ` [PATCH v2 3/6] arm64: dts: qcom: sdm845-cheza: fix AP suspend pin bias Krzysztof Kozlowski
2022-10-10 11:44 ` [PATCH v2 4/6] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Krzysztof Kozlowski
2022-10-10 11:44 ` [PATCH v2 5/6] arm64: dts: qcom: sdm850-samsung-w737: " Krzysztof Kozlowski
2022-10-10 11:44 ` [PATCH v2 6/6] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name Krzysztof Kozlowski
2022-10-18 3:05 ` (subset) [PATCH v2 1/6] arm64: dts: qcom: sdm630: fix UART1 pin bias Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc7ef4b-8c11-96ad-76dd-77a4e2de3d2b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mollysophia379@gmail.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vkoul@kernel.org \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®