From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166CD1D9A54 for ; Tue, 27 Jan 2026 15:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527512; cv=none; b=a+tLOzQjq03Vt+h+R4uJtahSWrmdROOesfPAW8/b7n7xuOhHwxDqZQoshQizvLPn3AHzpQ+SvGOZygRhOLurhkA+Bj9mFkdCvIvJ+0l66Sv34iY8hfVAok0LQ+a/X2maOpvZ89yu2M5YjZVR5aZjz5XASnu9IXGPQiQwM4WmnxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527512; c=relaxed/simple; bh=paQiiS6NHEoR6vqZdHRoMAKcfDd3HY2Hy3tTNAWpuCs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kTqXvBrMe8XEqS9qsg3gNfuJgQcWYA8RZBgSJC3m4PFyLmuLVAmn3F74K3WPERtRNth/Pg1wAi5J/gR3VWrLSBcrgesfrsreCVNqDCILXxlnt5jn6NP8vnbOycKArzxhH3+a613x7TQQScUP1wKdMxlBupBjnCr0ycQP9nV0qLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=BqLE78BT; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="BqLE78BT" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R9vuY7028699; Tue, 27 Jan 2026 15:25:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=jjUmPV r/WSUtPgXb9s2w+yw4RSpSwVhiHkGNPQXsQgY=; b=BqLE78BTtmu009gHmhYHK8 fqgK5PBGQyRAKbFdp6/qnn/2DgsxIZDTy1Xd/6lOm3ORl2g6pcxzOFk7aGrYDIv/ nGPlnlf1V1jN80gXuVWme1g0MBLWol62+DgMYm8XfljEN/+vr6Sfkpp6P20wzNjm oXmtevsEK2Vw/jrOoE90Z2UsayFc4anmx5YwVCzfQss5o4yZX0RX6p9nNyoAmPHP j+/wJkqmbtqzwBuzUSt34pS1RjGtiD2xpHDA4OFdbkMrUqd/SbzOHPkuEqLMeJoN ziijvwBqDdbwuumwJGS/TSLYoKaQfNuR0AM0RgXOkdmtBCuP5NXG52faZpBd4h9w == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvkgmmme1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:25:05 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RDQUoo026384; Tue, 27 Jan 2026 15:25:04 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bw9wk93j6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:25:04 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFP49M31785638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:25:04 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24BC158056; Tue, 27 Jan 2026 15:25:04 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEABB58052; Tue, 27 Jan 2026 15:25:03 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:25:03 +0000 (GMT) Message-ID: <6ccd90d8-c5d1-468a-94c9-c264a55409ad@linux.ibm.com> Date: Tue, 27 Jan 2026 09:25:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/13] fsi: Make use of module_fsi_driver() To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <602437dc213cbe35ee75d0d0a4b4a2c28859e3f9.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <602437dc213cbe35ee75d0d0a4b4a2c28859e3f9.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Gr1PO01C c=1 sm=1 tr=0 ts=6978d8d1 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=tcme9c7lAAAA:8 a=EXRgp72BIlfbFlk4JBUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 a=cJsI3S3cdgERF2JXxJch:22 X-Proofpoint-GUID: VYoVAnF6xKypVlowm9rU2aZ4ftIDVeLB X-Proofpoint-ORIG-GUID: VYoVAnF6xKypVlowm9rU2aZ4ftIDVeLB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyNSBTYWx0ZWRfX8oIDluOkcMdo +hO7M6HWQAOpwkzRCdiyrBis/pKv+t6GwBRgnfsn6lj0/w8WDg14OjqELheVuKnRknINXfEuQfI kNXoq2H/4U4SdNFZtkNQmFDxEdYFPFUXLPATyiJ9OcHYyXiAkF+MsdS9o4KDDO9rIP6KW1G7JGd awaLYjDOFZVVw4XAqfTxczFr/9WicUhabsa1dM/r0V+O3CB4NP+Tk+RBMmMQIXKalphOzYbt6EV y2NKq2aQKSc2kUJyI11amTX607hCePr6/RDYjMqIUg2fT7rXCjuxDB10fgmBj80IwmcK9i+ghUh ArIdMAjOIxt8CjCMF6TrJy/T0jreMoA2JMvLfya7bEvz1Ni21Sj2fXZQXoUPApz3mAGQIlGoo9A h1InQYF5PV5KNVlsn0NUeuR7SMBQyGohbM45l7NiApn7U1qTeU4XzQFeAg8+nuEgnbL8Pp8z8te ndCpF5vJDzPAhjnca3w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270125 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > All other fsi drivers already use this helper to reduce boilerplate. > Catch up for the last two remaining ones. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/fsi-sbefifo.c | 13 +------------ > drivers/fsi/fsi-scom.c | 13 +------------ > 2 files changed, 2 insertions(+), 24 deletions(-) > > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c > index 0a98517f3959..5a08423d0c7e 100644 > --- a/drivers/fsi/fsi-sbefifo.c > +++ b/drivers/fsi/fsi-sbefifo.c > @@ -1139,18 +1139,7 @@ static struct fsi_driver sbefifo_drv = { > } > }; > > -static int sbefifo_init(void) > -{ > - return fsi_driver_register(&sbefifo_drv); > -} > - > -static void sbefifo_exit(void) > -{ > - fsi_driver_unregister(&sbefifo_drv); > -} > - > -module_init(sbefifo_init); > -module_exit(sbefifo_exit); > +module_fsi_driver(sbefifo_drv); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Brad Bishop "); > MODULE_AUTHOR("Eddie James "); > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > index 411ddc018cd8..f533106085ac 100644 > --- a/drivers/fsi/fsi-scom.c > +++ b/drivers/fsi/fsi-scom.c > @@ -613,17 +613,6 @@ static struct fsi_driver scom_drv = { > } > }; > > -static int scom_init(void) > -{ > - return fsi_driver_register(&scom_drv); > -} > - > -static void scom_exit(void) > -{ > - fsi_driver_unregister(&scom_drv); > -} > - > -module_init(scom_init); > -module_exit(scom_exit); > +module_fsi_driver(scom_drv); > MODULE_DESCRIPTION("SCOM FSI Client device driver"); > MODULE_LICENSE("GPL");