From: "Arnd Bergmann" <arnd@arndb.de>
To: charles.kearney@hpe.com, "Verdun, Jean-Marie" <verdun@hpe.com>,
"Hawkins, Nick" <nick.hawkins@hpe.com>,
"Rob Herring" <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] ARM: dts: hpe: BUG: Correct GXP register ranges
Date: Fri, 10 Nov 2023 21:33:21 +0100 [thread overview]
Message-ID: <6cce1756-db32-4486-96d0-320d08569fbf@app.fastmail.com> (raw)
In-Reply-To: <20231110194827.122045-1-charles.kearney@hpe.com>
On Fri, Nov 10, 2023, at 20:48, charles.kearney@hpe.com wrote:
> - ahb@c0000000 {
> + ahb@80000000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0xc0000000 0x30000000>;
> dma-ranges;
> + ranges = <0x00000000 0x80000000 0x20000000>,
> + <0x40000000 0xc0000000 0x3fff0000>;
>
> - vic0: interrupt-controller@eff0000 {
> + vic0: interrupt-controller@4eff0000 {
> compatible = "arm,pl192-vic";
> - reg = <0xeff0000 0x1000>;
> + reg = <0x4eff0000 0x1000>;
> interrupt-controller;
> #interrupt-cells = <1>;
> };
>
> - vic1: interrupt-controller@80f00000 {
> + vic1: interrupt-controller@f00000 {
> compatible = "arm,pl192-vic";
> - reg = <0x80f00000 0x1000>;
> + reg = <0xf00000 0x1000>;
> interrupt-controller;
> #interrupt-cells = <1>;
> };
>
> - uarta: serial@e0 {
> + uarta: serial@400000e0 {
Are these the actual addresses in the datasheet or
did you just make up a mapping?
If you have two separate address ranges, that would
typically indicate that there are two distinct ahb
instances that should be represented as separate
bus nodes. With the new mapping, it looks like all the
devices using vic0 are part of the same address range
as vic0, which also indicates that they might
be on one bus.
If this is a single ahb instance with multiple distinct
address ranges, I would expect that you need to adapt
the dma-ranges as well.
Arnd
prev parent reply other threads:[~2023-11-10 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 19:48 charles.kearney
2023-11-10 20:33 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cce1756-db32-4486-96d0-320d08569fbf@app.fastmail.com \
--to=arnd@arndb.de \
--cc=charles.kearney@hpe.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®