From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973181.qiye.163.com (mail-m1973181.qiye.163.com [220.197.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50645322B; Tue, 8 Apr 2025 03:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744082209; cv=none; b=Z2CSQPa1UPEryjtfAFTU58FmB+GvyhyhXXd7d5u/rdnR3EUk6fQqbia3f7X4dFHEqeEOtX9i/nRxUkAcL2KkyQhiYTMYaK7avPujZoD7JKkQjEPWnpwJNtw50Omz7EfDIQHenbhSLf/0EGXYRtHC9Y6oMes1z3xijEYtL9raAn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744082209; c=relaxed/simple; bh=+C/ir4MXLCFa4qRxQoVsWWbgVy0MyXuOwnSs1AcMeOg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=LwrfLSsoGLetV3m6DIcLL8F5io314z4pWJg7SszPlDn6TJBzvj5rDJBfKvfNQAezGWyUd49Zi5VCfzHcPLfqjbso1Dj4kZUt9ZQv9FbowSf6A6hJUkmSAT70pelUxJEZbX/W7DdamzyQKZF/0mcY2ZRCMLq1drTxCj0YSyU13Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=ZzFcx253; arc=none smtp.client-ip=220.197.31.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="ZzFcx253" Received: from [172.16.12.129] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 110100f9f; Tue, 8 Apr 2025 11:01:19 +0800 (GMT+08:00) Message-ID: <6ccfc126-b009-4ee9-0a2c-3e7faf512751@rock-chips.com> Date: Tue, 8 Apr 2025 11:01:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley , Finley Xiao , Frank Wang , Rob Herring , Liang Chen , Detlev Casanova , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Yifeng Zhao , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes To: Kever Yang , heiko@sntech.de References: <20250225102611.2096462-1-kever.yang@rock-chips.com> <20250225102611.2096462-2-kever.yang@rock-chips.com> From: Shawn Lin In-Reply-To: <20250225102611.2096462-2-kever.yang@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkwYTVYZSEtOGEpLGUxCGUlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a9613585a7e09cckunm110100f9f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OSo6OBw*TzJCNUJKKR4eLioX FzMaFElVSlVKTE9PS0NKSUNKSUNOVTMWGhIXVQgTGgwVVRcSFTsJFBgQVhgTEgsIVRgUFkVZV1kS C1lBWU5DVUlJVUxVSkpPWVdZCAFZQU1MQ0s3Bg++ DKIM-Signature:a=rsa-sha256; b=ZzFcx253Iawa95Ut/zueBk6AOjK/JxZoWLnmw0TH6KDZc8RlQ7YnUlOpTHMHsFffAR/USMj5zUBT2BYglrMvPvoLWOjH7W3Vymu+m1vLvUPHOxBaS5zm/hHV9ejb3E099jnZ3QdUWJospg6rNBs/UVdBG+6V1U/jJHt8Cwql21Y=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=SLSSxNg3dTpdPXjgZLIOhqnXXot5F10MyjFb2gUR874=; h=date:mime-version:subject:message-id:from; 在 2025/02/25 星期二 18:26, Kever Yang 写道: > rk3576 has two pcie controllers, both are pcie2x1 work with > naneng-combphy. > > Signed-off-by: Kever Yang > --- > One thing need to be mentioned, defconfig set: CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=m CONFIG_PHY_ROCKCHIP_PCIE=m So the phy is missing leads deferred probe pending. With setting CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y, pcie works fine, so Tested-by: Shawn Lin > Changes in v7: > - re-order the properties. > > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: > - Update the subject > > Changes in v2: > - Update clock and reset names and sequence to pass DTB check > > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 108 +++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > index 4dde954043ef..79e24b2c3c60 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > @@ -1127,6 +1127,114 @@ qos_npu_m1ro: qos@27f22100 { > reg = <0x0 0x27f22100 0x0 0x20>; > }; > > + pcie0: pcie@2a200000 { > + compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie"; > + reg = <0x0 0x22000000 0x0 0x00400000>, > + <0x0 0x2a200000 0x0 0x00010000>, > + <0x0 0x20000000 0x0 0x00100000>; > + reg-names = "dbi", "apb", "config"; > + bus-range = <0x0 0xf>; > + clocks = <&cru ACLK_PCIE0_MST>, <&cru ACLK_PCIE0_SLV>, > + <&cru ACLK_PCIE0_DBI>, <&cru PCLK_PCIE0>, > + <&cru CLK_PCIE0_AUX>; > + clock-names = "aclk_mst", "aclk_slv", > + "aclk_dbi", "pclk", > + "aux"; > + device_type = "pci"; > + interrupts = , > + , > + , > + , > + , > + ; > + interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi"; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &pcie0_intc 0>, > + <0 0 0 2 &pcie0_intc 1>, > + <0 0 0 3 &pcie0_intc 2>, > + <0 0 0 4 &pcie0_intc 3>; > + linux,pci-domain = <0>; > + max-link-speed = <2>; > + num-ib-windows = <8>; > + num-viewport = <8>; > + num-ob-windows = <2>; > + num-lanes = <1>; > + phys = <&combphy0_ps PHY_TYPE_PCIE>; > + phy-names = "pcie-phy"; > + power-domains = <&power RK3576_PD_PHP>; > + ranges = <0x01000000 0x0 0x20100000 0x0 0x20100000 0x0 0x00100000 > + 0x02000000 0x0 0x20200000 0x0 0x20200000 0x0 0x00e00000 > + 0x03000000 0x9 0x00000000 0x9 0x00000000 0x0 0x80000000>; > + resets = <&cru SRST_PCIE0_POWER_UP>, <&cru SRST_P_PCIE0>; > + reset-names = "pwr", "pipe"; > + #address-cells = <3>; > + #size-cells = <2>; > + status = "disabled"; > + > + pcie0_intc: legacy-interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + interrupt-parent = <&gic>; > + interrupts = ; > + }; > + }; > + > + pcie1: pcie@2a210000 { > + compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie"; > + reg = <0x0 0x22400000 0x0 0x00400000>, > + <0x0 0x2a210000 0x0 0x00010000>, > + <0x0 0x21000000 0x0 0x00100000>; > + reg-names = "dbi", "apb", "config"; > + bus-range = <0x20 0x2f>; > + clocks = <&cru ACLK_PCIE1_MST>, <&cru ACLK_PCIE1_SLV>, > + <&cru ACLK_PCIE1_DBI>, <&cru PCLK_PCIE1>, > + <&cru CLK_PCIE1_AUX>; > + clock-names = "aclk_mst", "aclk_slv", > + "aclk_dbi", "pclk", > + "aux"; > + device_type = "pci"; > + interrupts = , > + , > + , > + , > + , > + ; > + interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi"; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &pcie1_intc 0>, > + <0 0 0 2 &pcie1_intc 1>, > + <0 0 0 3 &pcie1_intc 2>, > + <0 0 0 4 &pcie1_intc 3>; > + linux,pci-domain = <0>; > + max-link-speed = <2>; > + num-ib-windows = <8>; > + num-viewport = <8>; > + num-ob-windows = <2>; > + num-lanes = <1>; > + phys = <&combphy1_psu PHY_TYPE_PCIE>; > + phy-names = "pcie-phy"; > + power-domains = <&power RK3576_PD_SUBPHP>; > + ranges = <0x01000000 0x0 0x21100000 0x0 0x21100000 0x0 0x00100000 > + 0x02000000 0x0 0x21200000 0x0 0x21200000 0x0 0x00e00000 > + 0x03000000 0x9 0x80000000 0x9 0x80000000 0x0 0x80000000>; > + resets = <&cru SRST_PCIE1_POWER_UP>, <&cru SRST_P_PCIE1>; > + reset-names = "pwr", "pipe"; > + #address-cells = <3>; > + #size-cells = <2>; > + status = "disabled"; > + > + pcie1_intc: legacy-interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + interrupt-parent = <&gic>; > + interrupts = ; > + }; > + }; > + > gmac0: ethernet@2a220000 { > compatible = "rockchip,rk3576-gmac", "snps,dwmac-4.20a"; > reg = <0x0 0x2a220000 0x0 0x10000>;