From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964858AbcKKTnp (ORCPT ); Fri, 11 Nov 2016 14:43:45 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:53379 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932697AbcKKTno (ORCPT ); Fri, 11 Nov 2016 14:43:44 -0500 Subject: Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload To: Guenter Roeck References: <1476458631-29685-1-git-send-email-javier@osg.samsung.com> <20161014165548.GA21425@roeck-us.net> Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck From: Javier Martinez Canillas Message-ID: <6cd2fbb2-02b3-96b7-625e-e5701595b105@osg.samsung.com> Date: Fri, 11 Nov 2016 16:43:37 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161014165548.GA21425@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guenter, On 10/14/2016 01:55 PM, Guenter Roeck wrote: > On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote: >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >> $ >> >> After this patch: >> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >> alias: of:N*T*Cbrcm,bcm7038-wdtC* >> alias: of:N*T*Cbrcm,bcm7038-wdt >> >> Signed-off-by: Javier Martinez Canillas > > Reviewed-by: Guenter Roeck > Are you going to pick this (and patch 2/2)? I'm asking because you provided your r-b tag but the patch was never merged, so I wonder who should I ping about it. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America