From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdFAUkT (ORCPT ); Thu, 1 Jun 2017 16:40:19 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36499 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdFAUkQ (ORCPT ); Thu, 1 Jun 2017 16:40:16 -0400 Subject: Re: [PATCH v2] um: Allow building and running on older hosts To: Richard Weinberger , Thomas Meyer , elicooper@gmx.com Cc: linux-kernel@vger.kernel.org, Jeff Dike , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:USER-MODE LINUX (UML)" , "open list:USER-MODE LINUX (UML)" References: <20170525183627.9375-1-f.fainelli@gmail.com> <82371937-3efc-06e7-8394-2acbb8d38d3a@gmail.com> <39e78e3c-553a-a8a6-ffc4-9e6c0098b78c@nod.at> From: Florian Fainelli Message-ID: <6cda703d-f128-12c7-1437-7f73ae46adca@gmail.com> Date: Thu, 1 Jun 2017 13:40:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <39e78e3c-553a-a8a6-ffc4-9e6c0098b78c@nod.at> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2017 03:34 PM, Richard Weinberger wrote: > Thomas, Florian, > > Am 26.05.2017 um 00:28 schrieb Florian Fainelli: >> On 05/25/2017 12:51 PM, Thomas Meyer wrote: >>> >>>> Am 25.05.2017 um 20:36 schrieb Florian Fainelli : >>>> >>>> Commit a78ff1112263 ("um: add extended processor state save/restore >>>> support") and b6024b21fec8 ("um: extend fpstate to _xstate to support >>>> YMM registers") forced the use of the x86 FP _xstate and >>>> PTRACE_GETREGSET/SETREGSET. On older hosts, we would neither be able to >>>> build UML nor run it anymore with these two commits applied because we >>>> don't have definitions for struct _xstate nor these two ptrace requests. >>> >>> Btw. what soy you mean with older host? I need to revert two commits to make an UML kernel work again on a Fedora 25 installation. >> >> This is centos 6.9, so kernel 2.6.32 and glibc 2.12, this neither has >> xstate nor PTRACE_GETREGSET/SETREGSET, hence this patch. > > Commits a78ff1112263 and b6024b21fec8 are broken. > You see two different issues. > Eli, please have a look too. Eli, can we get an answer here? And Thomas what's that problem that Richard is referring to? -- Florian