From: Logan Gunthorpe <logang@deltatee.com>
To: Arnd Bergmann <arnd@arndb.de>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>
Cc: Stephen Bates <sbates@raithlin.com>,
Colin Ian King <colin.king@canonical.com>,
Doug Meyer <dmeyer@gigaio.com>,
Kelvin Cao <kelvin.cao@microsemi.com>,
linux-pci@vger.kernel.org, linux-ntb@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntb_hw_switchtec: fix logic error
Date: Wed, 6 Dec 2017 10:37:06 -0700 [thread overview]
Message-ID: <6cdab766-60a2-0ef9-5495-f842acde8604@deltatee.com> (raw)
In-Reply-To: <20171206141923.817850-1-arnd@arndb.de>
Hey,
Thanks, nice catch.
On 06/12/17 07:19 AM, Arnd Bergmann wrote:
> Newer gcc (version 7 and 8 presumably) warn about a statement mixing
> the << operator with logical and:
>
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev':
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:24: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
>
> My interpretation here is that the author must have intended a bitmask
> rather than a comparison, so I'm changing the '&&' to '&', which makes
> a lot more sense in the context.
>
> Fixes: 1b249475275d ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Logan
prev parent reply other threads:[~2017-12-06 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 14:19 Arnd Bergmann
2017-12-06 17:37 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdab766-60a2-0ef9-5495-f842acde8604@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=dave.jiang@intel.com \
--cc=dmeyer@gigaio.com \
--cc=jdmason@kudzu.us \
--cc=kelvin.cao@microsemi.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®