From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D559442377D for ; Wed, 5 Aug 2026 11:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928649; cv=none; b=IYx6cBDQgziCzG1k1pPdj7auhTZf683/lNEJEtI1YRP41eajeNyuEV1L78/VYnPWFu6DbZ2UZ9QyO7s7uysfQy8flnEnvvE/iqe8vOlNKV21S99HTc33V6B/IJSJDMCOx+B8ityx3Frivi3/suWD4LEQkD6OV3O3JZAZr7mZ6Ss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928649; c=relaxed/simple; bh=WxPtIeE6LPh4w/Kr0BfcrUAaPr2TqymLknXLjMK4FFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H2lTd8mNos0epXgG+/CBJU6yhicrVsSIqhLmL3DzNl54uFyt0lvHzc0qhjzkTQOwdB3IwtGBDh+l36J/9Nrh4lkXHDllaLG1QKQHRe0va9NnLQ++cDPTVIlxf0MyzVUEX0NwTxICdRkFdggnoyPx/QUp9XaBOTmYJVoKNYvwN4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PCTCTYR0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gp6iTANr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PCTCTYR0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gp6iTANr" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6758dBQJ2128931 for ; Wed, 5 Aug 2026 11:17:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zz5YDsnH4EYX0ARoOKNjKE7qWp0mFP8PTuIplLeGj6w=; b=PCTCTYR0gpIIVkjG YiCetGZYW9IEKiKCoJdOsSLoXMDpAb8n9T6A47TlYTMpm3E4fo6WNrZuRvnmsmoq NM4Oz5xifPMvXvKrk9f3mdt/9Jt9pmYPOhKSOc5+s+6vG8TAFlioC78jqu0I3Atc PF3wMSGVoR/QitRCgcWamiyK75AC5L5hfkctg684exdkBomorhn3uNmYmOcIBQ3I sSlsYWB5q8+ADYecQ2N/oZCz0eYY6eaValvrWB6HDydKOdESg6vgIQavOBILqoPu WXhE8BiNlXDCgTi9diMLWWByPCUkx8uNo3CMCs8VB39uiSqVdaU/2hboeejuOwyC XVEaPg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fv1qg8pam-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Aug 2026 11:17:26 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cf6acd760cso10914145ad.3 for ; Wed, 05 Aug 2026 04:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785928646; x=1786533446; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Zz5YDsnH4EYX0ARoOKNjKE7qWp0mFP8PTuIplLeGj6w=; b=gp6iTANr71lEMUzcN4CAABpwVl4iwzfZzfNdJJBSCt2rTDimiYCUMzhiZjbL9OATMw kNaQd6yjvq1QzNJMdz+W0R0aNlgYeMo4dfUFvX1gntQztHU4wKbtnjRIJ8A4A7Pt05Os SQBoqcHSrEwQoXGw8rW25wxeEGnr9vNzCdN2GNAHhwjH1l/I9gh8C91baGcnLLgcQ0Ei UnFmQbY4gRbiawnYWIws5lgIDOhAyHiWG2HM/WsUFawQ1N3sZ3AaeSplOaQcZfrJdLrU /ExBo6ZgZ8MvMQFSqA98VfKtsMeZbFuCKCb/koux4xEUo+E/DiBmwrAB5e9hZK278xRd hDVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785928646; x=1786533446; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zz5YDsnH4EYX0ARoOKNjKE7qWp0mFP8PTuIplLeGj6w=; b=rYI8J9npTlz/ODBFwfryEMhRVaJtL1PB44aVXNxhJvR0zYEL9UD+zPSHOws+ADiQPl ROLRxacTMflUQ9NWKxbJOZkAR0zJYFgSA2pvRTtIxfsv/aP6RsHtUyGsRql87uKMsVZf NO2r7Rx/2VOkXo3alZ8lenpqTAvHr2+D13nq1qvNL8+zAgTy9CkQcLqF8sfAf+R3pdE9 jDbieepDcCp59hzBBBIiwMauxEbmEGh2dhcU/ZkaEwE4xlSd4Q3o1XpxgpvBmPmkq+e4 AAJ/rN05kDWrYvle+E6VEYWZvALJ9PXQckkmL3q0sqosthFPpJI4fKftgeIeKwcd2sXO nUyA== X-Forwarded-Encrypted: i=1; AHgh+RrSc3RThXZI6wnnTQHLEMCH1jlcyLjNKt4xsIaZMs17et0xtKTPodEpL3sQjWK7AKKcCgXlvWoCWmwhclc=@vger.kernel.org X-Gm-Message-State: AOJu0YxTwqHKD/WrAfHUpl02QRF9XsSHRGqaTM9APIV3HhF9nZOFOV6r iQCqp//StM9myLlsgK8YPErMwlTngM4wKeOlrEwb/uCvBQKWL9HjUqc4vrTZVZ1VfFOQb1XkdBi Y/4Xqzdcqi4PQSPMV13G2QzqPG7oTDSjSNRAWaN57W2RDXUsuG6FHVW8by7S6o723qcI= X-Gm-Gg: AR+sD10fuRdqqF9I9fYDewZsBtz6n2a66OwOxLyqbUhdcXp/cxLVafs6KA8uaQfG1ee Mh/Htn38wILugP6yqQFbU0ZQRmu3pEwRpl/rqgR1aqsPHcM4j/HrY2DenHAc3P/+NwidlxNu/6a zPgVstUkVlliPbhaHFh9Vg55nqPBEnDdNLnqiQg3IH8sGMf/QnpfpwGIUAxxGgP0vNge6XD4mrd S7WuYyPBJ6mTxU39WI0h665RZKgmaCIURyYcjVVXKz7nImNEBGdeeNQeHNUfyDqrnxQqMcI70MF KURnnnNmRzmRy7QHquztVNBGCfPinTuNHLxwL7WgWUMOkuFuF5f/+xB4drmZ31lJB5Vn0ovr5kG H1ihLoyWu3K8DWZQvVry3IUUGJ/xOwE2pbx3ZNVtZ X-Received: by 2002:a05:6a20:43a9:b0:3c3:7e9c:e292 with SMTP id adf61e73a8af0-3cb85f49477mr7067174637.25.1785928646395; Wed, 05 Aug 2026 04:17:26 -0700 (PDT) X-Received: by 2002:a05:6a20:43a9:b0:3c3:7e9c:e292 with SMTP id adf61e73a8af0-3cb85f49477mr7067122637.25.1785928645982; Wed, 05 Aug 2026 04:17:25 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fca6576b7sm12059674c88.7.2026.08.05.04.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 04:17:25 -0700 (PDT) Message-ID: <6cded053-d8d1-40c4-b3a5-753cd5482b6b@oss.qualcomm.com> Date: Wed, 5 Aug 2026 16:47:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats() To: Jeff Johnson , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260728-ath12k_wmi_process_tpc_stats-skb-check-v1-1-01b7d09be20d@oss.qualcomm.com> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260728-ath12k_wmi_process_tpc_stats-skb-check-v1-1-01b7d09be20d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I+hVgtgg c=1 sm=1 tr=0 ts=6a731bc6 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=xk6P7Knj3mn-WFlMDu8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: x5qe-4laDNpl-yw7wIzjqF5IusYplPou X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDA5MCBTYWx0ZWRfX7xOjfuCZTh3j L5vPjWw4hHiQVnDpstbYTzNy7EB/2gf+/oufKkwBTkuGnk7DsAmZbChuNca32/ub507ra/EZ/FT TBe+7BQ8BrK7JmajhzIfeGZLAksjUOUH//urvWv+SlfsQ8shelbRKeIYnaebhEKUXUVSDXehE5D hotl6TsxGrIoq31MaG8Z4PAPzpGSNI1BeNTm36A7hhFTurTokT/VcZ7K14ThxXRBLcerYBN7Y+M nrYrtO6LCwgTMXf5RfXyXRYy7jjXf8IMg6b7D3m+bg79lj0LurWmWM2o0QFv+D1O6ibMrUnBtuv k8i5YilRwYmReHyKBi1y2O/Wd8y5HmrPV1r5creeAYIBmBkGvpaDrx/zMgv3rM+vKQYoFYt29gH iZ6IuG7WvZVadGNZAvojGGtWXGJsyqlHCejHd9QwtorFYMCP7TdS6ApDwnrzg5uT03byW077Lsi g0LdmiUNp2ov130/2WQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDA5MCBTYWx0ZWRfX3WTO53DO7hP3 d+MFtzp87uGk/CBt0Kjij4eBPyIU17NuhFg+2Cm5WgV7/ur+qMaT22MMOCD5EyintLMqlfd/Q2y wKmIZgD4ckCp1yBh+8w9/Z3+VUJoMHA= X-Proofpoint-GUID: x5qe-4laDNpl-yw7wIzjqF5IusYplPou X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_03,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050090 On 7/29/2026 6:45 AM, Jeff Johnson wrote: > Currently, ath12k_wmi_process_tpc_stats() has a !skb->data check. This > check is pointless since skb->data is accessed by ath12k_wmi_op_rx() in > order to dispatch the message to this function, therefore it is always > non-NULL. > > Remove the pointless check and its associated warning message. > > Compile tested only. > > Assisted-by: Claude:claude-sonnet-4-6 > Signed-off-by: Jeff Johnson Reviewed-by: Rameshkumar Sundaram