From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F8F0C433EF for ; Mon, 25 Apr 2022 14:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238442AbiDYOOa (ORCPT ); Mon, 25 Apr 2022 10:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbiDYOO2 (ORCPT ); Mon, 25 Apr 2022 10:14:28 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7E62B2 for ; Mon, 25 Apr 2022 07:11:24 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id k23so29904199ejd.3 for ; Mon, 25 Apr 2022 07:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hbNq8UvBnN7+r4Fd2yWxDnQ9hsYwZngmugC9ubWuoPM=; b=tM68+Ax+c59zekowsoZDmmi4d+26x0+qsaJ+zYByavNorx6Uq9ihBhPkrjYGueEand YbXMfFOq9veOveoLIodGDVBpDL1InoOVXLlB8n5GOcTVlN9jC6FG1YQZh2/AsoDVpHhU LOvw3okgzu+aa3brpJxC5a0sT1LJNVySGwT9X+9k5Y1Le8GmmHJffJzjJGI+71L0fUKp 30LTUUICVyXh6EQIQCXxjCo7jmuq9Ih2n0+QDYhTQnxbyCLpwLvoi2qo6RZKN+pw622R ecGpGQTPbtkRYZ5tEOZDOKQeO7pDs+IsKLr9KoUveEgJOmQ2iFaN+/l1etXZPfS874bu zGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hbNq8UvBnN7+r4Fd2yWxDnQ9hsYwZngmugC9ubWuoPM=; b=HJuA1PSPcXIp2Gv5RALBVIY1qrBRzD0nhay52nAVjG1h3VaLM5PFnWlc9x1pc4GwH6 OIijVWlrsMuhrGl+0iqJQd8NoYghKODK86gzbxfMV2HgaMlRY+hYDJCBGLMp90EvCND5 +3I09iy6pzQlbVoYoYpsY/oq4DAmBVXEHCPKjv15vPMIL6q4wXeLLKUqIYgwZp/XfMwp p/6RAxtIRSelVS22YBM0Z6jMs3eu0+KUH8ctoy3AJOVz1L+QhLRIHnK3AjFSB/MS6S5Y 0dSdmgH0G4LH+qdPe1WfFziruGPTDIzEDN1dHd4Abf931ed8tBpt1QMmpdN1R4ETk1pB nVFA== X-Gm-Message-State: AOAM5335wNU0Z8LZfD5GCawH68SJdismOAgUhjeijcYTrmmVLcZGmBIu E3RfglGuCy4Y1nHMt8ypl1sq9A== X-Google-Smtp-Source: ABdhPJxbhn3boE1o3X/8j8VbZQ/AXjtkDwzYBO0vBbDatkzQ9OM04+IR/v3GrPVceJO4HphUCbP7IQ== X-Received: by 2002:a17:907:6d08:b0:6f3:9c6a:d82f with SMTP id sa8-20020a1709076d0800b006f39c6ad82fmr3326924ejc.632.1650895883017; Mon, 25 Apr 2022 07:11:23 -0700 (PDT) Received: from [192.168.0.243] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id f1-20020a056402194100b00416b174987asm4775820edz.35.2022.04.25.07.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 07:11:22 -0700 (PDT) Message-ID: <6ce4f8a6-42c0-2f49-bd19-744d8cca716b@linaro.org> Date: Mon, 25 Apr 2022 16:11:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 Content-Language: en-US To: David Heidelberg , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Jassi Brar , Rob Herring , Krzysztof Kozlowski Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220425134717.55418-1-david@ixit.cz> <6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org> <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz> From: Krzysztof Kozlowski In-Reply-To: <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2022 16:05, David Heidelberg wrote: > On 25/04/2022 15:51, Krzysztof Kozlowski wrote: >> On 25/04/2022 15:47, David Heidelberg wrote: >>> Adds forgotten compatible and update SPDX header. >> You need to explain what is this "forgotten compatible". It's to vague. > Forgotten by someone who implemented it in driver. Hope that clarify it > for you and possibly other readers. Btw. qcom,*sm8450* compatibles are > widely used and fact that `make dtbs_check` noticed it missing here > isn't suprising.. This has to be in the commit msg, that you document compatibles already being used. "forgotten" does not explain that. >> >> The SPDX update lacks answer to "why". There is no reason to do it, so >> please explain why it is needed. > > Please read https://spdx.org/licenses/GPL-2.0.html (red colored text). The kernel lists it as valid SPDX and we did not deprecate it. For the kernel it is still considered valid. Feel free to propose otherwise but then you need to explain it in commit msg and update LICENSES/preferred/GPL-2.0. > > I personally encountered situation, where usage GPL license without > specific `-only` or `-or-later` caused unnecessary confusion and > uncertainty. Could be, I am not arguing with it. Yet kernel explicitly makes it a valid SPDX. Best regards, Krzysztof