From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F52EC19F2B for ; Mon, 1 Aug 2022 16:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233036AbiHAQRQ (ORCPT ); Mon, 1 Aug 2022 12:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232936AbiHAQRP (ORCPT ); Mon, 1 Aug 2022 12:17:15 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B41A73C150; Mon, 1 Aug 2022 09:17:11 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id CF75E32003AC; Mon, 1 Aug 2022 12:17:07 -0400 (EDT) Received: from imap42 ([10.202.2.92]) by compute2.internal (MEProxy); Mon, 01 Aug 2022 12:17:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1659370627; x=1659457027; bh=jSlZW82kJO trbsQe+JWb98zS2xjRzoI5vbOs5++NnLQ=; b=j+GWpCvsQyFaFkCglcB0vStu9k LNvemfQuROlI50kri4OODR1wwspPqN0P9b/KZ6Mi4pA3nb9vTv/a2XpeCnPz8s1Q ZyrOOMAj1vCo3mv7VHRvIm3+ndYLyuqUi6P6Hoeh749xVq0VCMfqQRMB03Y7Q2mp 5Jk7DVRA2I8TGr11UbdyujuBpZ67/R9dtg3NVwQFAcadZlVFAiMi+o1T/TOkukJf 60TrbGvISdZiTg+nvlq+ipJfVYOT86qZ5hs4KbneZ/YlFRqDQp57lB+PJFFtlXAJ vsfTkDBeRy3Vpi7UUifih3F/Kin4YzkHt/HLZ4FGJvfLgRBKM1DT5azrt90w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1659370627; x=1659457027; bh=jSlZW82kJOtrbsQe+JWb98zS2xjR zoI5vbOs5++NnLQ=; b=UFLGOg8bmfKGjg6eBmzPiEALlv2ne6zwLHkf6CAKKPTe q+WBVhjtEeFcP+knkt4R1KvIhFMF887xyT/yv3L0FHCEM959bUQZJbhwBnh8hA8c vGyD20iqFFbli43+jXAngETlBE1fan3wBzYcPJ9TL5mgpCn8TUYtiu1pInOAJaF1 DXaMg0F8ahp0KFnHzCkGxLEBtyldkcMT81Bm00Z9cfJWsyzQURK9OfcQRSI+1fxi NyaxhdYZA9kN4XrAgRW30DmQHbzAreSCUoVWEHe6LTG8QUBx6pfQLfeh5jagFNAp /LrCuCh8MPQRpRRiE+JuSYdzbFEapvcma+go5D1UlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvfedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpefofgggkfgjfhffhffvvefutgesthdtredt reertdenucfhrhhomhepfdffrghnihgvlhcuighufdcuoegugihusegugihuuhhurdighi iiqeenucggtffrrghtthgvrhhnpedtudehudfhveduieeikeejudeljeffuddtieffieel jedtudehhfekheehuedvkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegugihusegugihuuhhurdighiii X-ME-Proxy: Feedback-ID: i6a694271:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id EBBA2BC0075; Mon, 1 Aug 2022 12:17:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-758-ge0d20a54e1-fm-20220729.001-ge0d20a54 Mime-Version: 1.0 Message-Id: <6ce70dc2-7c4a-4048-aa45-9954082c0f29@www.fastmail.com> In-Reply-To: References: Date: Mon, 01 Aug 2022 10:16:46 -0600 From: "Daniel Xu" To: "Kumar Kartikeya Dwivedi" Cc: "bpf@vger.kernel.org" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add connmark read/write test Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kumar, On Mon, Aug 1, 2022, at 8:51 AM, Kumar Kartikeya Dwivedi wrote: > On Sat, 30 Jul 2022 at 21:40, Daniel Xu wrote: >> >> Test that the prog can read/write to/from the connection mark. This >> test is nice because it ensures progs can interact with netfilter >> subsystem correctly. >> > > Commit message is a bit misleading, where are you writing to ct->mark? :) > The cover letter also mentions "reading and writing from nf_conn". Do > you have patches whitelisting nf_conn::mark for writes? > If not, drop the writing related bits from the commit log. The rest > looks ok to me. Ah good catch, thanks. I've neglected to actually test writing to the mark. I'll follow up with another patch to enable writing to mark and testing it. And in meantime let's just change the commit msg on this patchset. I'm in the middle of a move right now so I probably can't respin the patch for a few more days. Feel free to edit the commit msgs. Or I'll send it again when I set my computer up. [...] Thanks, Daniel