mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Bruno Goncalves <bgoncalv@redhat.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP: 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu)
Date: Fri, 14 Jul 2023 14:47:24 -0700	[thread overview]
Message-ID: <6ce7c4d8-3320-7712-a562-a43224c2602b@linux.intel.com> (raw)
In-Reply-To: <20230714211109.GC3275140@hirez.programming.kicks-ass.net>

On 7/14/2023 2:11 PM, Peter Zijlstra wrote:
> On Tue, Jul 11, 2023 at 11:39:53AM -0700, Arjan van de Ven wrote:
>> On
>>> I think you mean "revert"?
>>>
>>> That can be done, but maybe it can be fixed instead?
>>
>> this specific issue I will fix shortly (together with the RDMSR thing)
> 
> I still don't know why this needs to be in intel_idle.

we can do a seperate idle driver; it'll still be x86 specific (since idle really is arch specific)...
and then the umwait parts of this will be Intel specific.. as well any future idle methods ..
and I'm not sure the AMD folks would even want it used .... at which point it ends up Intel
specific fully and we now have 2 Intel idle drivers.
I don't see how that makes sense.




  reply	other threads:[~2023-07-14 21:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11  9:11 Bruno Goncalves
2023-07-11 11:24 ` Peter Zijlstra
2023-07-11 12:25   ` Bruno Goncalves
2023-07-11 12:55     ` Peter Zijlstra
2023-07-11 13:15       ` Peter Zijlstra
2023-07-11 13:25       ` Peter Zijlstra
2023-07-11 18:37         ` Wysocki, Rafael J
2023-07-11 18:39           ` Arjan van de Ven
2023-07-14 21:11             ` Peter Zijlstra
2023-07-14 21:47               ` Arjan van de Ven [this message]
2023-07-14 22:02                 ` Peter Zijlstra
2023-07-14 21:10           ` Peter Zijlstra
2023-07-14 21:45             ` Arjan van de Ven
2023-07-14 21:55               ` Peter Zijlstra
2023-07-14 22:28               ` Peter Zijlstra
2023-07-11 14:26       ` Arjan van de Ven
2023-07-11 15:32         ` Peter Zijlstra
2023-07-11 14:22 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ce7c4d8-3320-7712-a562-a43224c2602b@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=bgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®