From: matt mooney <mfm@muteddisk.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RESEND PATCH 19/27] memstick: change to new flag variable
Date: Fri, 14 Jan 2011 06:12:42 -0800 [thread overview]
Message-ID: <6ce7d048ea0df01bc3e7e186a3a38d9c59126f09.1295006565.git.mfm@muteddisk.com> (raw)
In-Reply-To: <cover.1295006561.git.mfm@muteddisk.com>
The EXTRA_CFLAGS assignment in memstick/Makefile was not accomplishing
anything because this flag only has effect on sources at the same level
as the makefile (i.e., per directory). Since both core/ and host/ rely
on MEMSTICK_DEBUG, the subdir-ccflags-y variant seems to be the
appropriate choice.
Signed-off-by: matt mooney <mfm@muteddisk.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
---
drivers/memstick/Makefile | 4 +---
drivers/memstick/core/Makefile | 4 ----
drivers/memstick/host/Makefile | 4 ----
3 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/drivers/memstick/Makefile b/drivers/memstick/Makefile
index dc160fb..9862359 100644
--- a/drivers/memstick/Makefile
+++ b/drivers/memstick/Makefile
@@ -2,9 +2,7 @@
# Makefile for the kernel MemoryStick device drivers.
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
+subdir-ccflags-$(CONFIG_MEMSTICK_DEBUG) := -DDEBUG
obj-$(CONFIG_MEMSTICK) += core/
obj-$(CONFIG_MEMSTICK) += host/
diff --git a/drivers/memstick/core/Makefile b/drivers/memstick/core/Makefile
index 8b2b529..ecd0299 100644
--- a/drivers/memstick/core/Makefile
+++ b/drivers/memstick/core/Makefile
@@ -2,10 +2,6 @@
# Makefile for the kernel MemoryStick core.
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
-
obj-$(CONFIG_MEMSTICK) += memstick.o
obj-$(CONFIG_MSPRO_BLOCK) += mspro_block.o
diff --git a/drivers/memstick/host/Makefile b/drivers/memstick/host/Makefile
index 12530e4..a1815e9 100644
--- a/drivers/memstick/host/Makefile
+++ b/drivers/memstick/host/Makefile
@@ -2,9 +2,5 @@
# Makefile for MemoryStick host controller drivers
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
-
obj-$(CONFIG_MEMSTICK_TIFM_MS) += tifm_ms.o
obj-$(CONFIG_MEMSTICK_JMICRON_38X) += jmb38x_ms.o
--
1.7.3.4
next prev parent reply other threads:[~2011-01-14 14:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 14:12 [RESEND PATCH 00/27] update makefiles to use the newer flag variables matt mooney
2011-01-14 14:12 ` [RESEND PATCH 01/27] kernel: change to new flag variable matt mooney
2011-01-14 14:12 ` [RESEND PATCH 02/27] alpha: change to new flag variables matt mooney
2011-01-14 14:12 ` [RESEND PATCH 03/27] arm: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 04/27] h8300: change to new flag variable matt mooney
2011-01-14 14:12 ` [RESEND PATCH 05/27] ia64: change to new flag variables matt mooney
2011-01-14 14:12 ` [RESEND PATCH 06/27] m68k: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 07/27] microblaze: change to new flag variable matt mooney
2011-01-14 14:12 ` [RESEND PATCH 08/27] mips: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 09/27] s390: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 10/27] um: change to new flag variables matt mooney
2011-01-14 14:12 ` [RESEND PATCH 11/27] xtensa: change to new flag variable matt mooney
2011-01-14 14:12 ` [RESEND PATCH 12/27] fs: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 13/27] char: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 14/27] dma: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 15/27] hwmon: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 16/27] ide: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 17/27] ieee802154: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 18/27] isdn: " matt mooney
2011-01-14 14:12 ` matt mooney [this message]
2011-01-14 14:12 ` [RESEND PATCH 20/27] message: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 21/27] misc: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 22/27] net: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 23/27] pps: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 24/27] rapidio: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 25/27] rtc: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 26/27] scsi: " matt mooney
2011-01-14 14:12 ` [RESEND PATCH 27/27] video: " matt mooney
2011-03-17 13:15 ` [RESEND PATCH 00/27] update makefiles to use the newer flag variables Michal Marek
2011-03-17 13:19 ` Geert Uytterhoeven
2011-03-17 13:31 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce7d048ea0df01bc3e7e186a3a38d9c59126f09.1295006565.git.mfm@muteddisk.com \
--to=mfm@muteddisk.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®