mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nds32: add support for TIF_NOTIFY_SIGNAL
Date: Thu, 5 Nov 2020 09:18:25 -0700	[thread overview]
Message-ID: <6cea6b7c-6372-002d-f158-57f85e72668e@kernel.dk> (raw)
In-Reply-To: <4b195c6d-405d-cad8-f036-1bfc5876d528@kernel.dk>

Gentle nudge on this one.

On 10/29/20 10:17 AM, Jens Axboe wrote:
> Wire up TIF_NOTIFY_SIGNAL handling for nds32.
> 
> Cc: Nick Hu <nickhu@andestech.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
> 
> 5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting
> for details:
> 
> https://lore.kernel.org/io-uring/20201026203230.386348-1-axboe@kernel.dk/
> 
> As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs,
> as that will enable a set of cleanups once all of them support it. I'm
> happy carrying this patch if need be, or it can be funelled through the
> arch tree. Let me know.
> 
>  arch/nds32/include/asm/thread_info.h | 2 ++
>  arch/nds32/kernel/ex-exit.S          | 2 +-
>  arch/nds32/kernel/signal.c           | 2 +-
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/nds32/include/asm/thread_info.h b/arch/nds32/include/asm/thread_info.h
> index c135111ec44e..d3967ad184f0 100644
> --- a/arch/nds32/include/asm/thread_info.h
> +++ b/arch/nds32/include/asm/thread_info.h
> @@ -48,6 +48,7 @@ struct thread_info {
>  #define TIF_NEED_RESCHED	2
>  #define TIF_SINGLESTEP		3
>  #define TIF_NOTIFY_RESUME	4	/* callback before returning to user */
> +#define TIF_NOTIFY_SIGNAL	5	/* signal notifications exist */
>  #define TIF_SYSCALL_TRACE	8
>  #define TIF_POLLING_NRFLAG	17
>  #define TIF_MEMDIE		18
> @@ -57,6 +58,7 @@ struct thread_info {
>  #define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
>  #define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
>  #define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
> +#define _TIF_NOTIFY_SIGNAL	(1 << TIF_NOTIFY_SIGNAL)
>  #define _TIF_SINGLESTEP		(1 << TIF_SINGLESTEP)
>  #define _TIF_SYSCALL_TRACE	(1 << TIF_SYSCALL_TRACE)
>  #define _TIF_POLLING_NRFLAG	(1 << TIF_POLLING_NRFLAG)
> diff --git a/arch/nds32/kernel/ex-exit.S b/arch/nds32/kernel/ex-exit.S
> index 6a2966c2d8c8..b30699911b81 100644
> --- a/arch/nds32/kernel/ex-exit.S
> +++ b/arch/nds32/kernel/ex-exit.S
> @@ -120,7 +120,7 @@ work_pending:
>  	andi	$p1, $r1, #_TIF_NEED_RESCHED
>  	bnez	$p1, work_resched
>  
> -	andi	$p1, $r1, #_TIF_SIGPENDING|#_TIF_NOTIFY_RESUME
> +	andi	$p1, $r1, #_TIF_SIGPENDING|#_TIF_NOTIFY_RESUME|#_TIF_NOTIFY_SIGNAL
>  	beqz	$p1, no_work_pending
>  
>  	move	$r0, $sp			! 'regs'
> diff --git a/arch/nds32/kernel/signal.c b/arch/nds32/kernel/signal.c
> index 2acb94812af9..7e3ca430a223 100644
> --- a/arch/nds32/kernel/signal.c
> +++ b/arch/nds32/kernel/signal.c
> @@ -376,7 +376,7 @@ static void do_signal(struct pt_regs *regs)
>  asmlinkage void
>  do_notify_resume(struct pt_regs *regs, unsigned int thread_flags)
>  {
> -	if (thread_flags & _TIF_SIGPENDING)
> +	if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
>  		do_signal(regs);
>  
>  	if (thread_flags & _TIF_NOTIFY_RESUME)
> 


-- 
Jens Axboe


      reply	other threads:[~2020-11-05 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 16:17 Jens Axboe
2020-11-05 16:18 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cea6b7c-6372-002d-f158-57f85e72668e@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickhu@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®