From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9921240928D for ; Thu, 27 Aug 2026 13:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787839170; cv=none; b=CcZLbzPKZMg4Y0q9jNYKCq+sHZzp+WuIRrGIS1QfTGAK0q/4A1xytMR6unjOMXGDi2fEm+s75jX1t7nGfO2MKUdW/MKWfDu35EYyd5Xrcwcb5cDeDyAf/mRgq/bwKvoPHdn/1j/LnKHy0dejGCsF5c8bSlKeEiGJNnlm+Y2odQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787839170; c=relaxed/simple; bh=4BApbd7xRD274am4qHzSTtPAUlhQ4Wf3kdL+o+NAvEU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nclx6sAvK3+A1paPOjrkXQDvIxJlGgI0QFMCsaBuU/wAHpaxl/mShDiO9FsfjzOE/5YERgr6z9V2kKRhbfe6khMMHFFZEMvoTcSPvNMQR/jTLrQRK5xaeYfsXMFH4oRPfrP+5M8lvd7ASKrvUOXJZFJ0ggaWKv5ymL+NFjEQRu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=siw2lhYn; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="siw2lhYn" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso2743893a91.3 for ; Thu, 27 Aug 2026 06:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787839169; x=1788443969; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=B5StRPqIQTEZjnwEJl7/p40cn9Gtnc5osnnCjWoXWNI=; b=siw2lhYnmzU1LcPxrKChEiGPBfGlLQ1r/QNN2wK17Dp0IeSO1pVOAOZZ9zOUFtS0WR Kiy1dJj6eTaCZaEz3LWWDihP9PdQ2iUkgObF8atWGbCd6ZIcfD4IXgwqyojQTB5Fh3j2 AMmeCm9pYqF7LA7umk3q7y+kObIMnF5wTxys4Bxxfg/vZ//vUc2AzdUNxKKpl6rW5I4+ xCm1y7XRnAxhqQgaNisBYDADL7lFNQzkPYVK8msN4EzFaGdcUlk1hGE8/wxsyUrnUNd8 Lmy4VLgG33cJfXJBNdNcWUaVZzZKXNZIZ2547OfRCb2iRaK351LFc/g1s4YH5CKLMO07 WL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787839169; x=1788443969; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B5StRPqIQTEZjnwEJl7/p40cn9Gtnc5osnnCjWoXWNI=; b=MBVLkH38zp/bh511Vs6fmS7AdO9EC5BE0zDvGIbz0SFrgqm31mGRc9c8DmCKkuitlk 2htFH7pazUvVQXLkkIS3MUdrsn1N21XkSIbNQDN0zeTUDguqaJwgHNxHh4EGKXfeR9/d RCC0dqCc4ad8DzglaY7SBhgP1WG1ldMZsGHDXkUxqs/vMnbZQUc0p/TuR4kEmdkD8tCo EZ7WLkUQBaXHTvPzu2IDDrIxWBRs6LI70sLYLe1fq6YcvybaBIUKEDkNY2RoUaIejrxZ rHbb58niofb3043Y4GNHRlM4G+PO67IRL2u5p9L2vyfpT8iM3mk4NLoSWneTeWzTyxZ1 tbbQ== X-Forwarded-Encrypted: i=1; AHgh+RprO5DABgCkM3Hr93HhfAfKVyUMOueyG+pWIsZfD8yK0mC46qMLNG+v6rHPJZM0WbpRqDSvyS0wsN53WDI=@vger.kernel.org X-Gm-Message-State: AFuF++kCc4UeuYNoizFYw11zTizR7YtoZdWyuXdWplwl2hSq5dZ/GR/H SFGwOcd7I8HqowfQa25eqqOXSMXrcVfrANpO8vpuQFrojRvx4Vupp2Nakbm0Vw== X-Gm-Gg: AR+sD12bbQRNumCG8iN4ocvCyhaGPB3TGrgteqhczIAri+lLaVUHnOseov0O3BnYM2U gCpLqZElnc9azZdFWlcpFLnM3xTs2rZUd2L+YujBHtd5sKNalvSby2QB7AjVcUL3syx9WR2a+U2 4XBYRgXnx9oFrgVnlGWP3GGeO1qxUo2RsUJKMW0bd6wixY9g2pWCbUnZhd+6rN1PCNCVaZ0Z5J9 PfmaJCNnd4pE0XxpSC/4rXznaVwcVRqRe645GRXWvewQPjGVgNZnHd/Efr5WndC/Z9ICkkyN/Ya 7hrpseTiESSj+wkctW4qVgInpbecpt8e1FkRO7mU/kBMEEkU3I9+asPlcC0p9a/rdl0E8x2yR4C qEUrGvGkqZ7S+47Ue7hKFncoPNEJLpw5qzbnbBB24Pe8H+nZ4OdQIAsvFRf8RR8CXjwOqc6Ek7D pQ6LzxXJX0AmbNDmt1jinZvhHocSnDle5kimYlCgOxTjXzHg7J/NHQhKFlx5ZIipu7LbbUYgioG g== X-Received: by 2002:a17:90b:1fd0:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-3966d3ed042mr33079618a91.6.1787839168843; Thu, 27 Aug 2026 06:59:28 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396b0fd55a4sm2972734a91.7.2026.08.27.06.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 06:59:27 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 27 Aug 2026 06:59:27 -0700 From: Guenter Roeck To: Manush Prajwal Cc: xingyu.wu@starfivetech.com, ziv.xu@starfivetech.com, wim@linux-watchdog.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2] watchdog: starfive: fix runtime PM usage counter leak in pm_start Message-ID: <6cefb263-7f9c-4be5-aff2-6e1a66bdd4b5@roeck-us.net> References: <6a8b157b.8e75e0cb.2cc15f.4aae@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a8b157b.8e75e0cb.2cc15f.4aae@mx.google.com> On Sun, Aug 23, 2026 at 09:14:59PM +0530, Manush Prajwal wrote: > starfive_wdt_pm_start() calls pm_runtime_get_sync() and returns its > error code directly on failure. Per Documentation/power/runtime_pm.rst, > pm_runtime_get_sync() does not drop the usage counter on error, so the > caller is expected to release the reference itself. The early return > here skips that, leaking a runtime PM usage count on wdd->parent on > every failed resume, which prevents the device from being suspended > correctly afterwards. > > Fix it by calling pm_runtime_put_noidle() before returning, mirroring > the same balance the counterpart starfive_wdt_pm_stop() already > maintains with pm_runtime_put_sync(). > > v1 only balanced the pm_runtime_get_sync() failure path. As Guenter > Roeck and the Sashiko AI review both pointed out, the same leak > remains if the subsequent starfive_wdt_start() call fails: the > runtime PM reference acquired by pm_runtime_get_sync() would still be > held while returning an error, again leaving the device unable to > suspend. Drop the reference on that failure path too. > > Signed-off-by: manushprajwal checkpatch says: WARNING: From:/Signed-off-by: email name mismatch: 'From: Manush Prajwal ' != 'Signed-off-by: manushprajwal ' ... which means that I can not apply this patch. Please fix and resend. Thanks, Guenter