From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA15BC25B08 for ; Fri, 5 Aug 2022 16:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241235AbiHEQHR (ORCPT ); Fri, 5 Aug 2022 12:07:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240588AbiHEQHQ (ORCPT ); Fri, 5 Aug 2022 12:07:16 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC82B32DA4 for ; Fri, 5 Aug 2022 09:07:14 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id l22so3746525wrz.7 for ; Fri, 05 Aug 2022 09:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=foE9NLSu+Hm19YIAVmVBxv5cqU+R70Qhy9c+iSwfgU8=; b=aIKKpgqOwqtohc0kEcEbtcv4xGlQ2qiXde4MKN4UU6u37Axtk1NjJ9Di04o7fRfGVb 9RcVNIsoldcjZuMR1JP86JcdPuSS+g5O2PAF7Orpud3x2bMQaHBM/aWQYbJUSoe+zShL Occ/s+iJZRU1uiyFu7xyY9p4murvMWZpoIirIXzkGln3wZ3oiIeCs9YPJopsYxT0fYjz Valh7TSSoQomjuwv2eLixJrqCrNIyt+5/N4S0iQqk7PNjvYZ357718rqI4I5zY28J2wR SsTXVHfJ+pc3Fl+52/KRNN6JJajI+8XCXVMlR3AyKw1jVsYbCFRa0yFdXjHVdxu4AWbY 5QCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=foE9NLSu+Hm19YIAVmVBxv5cqU+R70Qhy9c+iSwfgU8=; b=QltUVEAG7foUkJFGrS1YnJgG7h08NEF+D+0dx46dRVXcRss9EKaEeGFxnhhiijsJrB Af234rP/NUxaFXE7JpsrXNAq6hQY7aXswWZ7Y/ltSdUzFNmbyvrDOiuJyeRakdpCLFpV 59pBwmi2Pk9cvCHDd088gsvkjCYra0jpQxVv3neLCZ8HQYRhPtgB/6p8c921/Oi8mht4 Qh/8IZ1ZJrBbLWJkMW2cNVm1zD3aKDp5S0rNz0QD7V1ioFaBoDKoK8Fz2Xj71CcKA3fi TfC/r01UDpxwo1KddcWqDvt07wQ+xsyrpSh9JZirAjCE5dzEy5jHK8fzHM+ONQfZz9+m hQGw== X-Gm-Message-State: ACgBeo0eP0xsbplBaN9dUE3SOxSrcVsUtisOEyrk2Rg4QfKVfHZ+ECv1 ioq6U7F3ThX+bKvZgznCWrP7Ig== X-Google-Smtp-Source: AA6agR7avs62yuynakGDNbLvwYzOeyYpJ1lkFW/hY7pOB/UOWJMsaHtToegMOmwouDTDbCsAYD72MQ== X-Received: by 2002:a5d:4301:0:b0:21b:8af6:4a21 with SMTP id h1-20020a5d4301000000b0021b8af64a21mr5060330wrq.296.1659715633284; Fri, 05 Aug 2022 09:07:13 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:aef0:8606:da6b:79ef? ([2a05:6e02:1041:c10:aef0:8606:da6b:79ef]) by smtp.googlemail.com with ESMTPSA id bh19-20020a05600c3d1300b003a2f6367049sm5051263wmb.48.2022.08.05.09.07.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 09:07:12 -0700 (PDT) Message-ID: <6cf66002-f13d-a1ee-7fa6-dfa78d6be427@linaro.org> Date: Fri, 5 Aug 2022 18:07:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone detection" Content-Language: en-US To: Vadim Pasternak , "rafael@kernel.org" Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ido Schimmel , Petr Machata , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20220801095622.949079-1-daniel.lezcano@linaro.org> <20220801095622.949079-2-daniel.lezcano@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vadim, On 04/08/2022 14:21, Vadim Pasternak wrote: > > >> -----Original Message----- >> From: Daniel Lezcano >> Sent: Monday, August 1, 2022 12:56 PM >> To: daniel.lezcano@linaro.org; rafael@kernel.org >> Cc: Vadim Pasternak ; davem@davemloft.net; >> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Ido Schimmel >> ; Petr Machata ; Eric Dumazet >> ; Jakub Kicinski ; Paolo Abeni >> >> Subject: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone >> detection" >> >> This reverts commit 6f73862fabd93213de157d9cc6ef76084311c628. >> >> As discussed in the thread: >> >> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010- >> bff366c8aeba@linaro.org/ >> >> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is >> actually already handled by the thermal framework via the cooling device >> state aggregation, thus all this code is pointless. >> >> The revert conflicts with the following changes: >> - 7f4957be0d5b8: thermal: Use mode helpers in drivers >> - 6a79507cfe94c: mlxsw: core: Extend thermal module with per QSFP module >> thermal zones >> >> These conflicts were fixed and the resulting changes are in this patch. >> >> Signed-off-by: Daniel Lezcano > Tested-by: Vadim Pasternak Thanks for testing > Daniel, > Could you, please, re-base the patch on top of net-next as Jakub mentioned? > Or do you want me to do it? It is fine, I can do it. The conflict is trivial. However, I would have preferred to have the patch in my tree so I can continue the consolidation work. Is it ok if I pick the patch and the conflict being simple, that can be handle at merge time, no? > There is also redundant blank line in this patch: > &mlxsw_thermal_module_ops, > + > &mlxsw_thermal_params, Yeah, thanks. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog