mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "charles gagalac" <charles.gagalac@gmail.com>
To: "Al Viro" <viro@zeniv.linux.org.uk>
Cc: "Marc Koschewski" <marc@osknowledge.org>,
	Linux-LKLM <linux-kernel@vger.kernel.org>
Subject: Re: reiserfs broken with 2.6.28-17244-gb58602a
Date: Sat, 3 Jan 2009 08:37:30 -1000	[thread overview]
Message-ID: <6cf66ee10901031037ia2fdd57wdb7494dd6ff6a282@mail.gmail.com> (raw)
In-Reply-To: <20090102132308.GE28946@ZenIV.linux.org.uk>

On Fri, Jan 2, 2009 at 3:23 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Arrgh.  See if that helps:
>
> now that we use ih.key earlier, we need to do all its setup early enough
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 145c2d3..1306d4f 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -1782,6 +1782,12 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
>                goto out_bad_inode;
>        }
>        args.objectid = inode->i_ino = le32_to_cpu(ih.ih_key.k_objectid);
> +       if (old_format_only(sb))
> +               make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
> +                                 TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
> +       else
> +               make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
> +                                 TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
>        memcpy(INODE_PKEY(inode), &(ih.ih_key), KEY_SIZE);
>        args.dirid = le32_to_cpu(ih.ih_key.k_dir_id);
>        if (insert_inode_locked4(inode, args.objectid,
> @@ -1834,13 +1840,6 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
>        reiserfs_init_acl_default(inode);
>        reiserfs_init_xattr_rwsem(inode);
>
> -       if (old_format_only(sb))
> -               make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
> -                                 TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
> -       else
> -               make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
> -                                 TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
> -
>        /* key to search for correct place for new stat data */
>        _make_cpu_key(&key, KEY_FORMAT_3_6, le32_to_cpu(ih.ih_key.k_dir_id),
>                      le32_to_cpu(ih.ih_key.k_objectid), SD_OFFSET,
> --

the patch fixed the reiserfs problem for me.  thanks.

charles

      reply	other threads:[~2009-01-03 18:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02  8:38 Marc Koschewski
2009-01-02 13:23 ` Al Viro
2009-01-03 18:37   ` charles gagalac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cf66ee10901031037ia2fdd57wdb7494dd6ff6a282@mail.gmail.com \
    --to=charles.gagalac@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc@osknowledge.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome