Re: [stable] patch iwlwifi-silence-tfds_in_queue-message.patch added to 2.6.32-stable tree

[Adel Gadllah <adel.gadllah@gmail.com>]

2010/3/30 Greg KH <greg@kroah.com>:
> On Tue, Mar 30, 2010 at 09:16:02AM +0200, Stefan Bader wrote:
>> Greg KH wrote:
>> > On Mon, Mar 29, 2010 at 03:09:35PM -0700, reinette chatre wrote:
>> >> Hi,
>> >>
>> >> On Mon, 2010-03-29 at 13:41 -0700, gregkh@suse.de wrote:
>> >>> This is a note to let you know that we have just queued up the patch titled
>> >>>
>> >>>     Subject: iwlwifi: Silence tfds_in_queue message
>> >>>
>> >>> to the 2.6.32-stable tree.
>> >> [...]
>> >>
>> >> Please note that this patch is really just masking a problem introduced
>> >> by a 2.6.32 backported patch. The real fix is
>> >> https://patchwork.kernel.org/patch/86722/ which should be included in
>> >> 2.6.32.
>> >
>> > What is the git commit id for that patch?  patchwork links don't help me
>> > at all.
>>
>> There isn't one. The main problem only exists in 2.6.32.y
>> because the final hunk missed to remove the nfreed++ from
>> ouside the if.
>>
>> Introduced by backport of in 2.6.32.y
>>
>> commit a120e912eb51e347f36c71b60a1d13af74d30e83
>> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>> Date:   Fri Feb 19 15:47:33 2010 -0800
>>
>>     iwlwifi: sanity check before counting number of tfds can be free
>
> So, what exactly should I be doing here for the .32 stable queue?

Apply the patch that fixes the mess (i.e the one Reinette linked to)
;), whether this patch (the one you are about to push) goes in or not
does not matter much (i.e having it won't hurt, but the fix for the
real problem should go in).

Adel