From: Guenter Roeck <linux@roeck-us.net>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: hwmon: g76x: Add support for g761
Date: Sat, 25 May 2024 12:58:40 -0700 [thread overview]
Message-ID: <6cfa48e3-ce77-4736-91c7-7c4ef158935e@roeck-us.net> (raw)
In-Reply-To: <6651fc46.050a0220.5b758.034d@mx.google.com>
On 5/25/24 04:12, Christian Marangi wrote:
>>> Well with how the driver works, if a property is not defined, then the
>>> value is not set and the one set by the bootloader or from device reset
>>> is keept.
>>>
>>> This conflicts with the logic of no clock = internal.
>>>
>>
>> Not sure I understand the problem. It would be a simple change in the driver
>> to add "if the chip is G761 and the clock is not provided in DT, use the
>> internal clock".
>>
>
> Yes sure code wise is pretty easy, my concern is more of losing this
> info in DT. But anyway ok will drop in V2. Thanks a lot for the review!
>
Not sure I understand. This is added support for a chip which is not currently
supported. There should not be any information to lose. What am I missing ?
Guenter
next prev parent reply other threads:[~2024-05-25 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 10:29 [PATCH 1/3] dt-bindings: hwmon: g762: Convert to yaml schema Christian Marangi
2024-05-25 10:29 ` [PATCH 2/3] dt-bindings: hwmon: g76x: Add support for g761 Christian Marangi
2024-05-25 14:32 ` Guenter Roeck
2024-05-25 10:50 ` Christian Marangi
2024-05-25 14:53 ` Guenter Roeck
2024-05-25 11:12 ` Christian Marangi
2024-05-25 19:58 ` Guenter Roeck [this message]
2024-05-25 10:29 ` [PATCH 3/3] hwmon: g672: add " Christian Marangi
2024-05-25 14:29 ` Guenter Roeck
2024-05-25 10:47 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cfa48e3-ce77-4736-91c7-7c4ef158935e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®