From: Pierre Gondois <pierre.gondois@arm.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: linux-kernel@vger.kernel.org, Radu Rendec <rrendec@redhat.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v2 3/3] cacheinfo: Add use_arch[|_cache]_info field/function
Date: Wed, 12 Apr 2023 14:35:08 +0200 [thread overview]
Message-ID: <6cff363a-97bf-b898-44d0-54f4c2ab647c@arm.com> (raw)
In-Reply-To: <20230412-femur-aspect-b54b10ad9fd1@wendy>
On 4/12/23 13:47, Conor Dooley wrote:
> On Wed, Apr 12, 2023 at 09:18:06AM +0200, Pierre Gondois wrote:
>
>> +static inline bool
>> +use_arch_cache_info(void)
>
> Tiny nit, why the newline when `static inline bool
> use_arch_cache_info(void)` is only 50ish characters?
Ok sure, I ll do that.
Regards,
Pierre
>
> Cheers,
> Conor.
prev parent reply other threads:[~2023-04-12 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 7:18 [PATCH v2 0/3] cacheinfo: Correctly fallback to using clidr_el1's information Pierre Gondois
2023-04-12 7:18 ` [PATCH v2 1/3] cacheinfo: Check sib_leaf in cache_leaves_are_shared() Pierre Gondois
2023-04-12 11:27 ` Conor Dooley
2023-04-12 12:34 ` Pierre Gondois
2023-04-12 12:47 ` Conor Dooley
2023-04-12 13:20 ` Pierre Gondois
2023-04-12 13:50 ` Conor Dooley
2023-04-12 7:18 ` [PATCH v2 2/3] cacheinfo: Check cache properties are present in DT Pierre Gondois
2023-04-12 7:55 ` Conor Dooley
2023-04-12 8:12 ` Pierre Gondois
2023-04-12 9:38 ` Alexandre Ghiti
2023-04-12 7:18 ` [PATCH v2 3/3] cacheinfo: Add use_arch[|_cache]_info field/function Pierre Gondois
2023-04-12 11:47 ` Conor Dooley
2023-04-12 12:35 ` Pierre Gondois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cff363a-97bf-b898-44d0-54f4c2ab647c@arm.com \
--to=pierre.gondois@arm.com \
--cc=alexghiti@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@rivosinc.com \
--cc=rafael@kernel.org \
--cc=rrendec@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®