From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Randy Dunlap <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: Richard Weinberger <richard@nod.at>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 2/3] ubifs: key.h: use correct function parameter name
Date: Thu, 30 Jul 2026 09:20:35 +0800 [thread overview]
Message-ID: <6d03a559-5d87-2cc3-2742-f584fbaec179@huawei.com> (raw)
In-Reply-To: <20260729172044.1793865-3-rdunlap@infradead.org>
在 2026/7/30 1:20, Randy Dunlap 写道:
> Use @hash as the function parameter name to prevent kernel-doc warnings:
>
> Warning: fs/ubifs/key.h:42 function parameter 'hash' not described in 'key_mask_hash'
> Warning: fs/ubifs/key.h:42 Excess function parameter 'val' description in 'key_mask_hash'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Zhihao Cheng <chengzhihao1@huawei.com>
> Cc: linux-mtd@lists.infradead.org
>
> fs/ubifs/key.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> --- linux-next-20260729.orig/fs/ubifs/key.h
> +++ linux-next-20260729/fs/ubifs/key.h
> @@ -33,7 +33,7 @@
>
> /**
> * key_mask_hash - mask a valid hash value.
> - * @val: value to be masked
> + * @hash: value to be masked
> *
> * We use hash values as offset in directories, so values %0 and %1 are
> * reserved for "." and "..". %2 is reserved for "end of readdir" marker. This
> .
>
next prev parent reply other threads:[~2026-07-30 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 17:20 [PATCH] ubifs: headers: clean up some kernel-doc comments Randy Dunlap
2026-07-29 17:20 ` [PATCH 1/3] ubifs: debug.h: fix kernel-doc struct prototypes Randy Dunlap
2026-07-29 17:20 ` [PATCH 2/3] ubifs: key.h: use correct function parameter name Randy Dunlap
2026-07-30 1:20 ` Zhihao Cheng [this message]
2026-07-29 17:20 ` [PATCH 3/3] ubifs: ubifs.h: clean up kernel-doc comments Randy Dunlap
2026-07-30 1:25 ` Zhihao Cheng
2026-08-11 21:05 ` [PATCH] ubifs: headers: clean up some " Richard Weinberger (sigma star gmbh)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d03a559-5d87-2cc3-2742-f584fbaec179@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®