From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A943C433E0 for ; Sun, 28 Jun 2020 01:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A74B20768 for ; Sun, 28 Jun 2020 01:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgF1Bf4 (ORCPT ); Sat, 27 Jun 2020 21:35:56 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6320 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726101AbgF1Bf4 (ORCPT ); Sat, 27 Jun 2020 21:35:56 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7930CCAC7C623C057F9A; Sun, 28 Jun 2020 09:35:54 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sun, 28 Jun 2020 09:35:53 +0800 Subject: Re: [PATCH 5/5] f2fs: show more debug info for per-temperature log To: Jaegeuk Kim CC: , , References: <20200618063625.110273-1-yuchao0@huawei.com> <20200618063625.110273-5-yuchao0@huawei.com> <20200624223114.GA192472@google.com> From: Chao Yu Message-ID: <6d0d3aad-98ac-7cca-7d76-525a82f99184@huawei.com> Date: Sun, 28 Jun 2020 09:35:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200624223114.GA192472@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/6/25 6:31, Jaegeuk Kim wrote: > On 06/18, Chao Yu wrote: >> - Add to account and show per-log dirty_seg, full_seg and valid_blocks >> in debugfs. >> - reformat printed info. >> >> TYPE segno secno zoneno dirty_seg full_seg valid_blk >> - COLD data: 1523 1523 1523 1 0 399 >> - WARM data: 769 769 769 20 255 133098 >> - HOT data: 767 767 767 9 0 167 >> - Dir dnode: 22 22 22 3 0 70 >> - File dnode: 722 722 722 14 10 6505 >> - Indir nodes: 2 2 2 1 0 3 >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/debug.c | 67 ++++++++++++++++++++++++++++++++++++++++--------- >> fs/f2fs/f2fs.h | 3 +++ >> 2 files changed, 58 insertions(+), 12 deletions(-) >> >> diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c >> index 0dbcb0f9c019..aa1fd2de11ba 100644 >> --- a/fs/f2fs/debug.c >> +++ b/fs/f2fs/debug.c >> @@ -174,6 +174,29 @@ static void update_general_status(struct f2fs_sb_info *sbi) >> for (i = META_CP; i < META_MAX; i++) >> si->meta_count[i] = atomic_read(&sbi->meta_count[i]); >> >> + for (i = 0; i < NO_CHECK_TYPE; i++) { >> + si->dirty_seg[i] = 0; >> + si->full_seg[i] = 0; >> + si->valid_blks[i] = 0; >> + } >> + >> + for (i = 0; i < MAIN_SEGS(sbi); i++) { >> + int blks = get_seg_entry(sbi, i)->valid_blocks; >> + int type = get_seg_entry(sbi, i)->type; >> + >> + if (!blks) >> + continue; >> + >> + if (IS_CURSEG(sbi, i)) >> + continue; > > How about adding current segments as well? Especially, it's hard to see any > valid blocks for cold node with this. Better, let me update this patch. > >> + >> + if (blks == sbi->blocks_per_seg) >> + si->full_seg[type]++; >> + else >> + si->dirty_seg[type]++; >> + si->valid_blks[type] += blks; >> + } >> + >> for (i = 0; i < 2; i++) { >> si->segment_count[i] = sbi->segment_count[i]; >> si->block_count[i] = sbi->block_count[i]; >> @@ -329,30 +352,50 @@ static int stat_show(struct seq_file *s, void *v) >> seq_printf(s, "\nMain area: %d segs, %d secs %d zones\n", >> si->main_area_segs, si->main_area_sections, >> si->main_area_zones); >> - seq_printf(s, " - COLD data: %d, %d, %d\n", >> + seq_printf(s, " TYPE %8s %8s %8s %10s %10s %10s\n", >> + "segno", "secno", "zoneno", "dirty_seg", "full_seg", "valid_blk"); >> + seq_printf(s, " - COLD data: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_COLD_DATA], >> si->cursec[CURSEG_COLD_DATA], >> - si->curzone[CURSEG_COLD_DATA]); >> - seq_printf(s, " - WARM data: %d, %d, %d\n", >> + si->curzone[CURSEG_COLD_DATA], >> + si->dirty_seg[CURSEG_COLD_DATA], >> + si->full_seg[CURSEG_COLD_DATA], >> + si->valid_blks[CURSEG_COLD_DATA]); >> + seq_printf(s, " - WARM data: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_WARM_DATA], >> si->cursec[CURSEG_WARM_DATA], >> - si->curzone[CURSEG_WARM_DATA]); >> - seq_printf(s, " - HOT data: %d, %d, %d\n", >> + si->curzone[CURSEG_WARM_DATA], >> + si->dirty_seg[CURSEG_WARM_DATA], >> + si->full_seg[CURSEG_WARM_DATA], >> + si->valid_blks[CURSEG_WARM_DATA]); >> + seq_printf(s, " - HOT data: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_HOT_DATA], >> si->cursec[CURSEG_HOT_DATA], >> - si->curzone[CURSEG_HOT_DATA]); >> - seq_printf(s, " - Dir dnode: %d, %d, %d\n", >> + si->curzone[CURSEG_HOT_DATA], >> + si->dirty_seg[CURSEG_HOT_DATA], >> + si->full_seg[CURSEG_HOT_DATA], >> + si->valid_blks[CURSEG_HOT_DATA]); >> + seq_printf(s, " - Dir dnode: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_HOT_NODE], >> si->cursec[CURSEG_HOT_NODE], >> - si->curzone[CURSEG_HOT_NODE]); >> - seq_printf(s, " - File dnode: %d, %d, %d\n", >> + si->curzone[CURSEG_HOT_NODE], >> + si->dirty_seg[CURSEG_HOT_NODE], >> + si->full_seg[CURSEG_HOT_NODE], >> + si->valid_blks[CURSEG_HOT_NODE]); >> + seq_printf(s, " - File dnode: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_WARM_NODE], >> si->cursec[CURSEG_WARM_NODE], >> - si->curzone[CURSEG_WARM_NODE]); >> - seq_printf(s, " - Indir nodes: %d, %d, %d\n", >> + si->curzone[CURSEG_WARM_NODE], >> + si->dirty_seg[CURSEG_WARM_NODE], >> + si->full_seg[CURSEG_WARM_NODE], >> + si->valid_blks[CURSEG_WARM_NODE]); >> + seq_printf(s, " - Indir nodes: %8d %8d %8d %10u %10u %10u\n", >> si->curseg[CURSEG_COLD_NODE], >> si->cursec[CURSEG_COLD_NODE], >> - si->curzone[CURSEG_COLD_NODE]); >> + si->curzone[CURSEG_COLD_NODE], >> + si->dirty_seg[CURSEG_COLD_NODE], >> + si->full_seg[CURSEG_COLD_NODE], >> + si->valid_blks[CURSEG_COLD_NODE]); >> seq_printf(s, "\n - Valid: %d\n - Dirty: %d\n", >> si->main_area_segs - si->dirty_count - >> si->prefree_count - si->free_segs, >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 72a667f1d678..70565d81320b 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -3536,6 +3536,9 @@ struct f2fs_stat_info { >> int curseg[NR_CURSEG_TYPE]; >> int cursec[NR_CURSEG_TYPE]; >> int curzone[NR_CURSEG_TYPE]; >> + unsigned int dirty_seg[NR_CURSEG_TYPE]; >> + unsigned int full_seg[NR_CURSEG_TYPE]; >> + unsigned int valid_blks[NR_CURSEG_TYPE]; >> >> unsigned int meta_count[META_MAX]; >> unsigned int segment_count[2]; >> -- >> 2.18.0.rc1 > . >