From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495C6C6377D for ; Tue, 20 Jul 2021 01:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18E01611EF for ; Tue, 20 Jul 2021 01:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350549AbhGTAed (ORCPT ); Mon, 19 Jul 2021 20:34:33 -0400 Received: from mx.socionext.com ([202.248.49.38]:10511 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381046AbhGTA2Z (ORCPT ); Mon, 19 Jul 2021 20:28:25 -0400 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 20 Jul 2021 10:08:53 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 8647A205902A; Tue, 20 Jul 2021 10:08:53 +0900 (JST) Received: from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP; Tue, 20 Jul 2021 10:08:53 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by iyokan2.css.socionext.com (Postfix) with ESMTP id 52BE7B638F; Tue, 20 Jul 2021 10:08:53 +0900 (JST) Received: from [10.212.31.2] (unknown [10.212.31.2]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 161D9B1D52; Tue, 20 Jul 2021 10:08:52 +0900 (JST) Subject: Re: [PATCH] PCI: endpoint: Use sysfs_emit() in "show" functions To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= Cc: Kishon Vijay Abraham I , Lorenzo Pieralisi , Bjorn Helgaas , Sasha Levin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <1626662666-15798-1-git-send-email-hayashi.kunihiko@socionext.com> <20210719034313.GA274232@rocinante> <20210719151837.GA473693@rocinante> From: Kunihiko Hayashi Message-ID: <6d10e89b-3518-faff-e320-6d03013567a1@socionext.com> Date: Tue, 20 Jul 2021 10:08:51 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210719151837.GA473693@rocinante> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2021/07/20 0:18, Krzysztof Wilczy?ski wrote: > [+cc Sasha for visibility] > > Hi! > > [...] >>> Nice catch! >> >> I actually executed "cat" against configfs to meet the issue and found >> your solution in pci-sysfs. > > Oh! That's not good... I am curious, which attribute caused this? Sorry I misunderstood. I found this "cat" issue on next-20210713 and all configfs attribues had the same issue. However, my patch wasn't the solution for the issue. This has been fixed by 7fe1e79b59ba ("configfs: implement the .read_iter and .write_iter methods"). The function replacement was found in the process of finding the issue. > Also, if this is fixing a bug, then it might warrant letting the folks who look > after the long-term and stable kernels know. I also wonder if there would be > something to add for the "Fixes:" tag, if there is a previous commit this > change fixes. So my patch doesn't fix any issues. Thank you, --- Best Regards Kunihiko Hayashi