From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D601F0E37 for ; Thu, 20 Feb 2025 10:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740046970; cv=none; b=RaLW4Xgkbyf5HNupsUkc7/sNJunOd+bvcNVLmekehD9JvDkItOrTzLztiLlXuN/NOm7hLUxhGY2cAndr30mHY1+/1l/K+pZISS/GbiXVk9Ot4bPrpAWHCtfmaR/XglVmC/5Cp6E5++dOTKmCPu00sYhF6I4qjEx/OeMNFWPHY7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740046970; c=relaxed/simple; bh=dwV5C1T08uCJyhf61xNHGbLrnXfynaFJ/L/Ujo0Xy28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g5nVKWT+cMtUFfT2kOEGc+uMHLuwbbA5WJMjf/C5D6+IXQk0lsbHvhWoZO/8Ci7/Qbab4i22uVq2129OLGZP9jBsIpS2GJuG+KA1Ji3/s2T0BP2VsuAnQaxgM9CLn+JtdgkyvaP87tSK5iZg2yyGZHqpHYu6gqe7QTbzBkXxmXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AN6xyaBQ; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AN6xyaBQ" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38f265c6cb0so363392f8f.2 for ; Thu, 20 Feb 2025 02:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1740046967; x=1740651767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mdJ1tjXDGbz7fnnLGr6p9xq7nJI8m1bb43amubJ0qpU=; b=AN6xyaBQmi9zBQcVep+o0zVfgKluhdmta3a2sU90KfgCm5Kfjp1sT/3Jbmh4tlaAxw NgWxJUcR4LdAIxqSrMUYRoxyWh3G1pUYQds0foLS+dJPQybkMKgq/la0xZvOJRDrBokl bQo17+XbHm6MJ0gycY1BkfKhSdnkHmPqfemN2nQph9V3jqEPPlyop6JXKK4+iQFbtf/J GtiyN8gDwRSZpY2Usno9vkxZFtxUNyJwNLgzAzopxMCJ/aJM+DRNdsgFjhheXATGlmTd YOs8Nw+nmrOZIEMQ824ZwlxNA/LP3x+Bj96sR0yaWH10wLb/Rh+p5ky3ZLaHGeEcTcWQ 3zDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740046967; x=1740651767; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mdJ1tjXDGbz7fnnLGr6p9xq7nJI8m1bb43amubJ0qpU=; b=QYahgEMcyrIRt8rI5pHeC9msc8ROIY5UOBTHequpYolTL7VZb+C1ko828Ryf9yBO7c V+VzP/eOh0qMBa+0CXKxrskViUVNkdDSGlU6248FQ2sAU6CTzP5Xii+5pjStYqowXLcL 3Ypp2IhkSdGObO+LsthLIlwdTJYnMCtlGrjzfIbejVzHSTUgJ5vjxm6PE1Dj/qExHSVN kF8imjFMSwQEBD82hiHbEh8ss5eoXTqra80Cjn2KmC+wuyV48KEHJIz4MRjuMDFDrtTE 7+OPSiMtRkWDXb54K6OFGbauMrbu+7dtUY0oqnXCzYMIC+DB3BXRd3+JBsnqjfIMFQll oCuA== X-Forwarded-Encrypted: i=1; AJvYcCWtALqNnBhORhplA3eYNTkFfhfaZm8ApCeJDVQeBilRAPoVEkMEp1FPBXtQp+mpUIvGkEO6qP+nCgS2OfE=@vger.kernel.org X-Gm-Message-State: AOJu0YzYdIvvGRRkRHf8aL4+E035+F4cY8k9WB0Bjq7tBI270nn52Rbp 8n2vOewBlPMojJRKzWrufdeE0k100MvGa7khbDbNLhu2nXWl4cGDbP9Q2LUA9jA= X-Gm-Gg: ASbGncsVHE9JORUrAFSvgt0GKH24gHVSgrJwQlKaD5cxn7RLcaDG8tDKwpa549R3UD0 dzcuxVhfA+s/4/F1v/sgWKoRZe/XNqfYFSD3vou9sYoEDoOuAn/mnJqhK2w9czgFqBzFuk4us2E YtPiNlWqFfSKwaCoVYuPqGbC8895JbOLFw9Q0AcZPPEZ7jHHlS1IHDtUectTvB1bIDRdThrY4MC LvP6FpJdhitd+5+h7g3mWHT5h7GFj+D/iUrybi2hFdaS+CvvuGvP6sVpQUTbIWyjtg2fy+aU49d PYBblRwTa7cz1iIC4mqIqUpzceb+EvbzM/CxCMo4Yv6RZuI/W2eLIzcNuA== X-Google-Smtp-Source: AGHT+IFNBKicqin94xs9R9bvB+x/bbDZRuNAbanJhmggJELPLRHyKJNVbt685+Z4xzMPELU/nUfw9w== X-Received: by 2002:a05:6000:1fa5:b0:38f:4fa5:58ce with SMTP id ffacd0b85a97d-38f4fa55a25mr10752304f8f.6.1740046966694; Thu, 20 Feb 2025 02:22:46 -0800 (PST) Received: from ?IPV6:2001:a61:136c:cf01:505d:b6ac:9103:aec6? ([2001:a61:136c:cf01:505d:b6ac:9103:aec6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259d65bcsm20344688f8f.65.2025.02.20.02.22.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 02:22:46 -0800 (PST) Message-ID: <6d14b473-6d26-4b9e-88df-2532b0c88565@suse.com> Date: Thu, 20 Feb 2025 11:22:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: core: Add error handling in usb_reset_device for autoresume failure To: Wentao Liang , gregkh@linuxfoundation.org Cc: stern@rowland.harvard.edu, christophe.jaillet@wanadoo.fr, mka@chromium.org, make_ruc2021@163.com, javier.carrasco@wolfvision.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250220095218.970-1-vulab@iscas.ac.cn> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20250220095218.970-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.02.25 10:52, Wentao Liang wrote: > In usb_reset_device(), the function continues execution and > calls usb_autosuspend_device() after usb_autosuspend_device fails. This can only fail if the device needs to be physically resumed. In that case you called usb_reset_device() while you weren't supposed to. The purpose of the call is to keep the counter elevated in order to disable runtime power management temporarily. The code is older than helpers to elevate the count. The correct fix would be to use them rather than handle an error that cannot happen. Regards Oliver