From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4704426B769 for ; Thu, 24 Jul 2025 09:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753348851; cv=none; b=oqLwETXAlFYL4OL1WOVVp5ySGXF6GLnAINd8GFyXnPkLf8/9UdSuvQDx22G09LBfXksjEersWIyymkZy3nQ0xIRIn4g+BR+rc11zH2cbqJCx89U2mXs5hWEUDoL0m8NuVm1WCAFerxFkzKw2JA5pRTamr5uacZloB98kGbCXLZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753348851; c=relaxed/simple; bh=2AYrd8i4rjljZsg1is2IvokN9g26qL4AFgFaYJkwEps=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=NQ2xQY3q45PRyq2nBqnIZx+f7Orf9CrGj1OblegnxXdB9Mnk7ThFOGWnaidKc87kraV9Ju9uFRlBqAE2d0JBgzeVxqtvsnnliLemYauQOuoeYhvPCOFdBPWjz6EuXol3ue1iIiCYIJN1rmZs7WD/I3SvxqIEQs8GTBnLqxXrzBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SD/VDEXE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SD/VDEXE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753348848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o0KQOXhvdl0E5NsfW0rWRgN9O8Gb98pd0x7UFntxo6M=; b=SD/VDEXExAwnoeuceWyiK7yNraRyzHmWRKQgxGxLtxBMFM07vkz++zX3kknp8g0YszLGw1 ab25eQljFcI/c4CCWzXLR8rtzrfNwtXVPTZB0c13KpWgU54zs5ajRjRL2tasKR91uWrXiI jWexXtXlWgcZ960uPltjAROUUIx8Y38= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-UDZBMlUYPq64_CfFF9p6GQ-1; Thu, 24 Jul 2025 05:20:46 -0400 X-MC-Unique: UDZBMlUYPq64_CfFF9p6GQ-1 X-Mimecast-MFC-AGG-ID: UDZBMlUYPq64_CfFF9p6GQ_1753348846 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a5281ba3a4so271201f8f.0 for ; Thu, 24 Jul 2025 02:20:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753348845; x=1753953645; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:from:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o0KQOXhvdl0E5NsfW0rWRgN9O8Gb98pd0x7UFntxo6M=; b=SCw3ZykOm/4QC26o4XutxmT8hqWi75fM+GVA6El+ewOOk5WhLWWheCQod5oVNQv6md bX+BrL95u5Yv7UXkk6ymVQaFPHbbbPn5ByQYpJr5X+w+Gqq+B+AqxxFlj67KHdsk+ii0 c45tbPBI6ad0ruJ0e9PcMJJpp9P9BEt9Frz4ODNrM4CpmZBV9R0yJV5Vi0SsuzxvFJql 82BgZjS7ojRmC05lGgsXK6Dko+1ha7oZ84D30EwvVaJViI2iK7SVs6AhTyI4+8SlNA63 PjlaO0yIMnJxwrVLk/jVNSE9VZSDpNybj1Navy/iq9GRHPM71g+iWWuFzETmzfn1gjP2 1+Sg== X-Forwarded-Encrypted: i=1; AJvYcCVPxdndDpYNYhM2qaiWhG+71f+rwc6FU20Mta7o/3HkaaZMKcuzK3obrZgofZIc/pEDdzfDQy5GT5VlhKk=@vger.kernel.org X-Gm-Message-State: AOJu0YwcVjOlL25fLeBIGemK+Y30fjw+Rhyo/vedEjLvs/OdGWUDyhPA iHmhB+ktsjcz0zP0kf14KJEH3hY+agks7OCjSTkWFRqk907Yci02AXTfHPEY9mxiwhW+CTqhuEW 74SSxDabX93E1Yf5r9DGhLvkF5+L0ubTfUbcvzEQ2kcGuvpgFxZIIKcxRTYrOUy2Gaw== X-Gm-Gg: ASbGnctCy12FoZebMrl6/eiEnlWGrUKYECOfL2EWv4u80tux1yC9qsl6hVhmYkCaQF7 I0ookioWb2nLA9DrxdOX4odejIutB1KILjCukKgzOMA86mW440C185tcCzA2MEoJHLqwwyzzFBf hsMe0sPvbf1PSUCHlk9QHHjQ4Q2xIuSRWpddBqpzkcXqf/TrZxnAZaMaWooDeoYcCUOvOdWn2pZ HPVFCoPgm5QQfySVBFHSyMhz600kYw7qrbVheC+5Ovry8gFWVARHDv1nIK/uIA0YCqSQ23HAM6q lfL0aZVq0kixLKR5k6DcFVtj3Qk/aNlgXC8PJsOPQWakxU9vhlT6jGfXCB92eyud670av1/K5g/ R7OKDWY0NDfiq6WB7jdneZ2vWxuBeOpewIKvTA95G7b/4misliwAZ0JOR2z97g4Am X-Received: by 2002:a05:6000:230f:b0:3a5:2465:c0c8 with SMTP id ffacd0b85a97d-3b768ecf387mr4907855f8f.7.1753348845479; Thu, 24 Jul 2025 02:20:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8sP+bhjvLf/wV0ECiS76roKzHB7SD6ppw8rkCNfToaFey0aWT3TtUeqzBvR1r2m9NLAMX9Q== X-Received: by 2002:a05:6000:230f:b0:3a5:2465:c0c8 with SMTP id ffacd0b85a97d-3b768ecf387mr4907818f8f.7.1753348844926; Thu, 24 Jul 2025 02:20:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:5e00:c941:d6fb:3e30:b42? (p200300d82f1f5e00c941d6fb3e300b42.dip0.t-ipconnect.de. [2003:d8:2f1f:5e00:c941:d6fb:3e30:b42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458705545bcsm12688485e9.20.2025.07.24.02.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 02:20:44 -0700 (PDT) Message-ID: <6d14e212-418e-4734-b256-b75c6fade25c@redhat.com> Date: Thu, 24 Jul 2025 11:20:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/9] introduce PGTY_mgt_entry page_type From: David Hildenbrand To: Huan Yang , Andrew Morton , Lorenzo Stoakes , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo , Xu Xin , Chengming Zhou , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Matthew Wilcox (Oracle)" , Christian Brauner , Usama Arif , Yu Zhao , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250724084441.380404-1-link@vivo.com> <86516155-f2d9-4e8d-9d27-bdcb59e2d129@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24.07.25 11:12, David Hildenbrand wrote: > On 24.07.25 11:09, Huan Yang wrote: >> >> 在 2025/7/24 16:59, David Hildenbrand 写道: >>> On 24.07.25 10:44, Huan Yang wrote: >>>> Summary >>>> == >>>> This patchset reuses page_type to store migrate entry count during the >>>> period from migrate entry setup to removal, enabling accelerated VMA >>>> traversal when removing migrate entries, following a similar >>>> principle to >>>> early termination when folio is unmapped in try_to_migrate. >>> >>> I absolutely detest (ab)using page types for that, so no from my side >>> unless I am missing something important. >>> >>>> >>>> In my self-constructed test scenario, the migration time can be reduced >>> >>> How relevant is that in practice? >> >> IMO, any folio mapped < nr vma in mapping(anon_vma, addresss_space), >> will benefit from this. >> >> So, all pages that have been COW-ed by child processes can be skipped. > > For small anon folios, you could use the anon-exclusive marker to derive > "there can only be a single mapping". > > It's stored alongside the migration entry. > > So once you restored that single migration entry, you can just stop the > walk. Essentially, something (untested) like this: diff --git a/mm/migrate.c b/mm/migrate.c index 425401b2d4e14..aa5bf96b1daee 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -421,6 +421,15 @@ static bool remove_migration_pte(struct folio *folio, /* No need to invalidate - it was non-present before */ update_mmu_cache(vma, pvmw.address, pvmw.pte); + + /* + * If the small anon folio is exclusive, here can be exactly one + * page mapping -- the one we just restored. + */ + if (!folio_test_large(folio) && (rmap_flags & RMAP_EXCLUSIVE)) { + page_vma_mapped_walk_done(&pvmw); + break; + } } return true; -- Cheers, David / dhildenb