From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA972C43461 for ; Sun, 13 Sep 2020 13:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8696D2158C for ; Sun, 13 Sep 2020 13:13:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725945AbgIMNNr (ORCPT ); Sun, 13 Sep 2020 09:13:47 -0400 Received: from foss.arm.com ([217.140.110.172]:54446 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbgIMNNm (ORCPT ); Sun, 13 Sep 2020 09:13:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C242106F; Sun, 13 Sep 2020 06:13:42 -0700 (PDT) Received: from [192.168.0.21] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 05FD33F68F; Sun, 13 Sep 2020 06:13:38 -0700 (PDT) Subject: Re: [PATCH v10 10/24] coresight: etm4x: allow etm4x to be built as a module To: tingwei@codeaurora.org, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org Cc: kim.phillips@arm.com, gregkh@linuxfoundation.org, leo.yan@linaro.org, rdunlap@infradead.org, linux@armlinux.org.uk, ykaukab@suse.de, tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, jinlmao@codeaurora.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-11-tingwei@codeaurora.org> From: Suzuki K Poulose Message-ID: <6d15ba79-2cd8-9428-e9f2-0b5e7b29f833@arm.com> Date: Sun, 13 Sep 2020 14:18:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200821034445.967-11-tingwei@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/21/2020 04:44 AM, Tingwei Zhang wrote: > From: Kim Phillips > > Allow to build coresight-etm4x as a module, for ease of development. > > - Kconfig becomes a tristate, to allow =m > - append -core to source file name to allow module to > be called coresight-etm4x by the Makefile > - add an etm4_remove function, for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > - delay advertising the per-cpu etmdrvdata > - protect etmdrvdata[] by modifying it on relevant CPU > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > Tested-by: Mike Leach > Suggested-by: Suzuki K Poulose > --- Reviewed-by: Suzuki K Poulose