mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Stefan Traby <stefan@hello-penguin.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: remove a redundancy in sysreg.h
Date: Tue, 20 Jun 2017 14:54:15 +0100	[thread overview]
Message-ID: <6d18962d-5557-1d57-95da-2ae1c437440b@arm.com> (raw)
In-Reply-To: <20170620133042.mlqgpx5vddgvoe6k@hello-penguin.com>

On 20/06/17 14:30, Stefan Traby wrote:
> This is really trivial; there is a dup
> (1 << 16) in the code
> 
> Signed-off-by: Stefan Traby <stefan@hello-penguin.com>
> ---
>  arch/arm64/include/asm/sysreg.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 2d3e155b185f..580965129fea 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -139,8 +139,8 @@
>  #define SCTLR_ELx_M	1
>  
>  #define SCTLR_EL2_RES1	((1 << 4)  | (1 << 5)  | (1 << 11) | (1 << 16) | \
> -			 (1 << 16) | (1 << 18) | (1 << 22) | (1 << 23) | \
> -			 (1 << 28) | (1 << 29))
> +			 (1 << 18) | (1 << 22) | (1 << 23) | (1 << 28) | \
> +			 (1 << 29))
>  
>  #define SCTLR_ELx_FLAGS	(SCTLR_ELx_M | SCTLR_ELx_A | SCTLR_ELx_C | \
>  			 SCTLR_ELx_SA | SCTLR_ELx_I)
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Catalin, Will: do you want to get that through arm64? Alternatively, I
get stash it in the KVM tree.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2017-06-20 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 13:30 Stefan Traby
2017-06-20 13:54 ` Marc Zyngier [this message]
2017-06-20 14:05   ` Will Deacon
2017-06-20 15:43     ` Will Deacon
2017-06-20 16:01       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d18962d-5557-1d57-95da-2ae1c437440b@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan@hello-penguin.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®