From: Guenter Roeck <linux@roeck-us.net>
To: Romain Porte <romain.porte@nokia.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pmbus: added possibility to change timeout for device update
Date: Thu, 2 Nov 2017 06:58:55 -0700 [thread overview]
Message-ID: <6d1bc013-52ef-ffd6-52c7-5dac6c8d1e9c@roeck-us.net> (raw)
In-Reply-To: <20171102113116.14791-1-romain.porte@nokia.com>
On 11/02/2017 04:31 AM, Romain Porte wrote:
> By default the time before really updating a device is hardcoded to one second
> in the pmbus_core.c file (HZ). This patch proposes a new configuration entry
> that allows to tune the timeout value before updating a device. It defaults
> to one second in order to stay compatible with the previous behavior, but can
> now be changed if needed.
>
> Performing faster than one second sensor reads in userspace is what motivates
> this patch.
>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
NACK, I'd rather drop the caching entirely, and possibly convert the driver to
regmap for caching non-volatile registers.
Guenter
> ---
> drivers/hwmon/pmbus/Kconfig | 15 +++++++++++++++
> drivers/hwmon/pmbus/pmbus_core.c | 5 ++++-
> 2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 40019325b517..5d865e3d0cb1 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -14,6 +14,21 @@ menuconfig PMBUS
>
> if PMBUS
>
> +config PMBUS_DEV_CACHE_MS
> + int "PMBus device read cache in milliseconds"
> + default 1000
> + help
> + This options allows you to control how much time should a device
> + be stored in cache before being updated. If you attempt to read
> + a sensor value from the device before this cache time is elapsed,
> + then you will get a cached value and the driver will not update
> + the device values.
> +
> + This option is using jiffies under the hood and thus is not very
> + precise. Setting this option to more than zero will perform a delay
> + of at least one jiffie. Setting this option to zero will lead to
> + no delay, thus forcing to perform an update on every read.
> +
> config SENSORS_PMBUS
> tristate "Generic PMBus devices"
> default y
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 302f0aef59de..2df0bc5a46f1 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -414,9 +414,12 @@ static struct pmbus_data *pmbus_update_device(struct device *dev)
> struct pmbus_data *data = i2c_get_clientdata(client);
> const struct pmbus_driver_info *info = data->info;
> struct pmbus_sensor *sensor;
> + unsigned long timeout;
>
> mutex_lock(&data->update_lock);
> - if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
> + timeout = data->last_updated +
> + (HZ * CONFIG_PMBUS_DEV_CACHE_MS + 999) / 1000;
> + if (time_after(jiffies, timeout) || !data->valid) {
> int i, j;
>
> for (i = 0; i < info->pages; i++) {
>
next prev parent reply other threads:[~2017-11-02 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:31 Romain Porte
2017-11-02 13:58 ` Guenter Roeck [this message]
2017-11-02 16:17 ` Romain Porte
2017-11-02 19:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1bc013-52ef-ffd6-52c7-5dac6c8d1e9c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.porte@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®