From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936351AbdKQVoa (ORCPT ); Fri, 17 Nov 2017 16:44:30 -0500 Received: from mga01.intel.com ([192.55.52.88]:11811 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936329AbdKQVoT (ORCPT ); Fri, 17 Nov 2017 16:44:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,411,1505804400"; d="scan'208";a="8911776" Subject: Re: [PATCH] dmaengine: ioat: Fix error handling path To: Christophe JAILLET , "Williams, Dan J" , "Koul, Vinod" , "bianpan2016@163.com" , "arvind.yadav.cs@gmail.com" , "kjlx@templeofstupid.com" , "geliangtang@gmail.com" Cc: "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" References: <20171117213753.21050-1-christophe.jaillet@wanadoo.fr> From: Dave Jiang Message-ID: <6d1e724c-bc0c-cef1-2ac1-616a36ed7a48@intel.com> Date: Fri, 17 Nov 2017 14:44:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171117213753.21050-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2017 02:37 PM, Christophe JAILLET wrote: > If the last test in 'ioat_dma_self_test()' fails, we must release all > the allocated resources and not just part of them. > > Signed-off-by: Christophe JAILLET Good catch! Thanks! Acked-by: Dave Jiang > --- > drivers/dma/ioat/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c > index 2f31d3d0caa6..7792a9186f9c 100644 > --- a/drivers/dma/ioat/init.c > +++ b/drivers/dma/ioat/init.c > @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma) > if (memcmp(src, dest, IOAT_TEST_SIZE)) { > dev_err(dev, "Self-test copy failed compare, disabling\n"); > err = -ENODEV; > - goto free_resources; > + goto unmap_dma; > } > > unmap_dma: >