From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4275D32AAC2 for ; Thu, 8 Jan 2026 08:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767861084; cv=fail; b=aJLpgSZuknYmblBnOJv7U4M5xtczIs08z12c4Fhv4GC1d5dwZJyKOU0j3WgUXThcAU6IL/TUQ2HzM/bnMYuG5KuTb5wtpUfpnGjYpvf+jO9wt+CiXrSbtqzmOw/XNsN6l5KQYnNDaWQf4193EW0nR/vNBN0i3MdeEWhridnBnPw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767861084; c=relaxed/simple; bh=Xk00/tCOfezyo1dX1kldbeouhGFi/PNbtldZp6hx1QQ=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=adO/rK27vlEdVqCnlXtqoPtrkclQ1tOmAtL7GvGHrx6XLeRH1mtOOkETNE8D+09Rc/WdWAYQN7R5VuOxNBqw+NcpKCZ3J4NG5mfBqTaLaCe+DJKAVCH7wvMijYXTsx4EpC7skdvgBFe6p9KcYTdl66sdhalyrF6G+/Js/6qzggM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NMBxEjnU; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NMBxEjnU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767861081; x=1799397081; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Xk00/tCOfezyo1dX1kldbeouhGFi/PNbtldZp6hx1QQ=; b=NMBxEjnUAH+/24Qw4FkkQO06VBPqkivKvddNBIrnMfOu8lqrWi+cB2ec AMhRWO2884vtAAqaRTmhJ4da4hEXdyAI2csvJH39EAnmEbWUpJU8W8iYW 9y7u5wZOzxWYz3RVfTFYd4/QaUy6b2LOGhU3k9H+m25qxqoh8aIwI596+ eKioocQ5mziNj3FyDVXE6t1N4a0xXkUMHtlaJzv0ig8IqcMEQZvlaUYuQ qiD1AeZ2l31P2Qcw+GPjdvy55DFwH06qxmUN7OTudiyiN1X3k9I4Y/RoV RmJwHYDkLUWEOfbmpYdbxe/BrNUCKpMPR/dIc4BF1e2Fbrk6MbsHeRJfm A==; X-CSE-ConnectionGUID: VT+Q3ic7TnqvXrpMjTS7zw== X-CSE-MsgGUID: Aec4Q8/oT+iMjT/vLWDSwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11664"; a="69148574" X-IronPort-AV: E=Sophos;i="6.21,210,1763452800"; d="scan'208";a="69148574" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 00:31:18 -0800 X-CSE-ConnectionGUID: mbPRdoglSHWO5+4MAHTo7Q== X-CSE-MsgGUID: 4euQhY4gTZuEE1ZIsswwEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,210,1763452800"; d="scan'208";a="208211544" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 00:31:18 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Jan 2026 00:31:17 -0800 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Thu, 8 Jan 2026 00:31:17 -0800 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.17) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Jan 2026 00:31:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Eze8CB4htBDdxpFV4nvePsRlDeiGa9gqJ5uhwqdTVH84vnP6nTnQdUx8VCiCSfKYp9uMEozOnveb3zQa/vqep8UQSGmlN214xEBCw/KznxBG84ALjpzjZgyZtECv4P2WvwZou1lssAV7rhqmgJUGyhy+S7v1BbOdX+679FF9T1CdANsMjqS9b6vE/9eqLY0sKP+dlenhynJSDkdVayw27RCRYNbzANokZYt1VpB+Czc5QRzl1FmUeZljuX8Mupnj/KPJh6rZ55Ckiz85B1QdTDoNe84gMrI8GkZe+vT6pZEOpkjKXs04YYiplKJdCwRBFgO/mWSR2cnuggnXViAe/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yv0eUydkaAXd0JTt6buRsuIguFIbwgwukrcDuJra6G0=; b=gikDBuiQJc2/3WpcReOrtW6ovY9rFBtOpondLYpFgr9SnncoxD3mm+F4eEePDJoD0OxYzIWQcz3jQ2JVxXmNWcfk+kPGRfBAzLMpNoVYv2p4WrAyc96cq0wXTt/wE9HSw2vSwdj3F52uk64Rx1iGwWcrUJq2K4UYAHpWvZaNmnpwigQjfIDN+bvxtb3Dv3CimWBOjtS1Z0KeiZYMx2k6vlCOAfMj7Wa+6SDbzFOeNQuVXnRs/fCnAqd138AQak1U1vnNgDaIzN8RSPq+8jrc4YvVdXgUdqciQn2fHX63QaP0OOhtnXFdvHhc/PIO0een5Dhbr9FWzLSCIzGw/+xDlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB8289.namprd11.prod.outlook.com (2603:10b6:303:1e8::9) by IA1PR11MB7678.namprd11.prod.outlook.com (2603:10b6:208:3f4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.2; Thu, 8 Jan 2026 08:31:14 +0000 Received: from MW4PR11MB8289.namprd11.prod.outlook.com ([fe80::d626:a4f8:c029:5022]) by MW4PR11MB8289.namprd11.prod.outlook.com ([fe80::d626:a4f8:c029:5022%6]) with mapi id 15.20.9499.002; Thu, 8 Jan 2026 08:31:14 +0000 Message-ID: <6d2cda3f-7fe1-4436-9760-fde0622e88ad@intel.com> Date: Thu, 8 Jan 2026 16:31:05 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] mm/memory hotplug/unplug: Optimize zone->contiguous update when changes pfn range To: "David Hildenbrand (Red Hat)" , Oscar Salvador , Mike Rapoport , Wei Yang CC: , Yong Hu , Nanhai Zou , Yuan Liu , Tim Chen , Qiuxu Zhuo , Yu C Chen , Pan Deng , Chen Zhang , References: <20251222145807.11351-1-tianyou.li@intel.com> <20251222145807.11351-3-tianyou.li@intel.com> Content-Language: en-US From: "Li, Tianyou" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: KUZPR02CA0017.apcprd02.prod.outlook.com (2603:1096:d10:31::8) To MW4PR11MB8289.namprd11.prod.outlook.com (2603:10b6:303:1e8::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB8289:EE_|IA1PR11MB7678:EE_ X-MS-Office365-Filtering-Correlation-Id: 81859a8d-628b-4f95-92b0-08de4e90494d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L2NRTEc4K0NEZWZGc2tXNVloYzUrS2dhQ2FmM1ovY1pvZ3lwbVpqVng4SzBU?= =?utf-8?B?bm8yUjdZNEt2aUhmaFJuaGJHRjR2L3dhOEtDL0wzRWVmTlFQMnVBZ1JQMHZp?= =?utf-8?B?NVo3RXV1ZG9xZ0VPZS9LN0xlK05JUXlVWWRtakM2K2loZnlBNWJWNGFJbDYw?= =?utf-8?B?KzhPRVdvb1dQcTZxa1ZtRi9LUHo4eFJNYVNEcFVVb1Era3JWQ2hFT2tIT2ZE?= =?utf-8?B?a1pCajVTWk1aNWpzUlIwZGdYMWZiMXg1R21FSFFCQkhLWEYyN2J6Vks3VktS?= =?utf-8?B?cWhQTktJWkd6eUtBTXR2TnFOaWY0Q0ROUGt5VGVqMFNzMHI1eXZmZ1JDSmph?= =?utf-8?B?blJXUy9ldDBmUCtxa1FnUDlDTFNqNzhaNXE1Yy83REQ3SHRyQXd5bnFldXBj?= =?utf-8?B?d2hQU0diTWQvQTlVUkZIQlpzQVNZT3grMSs2eVh1NDhqTXlmaWdJRXpXNnN6?= =?utf-8?B?MVA1SXZZenlhc2dRYUViRm1yMGdBQkVnczNkY2UyeUtoZno2L3pFU1ROeTdD?= =?utf-8?B?RlhDcERKNkxjb0pEb3NFY3BINTlkVElLSkQwQkplSm1DOUhpcTVxU3VTdXdW?= =?utf-8?B?bE83bUozZlJWTUk4dW1zQVNwMlFqSzM0MEh1ZFNvNzNRTEkvdlBJR01pL0pO?= =?utf-8?B?Sml2dzlmMTdJUjU0YUE1TjNkdjcvVXBrTllyQmR4R05IT1Y5Zm5iZk13MGpP?= =?utf-8?B?STdYcXlXQVJ2ZXNwTk8yMmZiQWdqd2RFZG14MUZOZ0VJODZvd2tCTUIvZERX?= =?utf-8?B?WW91bWtpWUQrT2hXTG5tYUZEVCttQ3pQUzZrVlRqamdDL2JMamg3bnZRUTRJ?= =?utf-8?B?Wnk0d29ITkJPajZzNi9IUTN1Q25tVjlLQU5uRE8rMmtvTDlCMmhmbG1FeEdS?= =?utf-8?B?TWROTXFyM0E4VThWQjFLT0x4RXNpNURra1M5ZVVlcm03Rk0wemtEc0g3TzNi?= =?utf-8?B?bWwwTU9YWXB3NmJxaUVpWk5YM29IVE5ReUwvb2loU3ovdGV4NnlNTHJCRGlX?= =?utf-8?B?M2JmZ1lSNkhmdjhDYStJS3VvUUdMQmlBa1pBcHlMbzZBWVVXOHdZaEVQNU54?= =?utf-8?B?WUZSMkRtbnUyUlBCUHVFQW9GRWZRbWRyRkN2a0NENmtwU0R1cXBOWDB0S2hD?= =?utf-8?B?djViWFc0MFlXbC9Ia3o3S3ROTE9GMWxNTGxEQmppVGM3enRXdndtei82SkJK?= =?utf-8?B?RDZwTllUQnFMay9hR25pbk5FOHh2eU9WU29BKzg1Uzk5ejJUdERpV3Q2MzdP?= =?utf-8?B?aHRpb3ViWUsvQlpRRnJaSWZTYklscnRkNFpkdy9KRjQydzlyVTM2U2gzQnV3?= =?utf-8?B?UG14MW1BY2h3U3RkdWNGR3JKd2o3OEcxQjd4Rm9PRmpKU0N1bGJUaHh4VTBU?= =?utf-8?B?RmRmRXQyc0sxLy9XRzVPdWpON285UURIbGNESE9nT3JQV3Y2cFdKOHMyd1ly?= =?utf-8?B?eFppVzExcGJJQ0pqeSs4SlgxVnRYUkdVSkZvZ2NRZHRoRkpSaHFHMmd1aG1C?= =?utf-8?B?NG4vR0REVVVzV1BIaWFOSFFkK3lXS0JlN1YzKy8rVG1LSmw2N2tUdTR5dThu?= =?utf-8?B?c2wwYUN3dlZPK3NFenZMWHdKMHd6UmZPRnpLK2Vody9PTXUzQ3B1TVd3RVdZ?= =?utf-8?B?Z3Y1YWwvbjZ0N2xnT1VaZGtjOWNKdHJNcU9pSVBCdHhCTGlNcWpJL3U2ZUdH?= =?utf-8?B?dEtzS05TcDNSeGYxZ0JhM1RCUGZkWmdQQ2RITVA5M01YQ3o4Z2ZNSUxOaDRX?= =?utf-8?B?c0tGUXFrOFYvRk1rTXBMTk9NS3pFZWtQYzRmajJ3MGV4cklHUFkrNE8ycDY3?= =?utf-8?B?RmhQWEJOVVJnVHZ1bVdnOU9QL3RHRDFTZW1PL0VXTy9XVG1POGE3MVBMdnNh?= =?utf-8?B?YXdUeTloQUpJUFA5NWRoOTJWRWhlSUlpTWRKY1J2eDZvaDQwQlRXT2tsdXNp?= =?utf-8?Q?PdcCTZ6IPyVQvqsQA1XueE2e+ewuSRtk?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB8289.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEp3S3F2TGhzRzZubmppV24yb1hGdldLOXAwNTJJQk1iUW1UR1JtcVFvOEEz?= =?utf-8?B?RTVFNWVnRjlQVkpUcG9OMGd6LzZab2RWOC9BeXNSRk9ScjlxalIzb1poU0tM?= =?utf-8?B?WmdxSWNHc0ZUck0wZGZrbFZFZ2NhT2k1TFFWT3hmTHVTdGpGYkpoYUk2SVB3?= =?utf-8?B?ZngzT1pjemI1R0xsVm5nMmU3bHFsUU9SaXYrVS9UTTd5Zmw2a29ERU52ZE9X?= =?utf-8?B?c1krYVVDODIydzJ4dE1ueWFXcjR2cTRkWXVjYlQ0Uk9KSVRnTFJORkJLOWRK?= =?utf-8?B?V2N6RWpvb0dKRG44NW1YMFVQaWtqT201M3V2ZkxvSHhGWWFCVDc4V1ZWU2s2?= =?utf-8?B?RGRaUFlCZ2ZZL2RWYlYxdjhTNkdKSW50TFV6YUpISDJJM2JDZEV0NjVaZlNr?= =?utf-8?B?ZkpubGR4NURPbWk5bTEvYVA0YlE3aVR3SEgzSW4vWCtyTWRQS0UxR0pydDVw?= =?utf-8?B?cXloeXpLUTJObVJPYUhBYmx5VFR4QWQxYUIxVVc3OVhzTVVIbDFHVW01d3pj?= =?utf-8?B?bzZkM1VhRTJUVWxJMGduT292MEszUFBIbUV4NjNTUWF2RWJjZVB4cWN6SUMz?= =?utf-8?B?YlNWZlA5bmQrdzFJT1hHejNtSSt0TjlqT29GT09pam5rWi9tRmtTeS9iT2px?= =?utf-8?B?K01EVmVCK0ptM1J4ODJxNVhDdDBWTXFLcGpDeWVkVUNRN0hReitOdFczMnF4?= =?utf-8?B?a3FoRzRnR0NXenkrVlJhbHVrM3VuTzZHY0FTSWorR0JFbXhTZ1pDWUlIUnZT?= =?utf-8?B?ZDlnRnVNdzRsZlluckwvenFGb1ZMNmdFamFQL29vWkpnai84M3hYbkpVY1pV?= =?utf-8?B?RDFwMldYbkZOaTJ0WHBsRmlrdTRoSElWUWwwRVBqRUx6dUNzbVVCV1pzNlVG?= =?utf-8?B?UDc2bXdycEc0NlBXQ3lSMktLVjYyMGUwS1YzK0lpR2N4OTFNSmpQWnlCRWdG?= =?utf-8?B?M2kvTktOaElFMG5YSng3M0lLZ1B4V2ovTHY1c2UxZmhSaTFsWW9TdDU5L1Vh?= =?utf-8?B?RHdvdTNGNytvSUZUMFQrSHJvdTVZdU82MUpCU0lUZ0RBM3duL2VPakxtUk5t?= =?utf-8?B?SldoRXEvVnBxNzdHZTVxVWFib0FzY1JoWmNuZEpiVGpRekwrOXJxWFFzQjhU?= =?utf-8?B?UjhMaGd4RkpRUWJEcjNIRWJ0UlFHN2Qxdzhtb3dXMmJyaCthV2kzbkdGdzFK?= =?utf-8?B?K0syNklHbzcwelBNeVdUVFpCOWdrSExEcHZ3R2UwOVA4VVRTTGg1cm5BOTVz?= =?utf-8?B?dzFwNzRoVyswdTRCME0zeHliUDhRVDd3STdaTDVRK083MXlINjFQTDc1WitC?= =?utf-8?B?N2lXSldzMDhqeWM2NFpyR0RseEk3bzhUK21PVlFiaGhLWDhXbzZ2cDVSdXFx?= =?utf-8?B?L2NnaUU1T3gzTTlET3R5b3BySGJvT1lxRW1FREZSSkVlb0RVRTF2T3hrQUlH?= =?utf-8?B?cVFXVy9mNGFQODJ0aHBDeFBYTjNSUFhGQ1pJbjRrN1VmUzBiQ1dSZ0h5blBT?= =?utf-8?B?Y3FTU0l6dVlXUkFyL2c1c0Zubkw3LzJ6S2lURGZ0WUhEMzNneTN4VkhRYlh3?= =?utf-8?B?Tnh0dDQ3ZCtMSlJtbmlRRWRjMkFBd3Vid0FJM0JTQWhvMEFiS2JmWXEvQnFM?= =?utf-8?B?Uk9Cci9CTDVTTlRKNnFXZDQ5WnJsaVFrUWpGQkNpWGJxdXVZM3k0WlJ6cnhy?= =?utf-8?B?N005a1BIRyt3S2Q3TlBUQXJnTWRyeWV3TncrSUU5VTJWNTJ3eTNSWlNOdGxo?= =?utf-8?B?T0htakF1ckFsTWQxaU9yR205dXdDRXFYUjF2V0xBeFN6VmhZYVA1YUhLemNw?= =?utf-8?B?MThlZktyTmRleVBwbjc4T3BsMld5c2hvcmNFSGRET0xCMTJZdkNBSXkwU1lV?= =?utf-8?B?Q1h5R010Sm9tU29xUnQ2M3RGNEp4YWRvTDRXNm85ejN6VlpIMlZCWlJpSGpo?= =?utf-8?B?VkVzdXozNDhnNGJ1c0VFNlo0VzdLc1RLYm9nMlFJYWpwTi9ETUU1VFV0MnJw?= =?utf-8?B?MW5vL3kzaWc2Mit3K2hMbzkyOWIyakM2dG9HVDdMNllXd0R4UEx0d0FHKytj?= =?utf-8?B?di9jWUt2NnlpZDRRb0ZpR1Nzbm5kVnRERURrVHdsVlFReHVQYWpWcG5hTmtT?= =?utf-8?B?RkFoQzYwdWdnMnNueXVhL0pRQlpJdjVWMTlIM05CVzZWRi9Cd2Nib1hNUlZE?= =?utf-8?B?L3RVSklxRzFlY3BPNFp6dGRGb1o1ai9Fc0pqei8rNCsrb0NPUmRLSlVsK0dr?= =?utf-8?B?Q0x2NUtSQkkwMWd3RkliWWo2K2dSWVByVis3SEFZZ2MyYm1WTGlhSmRrZkl1?= =?utf-8?B?WXYwVTdGSmRVK1VIVG9EUDd3dVA4UStFdVAvd3k5Rm03YmFSbFZ0UT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 81859a8d-628b-4f95-92b0-08de4e90494d X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB8289.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2026 08:31:14.7758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sNztjaccsvAIxSk4ET/Duum2bTPI55Ed2LUejBddT18i/mEL3VpE3iIFqQ3lo68F3fyXrL/mdgt2EanfNtAVZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7678 X-OriginatorOrg: intel.com On 1/7/2026 4:25 AM, David Hildenbrand (Red Hat) wrote: > > One more thing, the fact that the clear_zone_contiguous() happens in > move_pfn_range_to_zone() is a bit suboptimal. > > Maybe we need a comment here like > > /* >  * Calculate the new zone contig state before move_pfn_range_to_zone() >  * sets the zone temporarily to non-contiguous. >  */ > > Or something like that. > Will change accordingly. Thanks. > Alternatively, we have to rework the code a bit that this dependency > is a bit clearer. Agreed, probably we can have this optimization first then explore a more explicit approach for the zone contiguous state management. > >> +    new_contiguous_state = zone_contig_state_after_growing(zone, >> pfn, nr_pages); >>         /* associate pfn range with the zone */ >>       move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_MOVABLE, >> @@ -1204,7 +1273,7 @@ int online_pages(unsigned long pfn, unsigned >> long nr_pages, >>       } >>         online_pages_range(pfn, nr_pages); >> -    set_zone_contiguous(zone); >> +    set_zone_contiguous(zone, new_contiguous_state); >>       adjust_present_page_count(pfn_to_page(pfn), group, nr_pages); > Regards, Tianyou