From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A2AC04A95 for ; Sat, 22 Oct 2022 17:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbiJVRaF (ORCPT ); Sat, 22 Oct 2022 13:30:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiJVRaC (ORCPT ); Sat, 22 Oct 2022 13:30:02 -0400 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8902F3B445; Sat, 22 Oct 2022 10:29:59 -0700 (PDT) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 23 Oct 2022 02:29:58 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 61C8320584CE; Sun, 23 Oct 2022 02:29:58 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Sun, 23 Oct 2022 02:29:58 +0900 Received: from [10.212.158.208] (unknown [10.212.158.208]) by kinkan2.css.socionext.com (Postfix) with ESMTP id DCF4FB62A4; Sun, 23 Oct 2022 02:29:57 +0900 (JST) Subject: Re: [PATCH net] net: ethernet: ave: Remove duplicate suspend/resume calls for phy To: Heiner Kallweit , Andrew Lunn , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221021174552.6828-1-hayashi.kunihiko@socionext.com> <2333ef88-6e3e-a5ad-dcdc-89a405ba2f9e@gmail.com> From: Kunihiko Hayashi Message-ID: <6d2e3944-68f0-1443-b017-13d66650e17a@socionext.com> Date: Sun, 23 Oct 2022 02:29:57 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2333ef88-6e3e-a5ad-dcdc-89a405ba2f9e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2022/10/22 5:55, Heiner Kallweit wrote: > On 21.10.2022 19:45, Kunihiko Hayashi wrote: >> Since AVE has its own suspend/resume functions, there is no need to call >> mdio_bus suspend/resume functions. Set phydev->mac_managed_pm to true >> to avoid the calls. >> > The commit description doesn't make clear (any longer) what the issue > is that you're fixing. You should mention the WARN_ON() dump here > like in your first attempt. Indeed, I forgot to mention the WARN_ON() dump issue. >> In addition, ave_open() executes __phy_resume() via phy_start() in >> ave_resume(), so no need to call phy_resume() explicitly. Remove it. >> > This sounds like an improvement, being independent of the actual fix. > The preferred approach would be: > - submit the fix to net > - submit the improvement in a separate patch to net-next Ah, I see. The one is for fixing WARN_ON() dump, and the other isn't affected by the behavior, but it should be duplicate removal. I'll separate it into two patches. Thank you, --- Best Regards Kunihiko Hayashi