mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: scsi_debug: fix one-partition tape setup bounds
Date: Thu, 04 Jun 2026 09:38:31 -0400	[thread overview]
Message-ID: <6d2e78e6a5840f5892e7eb081657b23aa62bc50d.camel@HansenPartnership.com> (raw)
In-Reply-To: <20260603235616.124535-1-sam.moelius@trailofbits.com>

On Wed, 2026-06-03 at 23:55 +0000, Samuel Moelius wrote:
> The tape setup path writes partition metadata one element past the
> allocated tape_blocks array when a one-partition configuration is
> selected.
> 
> That corrupts adjacent state during device initialization before any
> command is issued.

I still don't get what the actual problem is.  For a single partition
tape I can't see where scsi_debug would actually do anything with
tape_blocks[1].  What is it that you're seeing when using scsi_debug
that motivates this?

Regards,

James


  reply	other threads:[~2026-06-04 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 23:55 Samuel Moelius
2026-06-04 13:38 ` James Bottomley [this message]
2026-06-04 14:52   ` "Kai Mäkisara (Kolumbus)"
2026-06-04 16:16     ` "Kai Mäkisara (Kolumbus)"
2026-06-04 18:33   ` Samuel Moelius
2026-06-04 19:14     ` "Kai Mäkisara (Kolumbus)"
2026-06-04 19:29       ` James Bottomley
2026-06-04 19:41         ` "Kai Mäkisara (Kolumbus)"
2026-06-04 23:47         ` Samuel Moelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d2e78e6a5840f5892e7eb081657b23aa62bc50d.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sam.moelius@trailofbits.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®