From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Jakub Kicinski <kuba@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
Date: Sat, 25 Mar 2023 23:27:25 +0300 [thread overview]
Message-ID: <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru> (raw)
In-Reply-To: <20230323094034.5b021c65@kernel.org>
On 3/23/23 7:40 PM, Jakub Kicinski wrote:
[...]
>> Is there some protection against parallel execution of ndo_open()
>> and get_stats()?
>
> Nope - one is under rtnl_lock, the other under just RCU, IIRC.
> So this patch just makes the race worse, but it was already
> racy before.
How about reverting it then?
MBR, Sergey
next prev parent reply other threads:[~2023-03-25 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 6:58 Wolfram Sang
2023-03-21 8:22 ` Leon Romanovsky
2023-03-21 14:33 ` Geert Uytterhoeven
2023-03-21 16:58 ` Florian Fainelli
2023-03-22 12:30 ` patchwork-bot+netdevbpf
2023-03-22 20:57 ` Sergey Shtylyov
2023-03-22 20:54 ` Sergey Shtylyov
2023-03-23 8:32 ` Geert Uytterhoeven
2023-03-23 16:40 ` Jakub Kicinski
2023-03-25 20:27 ` Sergey Shtylyov [this message]
2023-03-27 8:14 ` Wolfram Sang
2023-03-25 20:56 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®