From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9DE92F30 for ; Thu, 6 Aug 2026 21:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786052419; cv=none; b=f6lBOIR8pg9pm8jWRfWHlCFU571QroucrHldRa5XKIMD6T32TLm/CV9TWnaSNcuxv/61Y38WiaZ3THMD+V2XTXi/9+wZqTqQCX2OKYEQHD9VAd/9KPH71C4v0c2AbAeIKZiJRRfb4BovvWcbnre2ndrF678w49ITAziFWGgdJl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786052419; c=relaxed/simple; bh=cjsbCX9eJ88XtHfMp7TGiVsTzMGUWY5MXjYbpKtT6kI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gGXdBPmT3Jq0bG7CTT8FIUeH7YGT0jcQf3gKD3z4Xdqcw8eOMJZSD0e0kbrbjHDmEyHaB5HIi1UeSS2uRiqec4trjmNcuVPIbzuUprgwgIxjVVzGbXlu0XWNkFax9x+bOxRi7tlXpfyYkHe5DUBXWYu0ftAVldZjr8GUzOTISfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I3wTZXRc; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I3wTZXRc" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84830c774a0so2893005b3a.1 for ; Thu, 06 Aug 2026 14:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786052417; x=1786657217; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=SGZ57YsrCOkfhFnHb/TTHUwfSFARfj9zNgoNA+IWBJs=; b=I3wTZXRcKZumAfv9Xpz3bnwd+fAFQAg8uN6ubMESRVVso25mJx2F0MbYgvFbdPp/7r +EhZEa21XmPTFi5AuLlB4MBfbHHAVrbRinPhWBxqea1ZXVsusjCSSizDd6zNeLV492dc X00Z4XCUpU9i8P90TG0SMfzKkRkutDAK4ZT/DE0lLpeQS4vrp47RVW59l0tLoFcEAqNF b984DpxlAQyxb7nqZBRwZzej0kwDELOYQG3jMqinFEVZyCYPFKmP1O/+N9PSLNat0rg5 mOASXcx7LGjHW4bUoRG7u3chqO09zJ5jKIhjHwBC8doNR/aeX/ni9/upyM4RTMXwogj4 h4ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786052417; x=1786657217; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SGZ57YsrCOkfhFnHb/TTHUwfSFARfj9zNgoNA+IWBJs=; b=TtE+UpFva6nY4U3baAxfr61+dWEOnKa/QN/AIoAtiqQXjprg9e6ot7CQt0v1wBAoJr mHHanVSZmG8aGMNu4xl4LhkM+Eeap41Gzf1bbneaKj1MKH3FBXzO5DJicGXb0jNQfJ4z 7/379JGg8yLd1l7ku/cvPeeZsrTLluSnEqC/EOUzfMpETogbNIZC3COGTQV8zeqfRyeE AwgiNraDXVhRQ57JMaSHR4OpZrXWSEvS8IFdymfGm7+OTjJnUmkqPE4c4nW+GfYeBzfe Vu1z0KMWc6SrfgDYQgcI7czBZmjX/CPrzC7EE82WBezW3earMq9b3zbmFjjoVfcpoJ9/ hw6g== X-Forwarded-Encrypted: i=1; AHgh+Roc/ldgqTR2uxla2/1dlcVARlREQEbu5tUi+g9KzybvifiQ50Ya5ixe85UOcZ3+H6NdUidZNFkAMjghxAE=@vger.kernel.org X-Gm-Message-State: AOJu0YzPo7rVYpXh3sxYhkmawjflPQU2UwxEV5C4hAvFfTQKjObYZWOO EzXo2CiEOvzNBm82t99gJpf5gNcievreY27PVYk6TzuJMGSo0g8if/3r X-Gm-Gg: AR+sD129k1lDasFF00l4AA+t122SyQ8MU1HISXhFxT01pzB+wASrQa//9hXFmOnzC8o 3mD1tMzOZDXP/H0wBROSVlCvCbuZznt9ztbTmNjiR+Yy1R7yxLavPto8DQEDE0OvPSQlXvjTura 3m1UJoZKNviKewhgMMZQGHqn1qMO0yBqWCYezRcVbULsSfZfGo5j7erXcvlm/yMkQwKAQTu2XbF Y9iJ6BZPpf8iZR1ebcLOo+Dxo7RigetgmyYDTgBEBvkJcneUJV35JdduQ+lCLFnghUHSpok+IJX YCjBJkNR3clRmGNXHk5wkAbMNDAkGI4SdYTHXF4mt5j6OvYRhe1ocgE4eCY1iCha0MBbUmV+KQn xwRSBIiW+fXU/e+6cbQDRFWNqjFDMiHJLpaciTwD4q+NhHtu5rR1teEOrbJFx5qChnlZBjF4smd gaQ4N8ShxwwZYtE3oRvlW8ULWOR6o49nuKtT/OEHRJYR0ohmYbAZPJbi3qFxUB49lmHLPiij0ty f5f/vFXJwaD X-Received: by 2002:a05:6a00:b806:b0:847:e2c7:59b6 with SMTP id d2e1a72fcca58-84f2e031181mr20741708b3a.11.1786052416878; Thu, 06 Aug 2026 14:40:16 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe8bb48b5esm7068a12.14.2026.08.06.14.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 14:40:16 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 6 Aug 2026 14:40:14 -0700 From: Guenter Roeck To: Mayank Rungta Cc: Andrew Morton , Wim Van Sebroeck , Tzung-Bi Shih , Douglas Anderson , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 1/2] nmi: Export CPU backtrace APIs for loadable modules Message-ID: <6d32cd2e-9fff-436b-8410-c35aa24c5695@roeck-us.net> References: <20260730-export-cpu-backtrace-apis-v1-0-bace8e1cb817@google.com> <20260730-export-cpu-backtrace-apis-v1-1-bace8e1cb817@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730-export-cpu-backtrace-apis-v1-1-bace8e1cb817@google.com> On Thu, Jul 30, 2026 at 03:00:21PM -0700, Mayank Rungta wrote: > From: Mayank Rungta > > Currently, CPU backtrace functions cannot be called from loadable > modules because the underlying helper arch_trigger_cpumask_backtrace() > is not exported. > > Instead of exporting arch_trigger_cpumask_backtrace() individually > across every supported architecture, introduce and export a common > helper, cpumask_backtrace(), in lib/nmi_backtrace.c. Update the four > inline CPU backtrace macros in include/linux/nmi.h to route through this > centralized helper. > > Signed-off-by: Mayank Rungta > Reviewed-by: Douglas Anderson Just to give an update: I'd love to apply this and the next patch of the series, but I can not do wo without formal Ack from a maintainer (I did that once and got burned for it, so it won't happen again). I'll send an Ack to the next patch of the series, in case someone else wants to pick it up. Guenter