From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B1342668B for ; Mon, 20 Jul 2026 14:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556049; cv=none; b=uPoUeDbvcsujyouRLaM8ksPVt2Hmb5dB/GLPVER5SDErf970h6ia6yrm18yrH+QCOu8qMmzgBn+9R5rCKadUHrBph5HONc1xPigLa9OAVJyr3pMWuixXq3nzJUdaTgW3rMCDDEd9WxQA0+9+ka2HjyMFjUCJ6NVtl3O1dgtYQz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556049; c=relaxed/simple; bh=oBMb12/jBWSOUvFZOYBVI8AV7upjkyjqsD/frlDb26A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UW6ydsJYQVzSiQfp+NEc3J5R7+FA2bspSD10J80bViVf95RNu1H986Ci/x/mbKjYQ8rzHy5BwJdxlpRKmqMU4GKA6UXxmTnnDK5gJfltNGpsAdRB9GeJOH1GbujP4/9BOVo5bVDcNtvZZIkKHlzyyfyYDU8/8gzPQLNFoTopJB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EU6TpSs8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kHXxnJ5h; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EU6TpSs8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kHXxnJ5h" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqwEF2852842 for ; Mon, 20 Jul 2026 14:00:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0k366VfeOAZj7ASsgZuqs3BZ1DxSbGgGfa+ewz7+L+4=; b=EU6TpSs8zU/dcfla OPJ6bbP9TUkk/NOy7EMSy1XhXdTsue8kk1IdFnr58rG8n6uOr4g7W0+hFSLmPg9E kzZirMVV5PIkmx3NIhhJWsEu+08c4Do7BH56KaRbjZCeyjD2NLaXE898onRvRk/h igAAclV9CLNvbllpGfI/2SCWb+a+6eAyZ6ZM1oETTS5ZY/rmdboq90yUhuVUECC4 tTNgT4BA0URq5Rm5It/i9yzZNVmrbYg9zR/YXvs3071j8T580rIe8L0vIH3LwfHZ Zd4gy3BwNEedWQA1jlsrnZjex7t1TUeCM9FfywvyMM/ij3qLF91keE9As1j5PsCr 9W7MHg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhhgyryts-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:00:46 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c15c77619so21928771cf.1 for ; Mon, 20 Jul 2026 07:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784556046; x=1785160846; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0k366VfeOAZj7ASsgZuqs3BZ1DxSbGgGfa+ewz7+L+4=; b=kHXxnJ5h/prbePkLOEiRY75da9wqd+fDzd4j8i7kwcsPXrQ0HXj3ZlZrFH01XhVXPQ oMwQvk2xLb8glVN8+HOs1l6GUVDC6+ttV22hKY4bCiPC08jru0JleV4G9T3cYlac0QO/ gXky3u2ftJQ464WRXPtyh14kum69tXdtCP06IH+vVr35IPgV0QQttF4PFJJT5zfBcyB9 znUmujvJ9AyGWxY4+6SHqP9Fqi6wBfkJ3en+yq5LVW9Z+R2WLod7qpx6g7NSN6OTSczX Ool2mOLENEWXWjQb+QeuLcvdbZV4QzPP2pc8U6N/BYdWhNTtTjUeNl61uLQ0X2iGoQKw u4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784556046; x=1785160846; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0k366VfeOAZj7ASsgZuqs3BZ1DxSbGgGfa+ewz7+L+4=; b=nJFg/TL2ZWH+3229kdYbkvoXs3vLmWiBAymGAA037Pt2YYprOopvlGZNKSl5dxcIYV f+vlVQ/adPp+hNJGyNUo84+6m+ZOg4rOyXcnXuqQ17OupNNEON4RfabnM/J0S7YI+1MQ tvVyLX32QwkekUD/+njoLss1DsbB25coLgM57S9dDphxWcEAn5uGdBcmI4IyKXLSG8sW OJQNqdGQH6A3QhsZKZpgHlo7UkMFohYRcSe64IlstAHN3bOhFET3j46e3NLhJpLY/nLA 2QfqYm+GaYY9We6VyXkg6NOSZy5YoTSwfrrc7NupHQ/Ud3SnEtuEMUHVgnjoepjFp4b2 QuzA== X-Forwarded-Encrypted: i=1; AHgh+RrmTUGzJIQ07B5ohvowqIavMYJSGeDR+3VE2LfwEkGLHq7FSJiMWawTOZl/VazvJ4NSIbkXghKPuxTRoIY=@vger.kernel.org X-Gm-Message-State: AOJu0YwVzewaIatuJ1+4PAB3r7rjhgDzLgMPF6hon2winYdFILaWsIiT H8p3YP0ExY3aBmi6yslBxQfhM5mzW6u5ijfCGU8v88f2JcoOcgE3YG5aXI0vzB0JPw5pRRK4G57 o5M88+GxMDnt7FR7zieHIvfF93WZ+8z41t+VaqZ/NakIMZgartw90+VCuMLSrdACpv90= X-Gm-Gg: AfdE7ckL49evSbDXtw9uSBjYhIYzpfWTqI7suNfF4MYj3I8ng+JwILY3pgANAzArdZa eBgM+0KQB7c3SHHGQzSTAuHvUaDrowHVREF56g/ZMS55rQpfYXNB9ULPHRbjlSTrbkNtseHc5nV iXjGLEs3gsFtzTjAxYw6DBHsjLehwqjEhp8FkP/5SYtwJv5wilHrJvzjRX6aqUf2bURVYwnvCk5 ZLp824Dfatl/vkl9bkAvgkx3R+8pCHQkhv3x7/l0tfXR3lGeD7ZB9NeCyQM8vLBhh/6fLlBf0MW 9VO9i5CUk+Rjj9KVN73XwEUJ50LPxm7Fzuf0QcPT/9g4yiFC44d4J1ONnTnXIar4v0C3nVGABwR P4MwOyU8ZKmsfKrHtIyekOo69 X-Received: by 2002:a05:622a:148:b0:51a:8945:312d with SMTP id d75a77b69052e-525f5d98602mr8068391cf.0.1784556046000; Mon, 20 Jul 2026 07:00:46 -0700 (PDT) X-Received: by 2002:a05:622a:148:b0:51a:8945:312d with SMTP id d75a77b69052e-525f5d98602mr8060731cf.0.1784556040194; Mon, 20 Jul 2026 07:00:40 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c170591172esm479090266b.15.2026.07.20.07.00.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 07:00:39 -0700 (PDT) Message-ID: <6d3ef3fa-d7ee-4963-9c18-32c7605b762e@oss.qualcomm.com> Date: Mon, 20 Jul 2026 16:00:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] rpmsg: glink: smem: Use device name as IRQ name To: Chunkai Deng , Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com, tony.truong@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com References: <20260720-rpmsg-improvements-v3-0-e7b6070186bd@oss.qualcomm.com> <20260720-rpmsg-improvements-v3-1-e7b6070186bd@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260720-rpmsg-improvements-v3-1-e7b6070186bd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE1NSBTYWx0ZWRfXxt7Zmsgc8pNu CQ9Ro785XhzesxEjWCvkt68TFbtTwUjdMcWO3dWk7efIqKG7PZ/p2isOjStKTy9jOqox19DzGtI K/FLMdQqeV8Mwc4sjVyYu1/TNzZjXo0= X-Authority-Analysis: v=2.4 cv=LK9WhpW9 c=1 sm=1 tr=0 ts=6a5e2a0e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=M4aA-yYNIiwQogNIN3IA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: u60Iaj4aEtD_XL-Jcxdw6ocDG7UIBObz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE1NSBTYWx0ZWRfX+CAVcW9yRKh7 lK/Qep0nJxMbGY34PDVyPGMl+IMwVz/dT0nO2JD2kPlp/dhy+ZF2ZJPxrvK8iH/jIl1mK3sEfU/ A/4KYRoglniG9CjBtTE9cYjS05NWtxaIgVXUkro94WaaPK2w5AqkAUWxflDLh6dJh39pam4BLUv Swogmycs+Z3gKuLh0axaLCUnvNMRNNQWp7pg9XasDZR5yfMX+oShMknVWAwcHUib6axnHKmg7oA qX4mBMqZhf4HML0C2F5WboPXAuy7f7P3Qi+XE348LdTI7aCWphgJnStV+kcpTUP2byku4G98i+U RFqetsdFWAViyexXvDBm9ehnwpfm+IjJKIdJYOGIgoFhMjdvfgOHp/CZtAbuIj6YH9TN38kr8+8 urv6CbmGPDLHMpKO04moAZnsCNvEHEUOeIya74HabQvmWeFF0E8e5epLtZMez76K1tNIdijuc1w Zb3aDAtBSX5RxUuxmfA== X-Proofpoint-GUID: u60Iaj4aEtD_XL-Jcxdw6ocDG7UIBObz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200155 On 7/20/26 3:25 PM, Chunkai Deng wrote: > A SoC typically has multiple remoteprocs (ADSP, MPSS, CDSP, etc.), each > registering its own SMEM GLINK instance. With the static name "glink-smem" > all instances appear identically in /proc/interrupts, making it impossible > to associate an IRQ with a specific remote processor. > > Pass dev_name(&smem->dev) to devm_request_irq() instead. The device name > is already set to ":" which uniquely identifies each > instance without requiring an additional field in the driver struct. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Chunkai Deng > --- Reviewed-by: Konrad Dybcio Konrad