From: "André Draszik" <andre.draszik@linaro.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Pritam Manohar Sutar <pritam.sutar@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Johan Hovold <johan@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: samsung: usbdrd: propagate GS101 PIPE3 lock failures
Date: Mon, 14 Sep 2026 17:01:36 +0100 [thread overview]
Message-ID: <6d3fd2d27eb54a926486da34947e843c0f29253c.camel@linaro.org> (raw)
In-Reply-To: <20260623135349.42739-1-pengpeng@iscas.ac.cn>
On Tue, 2026-06-23 at 21:53 +0800, Pengpeng Hou wrote:
> The GS101 PIPE3 initialization checks the PMA PLL lock and then checks
> the CDR lock. The PLL helper returns an error, but the GS101 PIPE3 init
> path dropped that result. The CDR helper only logged a timeout. PHY
> initialization could therefore still return success after either the PLL
> or the selected receive lane had not locked.
>
> Make the in-file SoC-specific phy_init hook return an int so helpers
> with real failure results can propagate them through the existing PHY
> init paths. Keep the register-only helpers returning success and use the
> new return path to report the GS101 CDR wait failure. Other SoC helper
> paths keep their previous success behavior.
>
> Fixes: 32267c29bc7d ("phy: exynos5-usbdrd: support Exynos USBDRD 3.1 combo phy (HS & SS)")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 78 ++++++++++++++++-------
> 1 file changed, 55 insertions(+), 23 deletions(-)
Reviewed-by: André Draszik <andre.draszik@linaro.org>
prev parent reply other threads:[~2026-09-14 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 13:53 Pengpeng Hou
2026-09-09 8:06 ` Manivannan Sadhasivam
2026-09-09 8:09 ` Manivannan Sadhasivam
2026-09-13 10:56 ` Vinod Koul
2026-09-14 16:01 ` André Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d3fd2d27eb54a926486da34947e843c0f29253c.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=johan@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pengpeng@iscas.ac.cn \
--cc=peter.griffin@linaro.org \
--cc=pritam.sutar@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®