From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56EA95464F for ; Sat, 27 Dec 2025 18:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766859657; cv=none; b=E0AgwJcXbK3rhKl28CnHFRXnFgvdiZw7JaVii7EhVZbz/Wg0OLyGQbhZovbetr5NxM4NX7hOsMqRSH8nYP+N2tyPz8fvq0zLPIGMhnIfFWs7QzlqGrW3cDzp7n9iRlf1Am0tH4n6b+nqv7KohEKoKyWOVPtB8it5FBmCm4oWMQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766859657; c=relaxed/simple; bh=+CbJpq+tdkgrbaPm9dRNavpRXrube0jjJxJrm5A9Mnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eFn6UfTqhNaJQlwNvaY5V7QZvPjcqOUtDUpiMjVQ3pmc36g2F9wIgrvCEqFtJyWPGgPL8f4L9YewMvfR9I+sK5lnvvZ7aWIrWuhlv14hvosobTbe3m8MbQi9BvXTgwSmvdlnWHqD23jVbC5tUQwgACS+l4I+3DeEnWiZkx6zXWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CjeBsTnh; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CjeBsTnh" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-44ffed84cccso1659008b6e.0 for ; Sat, 27 Dec 2025 10:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1766859654; x=1767464454; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J2j9oSp9OzmTh5S36B2mxVYf+/+BpGtxTc6qLR8BJ9M=; b=CjeBsTnhbYSeS+DGE1mvhLwaO4nUbr8J+YRjXDqGOsyVPHw4SbVmALgVu5DvRjw2h1 582ZzK1dSfOLKE1GJOmJGiUi2ZbylESQQ7yjgzh7cae8hbclZM4Ry+LqJ2QKh7hahv0s OQ2S8PDOaxbtR6h++BnSNVLKkYrHl1MZLoGUTNpZr27lX2TS8hq8YbrfS+NkXXyzR15x KZSCYEsKgr0gnsky8sEaJ2ht1yVli6BlpqXsI4YwJo14DIQMnMRYzTJXvGUyW3Jxf9wD YdfKUqf5l6JX77YJQKe1XAdgBGbrDOjqiBDEJ8wyj6kU2c4994vPPdJYC9aDSM42De+G B2YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766859654; x=1767464454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J2j9oSp9OzmTh5S36B2mxVYf+/+BpGtxTc6qLR8BJ9M=; b=gU/3BhMnW1zboOhMgZZL49hW/Hn2mSfirn0whqA9hijtgOIE4A01yj7NJraZ1QQkVL wETx3A95q4x9MK7PvAz5CcZlDhmEWstA63oVmnMVC8/Cox246Yh2Jhgsp4vae/u8S0rW 5bW9ilyAuj2wpAIzFpY+fe2oPEysp3Aavr3NjtDKi5tnfWQl5oFf6uCYHK9Ym2PLaAna A37QXdQlCWHUtZklju6hYXCtGxbPg0EfgmGKMuI5bGURqYSNC0yrTf2uo8xFg4h/bl9U t6Ms/47b69GAk+38h1AUfL8tl3DCypoIILi35M8hCRwH1zYnFZQ27b2/y5sxRd2qyD3v BrIA== X-Forwarded-Encrypted: i=1; AJvYcCVMzH6xhz0EhA8lWkH/Zx3tz2yS834r1Wqw2JNd11rXgjk6FpjHV5ZPTBDW0mjdfZSYULaLw2r1lH03itc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw42ICX8TqpLJieh8UueoTjDA7ZoZfj/nmlNNB7qp1ck82apbI stya1MxBHgoUcqKYwW+HQCJBcIm8v5NGt5sHvZAGq4sxCUJ6M3L5t2IQcQEAMzCAJtg= X-Gm-Gg: AY/fxX42O3lIA7UScvSMErhBMoawmbF1AXxV3e8J9V5S8f2Sw1PeFx1+ICSXG0S18Q0 Bk778sGEMbwVIPIFjSxqUp8N5fqwjTzxarwsPXc5k6IY5UJfGLnzs4w+SbZ6fOlMbh6Db5RzX+0 Z5ikcghV0+k5Ek52cBCTbY6fCJhkVXmwdTzh/vnClpnWN8m89BG2vcXaksOXxw7xKQCQ5o9+YoQ dq2VVK6ZngZke17NFea4RTqnO7UK8Hvmn1Wj/633fTvzbt6U2rUJJEKGSoXXOkK+N1mz6503ZZJ 6Nebbhp4bQ+qyazyk0wauYS+VgqSxzOCo3zfQBPTdS9Ln3/l9zvzpsDUYpizIaX1bdFucX6wC8C 35PrEuBEmCapKJJi5fA4eUTHIPHfq9mqEuxfJR0Mz9In1sMRB0f29P1eqOIomd4j4Mv6GdncbC1 KzvvRo5T3TErlX4t/ZH2sPzAyhoJUb1Qo0ynigCaK5CIOpqOOpq2OF+ljaIRYf X-Google-Smtp-Source: AGHT+IFPqw8otBicikTMcpttXB+4UlYnr6IaZlBoYe9K5ZRzq3nsV03RecZLJ0LeOfBCKUElLGSUqA== X-Received: by 2002:a05:6808:1b25:b0:450:c0c4:3728 with SMTP id 5614622812f47-457b2175c27mr11920065b6e.30.1766859654263; Sat, 27 Dec 2025 10:20:54 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:81b7:1177:37cc:3153? ([2600:8803:e7e4:500:81b7:1177:37cc:3153]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc667284fdsm17601022a34.2.2025.12.27.10.20.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Dec 2025 10:20:53 -0800 (PST) Message-ID: <6d40a735-ad73-4a21-bd66-3af1edd0d1e7@baylibre.com> Date: Sat, 27 Dec 2025 12:20:51 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] iio: core: Add cleanup.h support for iio_device_claim_*() To: Kurt Borja , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev References: <20251211-lock-impr-v2-0-6fb47bdaaf24@gmail.com> <20251211-lock-impr-v2-4-6fb47bdaaf24@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/27/25 12:04 PM, Kurt Borja wrote: > On Tue Dec 23, 2025 at 12:23 PM -05, David Lechner wrote: >> On 12/11/25 8:45 PM, Kurt Borja wrote: >>> Add guard classes for iio_device_claim_*() conditional locks. This will >>> aid drivers write safer and cleaner code when dealing with some common >>> patterns. >>> >> ... >>> + */ >>> +#define IIO_DEV_ACQUIRE_ERR(_var_ptr) \ >>> + ACQUIRE_ERR(__priv__iio_dev_mode_lock_try_buffer, _var_ptr) >> >> There is no error code here, so calling it "ERR" seems wrong. >> Maybe IIO_DEV_ACQUIRE_FAILED()? > > Here I'd prefer to keep it as _ERR so users can make the immediate > association. But I don't feel strongly about it. I'm afraid I fail to make any association with _ERR() and something that doesn't have an error code. Is this about following the established pattern with ACQUIRE() and ACQUIRE_ERR()? Usually, I am strongly in favor of following patterns like this. But in this case, I just doesn't make logical sense.