From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753945AbdK0RHS (ORCPT ); Mon, 27 Nov 2017 12:07:18 -0500 Received: from ale.deltatee.com ([207.54.116.67]:56680 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbdK0RHO (ORCPT ); Mon, 27 Nov 2017 12:07:14 -0500 To: Joe Perches , Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <1511745165.20482.34.camel@perches.com> <1511774737.32426.29.camel@perches.com> From: Logan Gunthorpe Message-ID: <6d424a99-7c3a-9d15-5651-030f52367749@deltatee.com> Date: Mon, 27 Nov 2017 10:07:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511774737.32426.29.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, joe@perches.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/17 02:25 AM, Joe Perches wrote: > [] > diff -u -p a/lib/locking-selftest.c b/lib/locking-selftest.c > --- a/lib/locking-selftest.c > +++ b/lib/locking-selftest.c > @@ -1186,7 +1186,7 @@ static void dotest(void (*testcase_fn)(v > > static inline void print_testname(const char *testname) > { > - printk("%33s:", testname); > + printk("%33s:\n", testname); > } Coincidentally, the checkpatch script does not hit this false positive. This because a pr_cont actually follows in a #define. It doesn't feel right but checkpatch does do the correct thing on this one. > diff -u -p a/lib/dynamic_debug.c b/lib/dynamic_debug.c > --- a/lib/dynamic_debug.c > +++ b/lib/dynamic_debug.c > @@ -562,7 +562,8 @@ void __dynamic_pr_debug(struct _ddebug * > vaf.fmt = fmt; > vaf.va = &args; > > - printk(KERN_DEBUG "%s%pV", dynamic_emit_prefix(descriptor, buf), &vaf); > + printk(KERN_DEBUG "%s%pV\n", dynamic_emit_prefix(descriptor, buf), > + &vaf); > > va_end(args); > } This is a valid false positive that I also missed. However, it can actually be very easily ignored by checking if the format string ends in %pV. There were about 100 cases in my results that match this. > > diff -u -p a/drivers/tty/serial/ioc4_serial.c b/drivers/tty/serial/ioc4_serial.c > --- a/drivers/tty/serial/ioc4_serial.c > +++ b/drivers/tty/serial/ioc4_serial.c > @@ -2858,8 +2858,7 @@ ioc4_serial_attach_one(struct ioc4_drive > "sgi-ioc4serial", soft)) { > control->ic_irq = idd->idd_pdev->irq; > } else { > - printk(KERN_WARNING > - "%s : request_irq fails for IRQ 0x%x\n ", > + printk(KERN_WARNING "%s : request_irq fails for IRQ 0x%x\n \n", > __func__, idd->idd_pdev->irq); > } > ret = ioc4_attach_local(idd); > > [] This isn't an issue for the checkpatch script as it doesn't try to fix it, it only warns that it is wrong (as it is actually wrong). > diff -u -p a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c > --- a/drivers/isdn/gigaset/ev-layer.c > +++ b/drivers/isdn/gigaset/ev-layer.c > @@ -411,7 +411,7 @@ static void add_cid_event(struct cardsta > unsigned next, tail; > struct event_t *event; > > - gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d", type, cid); > + gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d\n", type, cid); > > spin_lock_irqsave(&cs->ev_lock, flags); This is why I elected to only look at printk, pr_xxx, and dev_xxx in v2 of my patch. So this is another false positive the checkpatch script would not hit. Logan